Print this page
7290 ZFS test suite needs to control what utilities it can run
Reviewed by: Dan Kimmel <dan.kimmel@delphix.com>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>

Split Close
Expand all
Collapse all
          --- old/usr/src/test/zfs-tests/tests/functional/nopwrite/nopwrite_volume.ksh
          +++ new/usr/src/test/zfs-tests/tests/functional/nopwrite/nopwrite_volume.ksh
↓ open down ↓ 4 lines elided ↑ open up ↑
   5    5  # Common Development and Distribution License ("CDDL"), version 1.0.
   6    6  # You may only use this file in accordance with the terms of version
   7    7  # 1.0 of the CDDL.
   8    8  #
   9    9  # A full copy of the text of the CDDL should have accompanied this
  10   10  # source.  A copy of the CDDL is also available via the Internet at
  11   11  # http://www.illumos.org/license/CDDL.
  12   12  #
  13   13  
  14   14  #
  15      -# Copyright (c) 2012 by Delphix. All rights reserved.
       15 +# Copyright (c) 2012, 2016 by Delphix. All rights reserved.
  16   16  #
  17   17  
  18   18  . $STF_SUITE/include/libtest.shlib
  19   19  . $STF_SUITE/tests/functional/nopwrite/nopwrite.shlib
  20   20  
  21   21  #
  22   22  # Description:
  23   23  # Verify that nopwrite cannot be enabled on volumes
  24   24  #
  25   25  # Strategy:
↓ open down ↓ 4 lines elided ↑ open up ↑
  30   30  
  31   31  verify_runnable "global"
  32   32  origin="$TESTPOOL/$TESTVOL"
  33   33  clone="$TESTPOOL/clone"
  34   34  vol="/dev/zvol/rdsk/$origin"
  35   35  volclone="/dev/zvol/rdsk/$clone"
  36   36  log_onexit cleanup
  37   37  
  38   38  function cleanup
  39   39  {
  40      -        datasetexists $origin && log_must $ZFS destroy -R $origin
       40 +        datasetexists $origin && log_must zfs destroy -R $origin
  41   41          # No need to recreate the volume as no other tests expect it.
  42   42  }
  43   43  
  44   44  log_assert "nopwrite works on volumes"
  45   45  
  46      -log_must $ZFS set compress=on $origin
  47      -log_must $ZFS set checksum=sha256 $origin
  48      -$DD if=/dev/urandom of=$vol bs=8192 count=4096 conv=notrunc >/dev/null \
       46 +log_must zfs set compress=on $origin
       47 +log_must zfs set checksum=sha256 $origin
       48 +dd if=/dev/urandom of=$vol bs=8192 count=4096 conv=notrunc >/dev/null \
  49   49      2>&1 || log_fail "dd into $orgin failed."
  50      -$ZFS snapshot $origin@a || log_fail "zfs snap failed"
  51      -log_must $ZFS clone $origin@a $clone
  52      -log_must $ZFS set compress=on $clone
  53      -log_must $ZFS set checksum=sha256 $clone
  54      -$DD if=$vol of=$volclone bs=8192 count=4096 conv=notrunc >/dev/null 2>&1 || \
       50 +zfs snapshot $origin@a || log_fail "zfs snap failed"
       51 +log_must zfs clone $origin@a $clone
       52 +log_must zfs set compress=on $clone
       53 +log_must zfs set checksum=sha256 $clone
       54 +dd if=$vol of=$volclone bs=8192 count=4096 conv=notrunc >/dev/null 2>&1 || \
  55   55      log_fail "dd into $clone failed."
  56   56  log_must verify_nopwrite $origin $origin@a $clone
  57   57  
  58   58  log_pass "nopwrite works on volumes"
    
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX