7290 ZFS test suite needs to control what utilities it can run
Reviewed by: Dan Kimmel <dan.kimmel@delphix.com>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>

          --- old/usr/src/test/zfs-tests/tests/functional/nopwrite/nopwrite_copies.ksh
          +++ new/usr/src/test/zfs-tests/tests/functional/nopwrite/nopwrite_copies.ksh

   1    1  #!/usr/bin/ksh
   2    2  
   3    3  #
   4    4  # This file and its contents are supplied under the terms of the

   5    5  # Common Development and Distribution License ("CDDL"), version 1.0.
   6    6  # You may only use this file in accordance with the terms of version
   7    7  # 1.0 of the CDDL.
   8    8  #
   9    9  # A full copy of the text of the CDDL should have accompanied this
  10   10  # source.  A copy of the CDDL is also available via the Internet at
  11   11  # http://www.illumos.org/license/CDDL.
  12   12  #
  13   13  
  14   14  #
  15      -# Copyright (c) 2012 by Delphix. All rights reserved.
       15 +# Copyright (c) 2012, 2016 by Delphix. All rights reserved.
  16   16  #
  17   17  
  18   18  . $STF_SUITE/include/libtest.shlib
  19   19  . $STF_SUITE/tests/functional/nopwrite/nopwrite.shlib
  20   20  
  21   21  #
  22   22  # Description:
  23   23  # Verify that nopwrite is not enabled if the copies property changes
  24   24  #
  25   25  # Strategy:

  26   26  # 1. Create a clone with copies set higher than the origin fs

  27   27  # 2. Verify that nopwrite is in use.
  28   28  # 3. Repeat with the number of copies decreased.
  29   29  #
  30   30  
  31   31  verify_runnable "global"
  32   32  origin="$TESTPOOL/$TESTFS"
  33   33  log_onexit cleanup
  34   34  
  35   35  function cleanup
  36   36  {
  37      -        datasetexists $origin && log_must $ZFS destroy -R $origin
  38      -        log_must $ZFS create -o mountpoint=$TESTDIR $origin
       37 +        datasetexists $origin && log_must zfs destroy -R $origin
       38 +        log_must zfs create -o mountpoint=$TESTDIR $origin
  39   39  }
  40   40  
  41   41  log_assert "nopwrite requires copies property to remain constant"
  42   42  
  43   43  # Verify nopwrite is disabled with increased redundancy
  44      -log_must $ZFS set compress=on $origin
  45      -log_must $ZFS set checksum=sha256 $origin
  46      -$DD if=/dev/urandom of=$TESTDIR/file bs=1024k count=$MEGS conv=notrunc \
       44 +log_must zfs set compress=on $origin
       45 +log_must zfs set checksum=sha256 $origin
       46 +dd if=/dev/urandom of=$TESTDIR/file bs=1024k count=$MEGS conv=notrunc \
  47   47      >/dev/null 2>&1 || log_fail "dd into $TESTDIR/file failed."
  48      -$ZFS snapshot $origin@a || log_fail "zfs snap failed"
  49      -log_must $ZFS clone $origin@a $origin/clone
  50      -$ZFS set copies=3 $origin/clone
  51      -$DD if=/$TESTDIR/file of=/$TESTDIR/clone/file bs=1024k count=$MEGS \
       48 +zfs snapshot $origin@a || log_fail "zfs snap failed"
       49 +log_must zfs clone $origin@a $origin/clone
       50 +zfs set copies=3 $origin/clone
       51 +dd if=/$TESTDIR/file of=/$TESTDIR/clone/file bs=1024k count=$MEGS \
  52   52      conv=notrunc >/dev/null 2>&1 || log_fail "dd failed."
  53   53  log_mustnot verify_nopwrite $origin $origin@a $origin/clone
  54   54  
  55   55  # Verify nopwrite is disabled with decreased redundancy
  56      -$ZFS destroy -R $origin || log_fail "Couldn't destroy $origin"
  57      -$ZFS create -o mountpoint=$TESTDIR $origin || \
       56 +zfs destroy -R $origin || log_fail "Couldn't destroy $origin"
       57 +zfs create -o mountpoint=$TESTDIR $origin || \
  58   58      log_fail "Couldn't recreate $origin"
  59      -log_must $ZFS set compress=on $origin
  60      -log_must $ZFS set copies=3 $origin
  61      -log_must $ZFS set checksum=sha256 $origin
  62      -$DD if=/dev/urandom of=$TESTDIR/file bs=1024k count=$MEGS conv=notrunc \
       59 +log_must zfs set compress=on $origin
       60 +log_must zfs set copies=3 $origin
       61 +log_must zfs set checksum=sha256 $origin
       62 +dd if=/dev/urandom of=$TESTDIR/file bs=1024k count=$MEGS conv=notrunc \
  63   63      >/dev/null 2>&1 || log_fail "dd into $TESTDIR/file failed."
  64      -$ZFS snapshot $origin@a || log_fail "zfs snap failed"
  65      -log_must $ZFS clone $origin@a $origin/clone
  66      -$ZFS set copies=1 $origin/clone
  67      -$DD if=/$TESTDIR/file of=/$TESTDIR/clone/file bs=1024k count=$MEGS \
       64 +zfs snapshot $origin@a || log_fail "zfs snap failed"
       65 +log_must zfs clone $origin@a $origin/clone
       66 +zfs set copies=1 $origin/clone
       67 +dd if=/$TESTDIR/file of=/$TESTDIR/clone/file bs=1024k count=$MEGS \
  68   68      conv=notrunc >/dev/null 2>&1 || log_fail "dd failed."
  69   69  log_mustnot verify_nopwrite $origin $origin@a $origin/clone
  70   70  
  71   71  log_pass "nopwrite requires copies property to remain constant"
    

XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX