Print this page
6096 ZFS_SMB_ACL_RENAME needs to cleanup better
Reviewed by: Matthew Ahrens <mahrens@delphix.com>

Split Close
Expand all
Collapse all
          --- old/usr/src/uts/common/fs/zfs/zfs_ioctl.c
          +++ new/usr/src/uts/common/fs/zfs/zfs_ioctl.c
↓ open down ↓ 5052 lines elided ↑ open up ↑
5053 5053  
5054 5054          case ZFS_SMB_ACL_REMOVE:
5055 5055                  error = VOP_REMOVE(ZTOV(sharedir), zc->zc_string, kcred,
5056 5056                      NULL, 0);
5057 5057                  break;
5058 5058  
5059 5059          case ZFS_SMB_ACL_RENAME:
5060 5060                  if ((error = get_nvlist(zc->zc_nvlist_src,
5061 5061                      zc->zc_nvlist_src_size, zc->zc_iflags, &nvlist)) != 0) {
5062 5062                          VN_RELE(vp);
     5063 +                        VN_RELE(ZTOV(sharedir));
5063 5064                          ZFS_EXIT(zfsvfs);
5064 5065                          return (error);
5065 5066                  }
5066 5067                  if (nvlist_lookup_string(nvlist, ZFS_SMB_ACL_SRC, &src) ||
5067 5068                      nvlist_lookup_string(nvlist, ZFS_SMB_ACL_TARGET,
5068 5069                      &target)) {
5069 5070                          VN_RELE(vp);
5070 5071                          VN_RELE(ZTOV(sharedir));
5071 5072                          ZFS_EXIT(zfsvfs);
5072 5073                          nvlist_free(nvlist);
↓ open down ↓ 1091 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX