Print this page
5111 smb_common_rename uses uninitialized variable
Reviewed by: Gordon Ross <gwr@nexenta.com>

Split Close
Expand all
Collapse all
          --- old/usr/src/uts/common/fs/smbsrv/smb_rename.c
          +++ new/usr/src/uts/common/fs/smbsrv/smb_rename.c
↓ open down ↓ 339 lines elided ↑ open up ↑
 340  340                  smb_node_ref(src_fqi->fq_dnode);
 341  341          } else {
 342  342                  /* lookup and validate src node */
 343  343                  rc = smb_rename_lookup_src(sr);
 344  344                  if (rc != 0)
 345  345                          return (rc);
 346  346          }
 347  347  
 348  348          src_fnode = src_fqi->fq_fnode;
 349  349          src_dnode = src_fqi->fq_dnode;
      350 +        tnode = sr->tid_tree->t_snode;
 350  351  
 351  352          /* Find destination dnode and last_comp */
 352  353          if (dst_fqi->fq_dnode) {
 353  354                  smb_node_ref(dst_fqi->fq_dnode);
 354  355          } else {
 355      -                tnode = sr->tid_tree->t_snode;
 356  356                  rc = smb_pathname_reduce(sr, sr->user_cr, path, tnode, tnode,
 357  357                      &dst_fqi->fq_dnode, dst_fqi->fq_last_comp);
 358  358                  if (rc != 0) {
 359  359                          smb_rename_release_src(sr);
 360  360                          return (rc);
 361  361                  }
 362  362          }
 363  363  
 364  364          dst_dnode = dst_fqi->fq_dnode;
 365  365          new_name = dst_fqi->fq_last_comp;
↓ open down ↓ 454 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX