15291 zfs-tests errno flaws exposed by 15220

          --- old/usr/src/test/zfs-tests/cmd/file_check/file_check.c
          +++ new/usr/src/test/zfs-tests/cmd/file_check/file_check.c

   1    1  /*
   2    2   * CDDL HEADER START
   3    3   *
   4    4   * The contents of this file are subject to the terms of the
   5    5   * Common Development and Distribution License (the "License").
   6    6   * You may not use this file except in compliance with the License.
   7    7   *
   8    8   * You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
   9    9   * or http://www.opensolaris.org/os/licensing.
  10   10   * See the License for the specific language governing permissions
  11   11   * and limitations under the License.
  12   12   *
  13   13   * When distributing Covered Code, include this CDDL HEADER in each
  14   14   * file and include the License file at usr/src/OPENSOLARIS.LICENSE.
  15   15   * If applicable, add the following below this CDDL HEADER, with the
  16   16   * fields enclosed by brackets "[]" replaced with your own identifying

  17   17   * information: Portions Copyright [yyyy] [name of copyright owner]
  18   18   *
  19   19   * CDDL HEADER END
  20   20   */
  21   21  
  22   22  /*
  23   23   * Copyright 2007 Sun Microsystems, Inc.  All rights reserved.
  24   24   * Use is subject to license terms.
  25   25   */
  26   26  
       27 +/*
       28 + * Copyright 2022 MNX Cloud, Inc.
       29 + */
       30 +
  27   31  #include "../file_common.h"
  28   32  
  29   33  static unsigned char bigbuffer[BIGBUFFERSIZE];
  30   34  
  31   35  /*
  32   36   * Given a filename, check that the file consists entirely
  33   37   * of a particular pattern. If the pattern is not specified a
  34   38   * default will be used. For default values see file_common.h
  35   39   */
  36   40  int

  37   41  main(int argc, char **argv)
  38   42  {
  39   43          int             bigfd;
  40   44          long            i, n;
  41   45          uchar_t         fillchar = DATA;
  42   46          int             bigbuffersize = BIGBUFFERSIZE;
  43   47          int64_t         read_count = 0;
  44   48  
  45   49          /*
  46   50           * Validate arguments
  47   51           */
  48   52          if (argc < 2) {
  49   53                  (void) printf("Usage: %s filename [pattern]\n",
  50   54                      argv[0]);
  51   55                  exit(1);
  52   56          }
  53   57  
  54   58          if (argv[2]) {
  55   59                  fillchar = atoi(argv[2]);
  56   60          }
  57   61  
  58   62          /*

  59   63           * Read the file contents and check every character
  60   64           * against the supplied pattern. Abort if the
  61   65           * pattern check fails.
  62   66           */
  63   67          if ((bigfd = open(argv[1], O_RDONLY)) == -1) {
  64   68                  (void) printf("open %s failed %d\n", argv[1], errno);
  65   69                  exit(1);
  66   70          }
  67   71  
  68   72          do {
       73 +                int exitcode;
       74 +
  69   75                  if ((n = read(bigfd, &bigbuffer, bigbuffersize)) == -1) {
       76 +                        exitcode = errno;
  70   77                          (void) printf("read failed (%ld), %d\n", n, errno);
  71      -                        exit(errno);
       78 +                        exit(exitcode);
  72   79                  }
  73   80  
  74   81                  for (i = 0; i < n; i++) {
  75   82                          if (bigbuffer[i] != fillchar) {
  76   83                                  (void) printf("error %s: 0x%x != 0x%x)\n",
  77   84                                      argv[1], bigbuffer[i], fillchar);
  78   85                                  exit(1);
  79   86                          }
  80   87                  }
  81   88  
  82   89                  read_count += n;
  83   90          } while (n == bigbuffersize);
  84   91  
  85   92          return (0);
  86   93  }
    

XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX