Code Review for s2n-illumos-webrev

Prepared by:Dan McDonald (danmcd) on 2015-Jul-03 01:10 -0400 EDT
Workspace:/export/home/danmcd/ws/s2n (at 709f493b07a0)
Compare against: origin/master (https://github.com/awslabs/s2n.git at 4f7d3e65ac3b)
Summary of changes: 39 lines changed: 7 ins; 0 del; 32 mod; 486 unchg
Patch of changes: s2n-illumos-webrev.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw Makefile 

Don't assume make is gmake
23 lines changed: 0 ins; 0 del; 23 mod; 32 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw bin/Makefile 

Linking fixes for Solarish systems
1 line changed: 0 ins; 0 del; 1 mod; 31 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw bin/echo.c 

ioctl & FIONREAD need more includes on Solarish systems.
2 lines changed: 2 ins; 0 del; 0 mod; 149 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw lib/Makefile 

Linking fixes for Solarish systems
5 lines changed: 3 ins; 0 del; 2 mod; 33 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw s2n.mk 

Lose -Wwrite-strings because of Solarish 'struct option' initialization.
illumos doesn't cope with stack-protector for now.
2 lines changed: 0 ins; 0 del; 2 mod; 30 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw tests/Makefile 

Don't assume make is gmake
4 lines changed: 0 ins; 0 del; 4 mod; 20 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw tls/s2n_recv.c 

_XOPEN_SOURCE not needed for usleep() in Solarish systems.
2 lines changed: 2 ins; 0 del; 0 mod; 191 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.