Code Review for riscv

Prepared by:Dan McDonald on 2018-Aug-30 18:39 -0400 EDT
Workspace:/export/home/danmcd/ws/illumos-joyent (at 9361ac38dae2)
Compare against: origin/vpc (https://github.com/joyent/illumos-joyent at 670942d5ff59)
Summary of changes: 4248 lines changed: 4168 ins; 60 del; 20 mod; 1666 unchg
Patch of changes: riscv.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dis/dis_main.c

OS-7095 Want risc-v disassembler
24 lines changed: 24 ins; 0 del; 0 mod; 767 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/Makefile.com

OS-7095 Want risc-v disassembler
7 lines changed: 5 ins; 0 del; 2 mod; 144 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdisasm/common/dis_riscv.c

OS-7095 Want risc-v disassembler
1977 lines changed: 1977 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/libdisasm.c

OS-7095 Want risc-v disassembler
7 lines changed: 7 ins; 0 del; 0 mod; 323 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/libdisasm.h

OS-7095 Want risc-v disassembler
7 lines changed: 6 ins; 0 del; 1 mod; 94 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/util-tests/tests/dis/Makefile

OS-7095 Want risc-v disassembler
73 lines changed: 2 ins; 60 del; 11 mod; 46 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/util-tests/tests/dis/distest.ksh

OS-7095 Want risc-v disassembler
24 lines changed: 18 ins; 0 del; 6 mod; 292 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v-c/32.ldsr.out

OS-7095 Want risc-v disassembler
7 lines changed: 7 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v-c/32.ldsr.s

OS-7095 Want risc-v disassembler
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v-c/64.int.out

OS-7095 Want risc-v disassembler
5 lines changed: 5 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v-c/64.int.s

OS-7095 Want risc-v disassembler
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v-c/64.ldsr.out

OS-7095 Want risc-v disassembler
10 lines changed: 10 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v-c/64.ldsr.s

OS-7095 Want risc-v disassembler
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v-c/tst.int.out

OS-7095 Want risc-v disassembler
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v-c/tst.int.s

OS-7095 Want risc-v disassembler
59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v-c/tst.ldsr.out

OS-7095 Want risc-v disassembler
9 lines changed: 9 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v-c/tst.ldsr.s

OS-7095 Want risc-v disassembler
38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/64.rv64a.out

OS-7095 Want risc-v disassembler
44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/64.rv64a.s

OS-7095 Want risc-v disassembler
70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/64.rv64d.out

OS-7095 Want risc-v disassembler
26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/64.rv64d.s

OS-7095 Want risc-v disassembler
57 lines changed: 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/64.rv64f.out

OS-7095 Want risc-v disassembler
24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/64.rv64f.s

OS-7095 Want risc-v disassembler
53 lines changed: 53 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/64.rv64i.out

OS-7095 Want risc-v disassembler
25 lines changed: 25 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/64.rv64i.s

OS-7095 Want risc-v disassembler
52 lines changed: 52 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/64.rv64m.out

OS-7095 Want risc-v disassembler
5 lines changed: 5 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/64.rv64m.s

OS-7095 Want risc-v disassembler
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/tst.csr.out

OS-7095 Want risc-v disassembler
129 lines changed: 129 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/tst.csr.s

OS-7095 Want risc-v disassembler
168 lines changed: 168 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/tst.fpregs.out

OS-7095 Want risc-v disassembler
64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/tst.fpregs.s

OS-7095 Want risc-v disassembler
92 lines changed: 92 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/tst.pseudo.out

OS-7095 Want risc-v disassembler
26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/tst.pseudo.s

OS-7095 Want risc-v disassembler
54 lines changed: 54 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/tst.regs.out

OS-7095 Want risc-v disassembler
64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/tst.regs.s

OS-7095 Want risc-v disassembler
90 lines changed: 90 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/tst.rv32a.out

OS-7095 Want risc-v disassembler
44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/tst.rv32a.s

OS-7095 Want risc-v disassembler
70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/tst.rv32d.out

OS-7095 Want risc-v disassembler
90 lines changed: 90 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/tst.rv32d.s

OS-7095 Want risc-v disassembler
132 lines changed: 132 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/tst.rv32f.out

OS-7095 Want risc-v disassembler
95 lines changed: 95 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/tst.rv32f.s

OS-7095 Want risc-v disassembler
137 lines changed: 137 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/tst.rv32i.out

OS-7095 Want risc-v disassembler
60 lines changed: 60 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/tst.rv32i.s

OS-7095 Want risc-v disassembler
91 lines changed: 91 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/tst.rv32m.out

OS-7095 Want risc-v disassembler
8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/tst.rv32m.s

OS-7095 Want risc-v disassembler
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/tst.supervisor.out

OS-7095 Want risc-v disassembler
7 lines changed: 7 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/dis/risc-v/tst.supervisor.s

OS-7095 Want risc-v disassembler
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.