Code Review for rfd163-new-world

Prepared by:Dan McDonald on 2019-Mar-14 17:20 -0400 EDT
Workspace:/home/danmcd/smartos-live-DEBUG/projects/illumos (at b3e79917bbde)
Compare against: origin/master (https://github.com/joyent/illumos-joyent.git at c767c5a53dc0)
Summary of changes: 308 lines changed: 300 ins; 1 del; 7 mod; 16875 unchg
Patch of changes: rfd163-new-world.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ipf/tools/Makefile.tools

Only exploit ipf state keeping for CFW logging.
1 line changed: 0 ins; 0 del; 1 mod; 270 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/Makefile.files

Only exploit ipf state keeping for CFW logging.
3 lines changed: 0 ins; 0 del; 3 mod; 2284 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/ipf/cfw.c

include-hell cleanup
Only exploit ipf state keeping for CFW logging.
272 lines changed: 272 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ipf/fil.c

Only exploit ipf state keeping for CFW logging.
3 lines changed: 3 ins; 0 del; 0 mod; 7738 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ipf/ip_state.c

Only exploit ipf state keeping for CFW logging.
15 lines changed: 13 ins; 1 del; 1 mod; 4444 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ipf/netinet/ip_fil.h

Only exploit ipf state keeping for CFW logging.
9 lines changed: 8 ins; 0 del; 1 mod; 1620 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ipf/netinet/ipf_stack.h

Only exploit ipf state keeping for CFW logging.
3 lines changed: 2 ins; 0 del; 1 mod; 324 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/ipf/ipf.global-objs.debug64

Only exploit ipf state keeping for CFW logging.
1 line changed: 1 ins; 0 del; 0 mod; 103 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/ipf/ipf.global-objs.debug64

Only exploit ipf state keeping for CFW logging.
1 line changed: 1 ins; 0 del; 0 mod; 92 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.