Code Review for zfs-comment

Prepared by:Dan McDonald <danmcd@nexenta.com> on 2011-Nov-14 10:30 -0500 EST
Workspace:/export/home/danmcd/ws/zfs-comment (at 15808b64ab23)
Compare against: /export/home/danmcd/ws/illumos-clone (at 5a0585080fb5)
Summary of changes: 150 lines changed: 122 ins; 1 del; 27 mod; 19813 unchg
Patch of changes: zfs-comment.patch
Printable review: zfs-comment.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zpool/zpool_main.c

1693 persistent 'comment' field for a zpool
29 lines changed: 6 ins; 0 del; 23 mod; 4534 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/zfs/zpool_prop.c

1693 persistent 'comment' field for a zpool
4 lines changed: 4 ins; 0 del; 0 mod; 202 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzfs/common/libzfs_import.c

1693 persistent 'comment' field for a zpool
17 lines changed: 16 ins; 0 del; 1 mod; 1687 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzfs/common/libzfs_pool.c

1693 persistent 'comment' field for a zpool
22 lines changed: 21 ins; 0 del; 1 mod; 3824 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1m/zpool.1m

1693 persistent 'comment' field for a zpool
14 lines changed: 12 ins; 1 del; 1 mod; 2003 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/spa.c

1693 persistent 'comment' field for a zpool
50 lines changed: 49 ins; 0 del; 1 mod; 5920 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/spa_config.c

1693 persistent 'comment' field for a zpool
6 lines changed: 6 ins; 0 del; 0 mod; 487 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sys/spa_impl.h

1693 persistent 'comment' field for a zpool
2 lines changed: 2 ins; 0 del; 0 mod; 239 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/fs/zfs.h

1693 persistent 'comment' field for a zpool
6 lines changed: 6 ins; 0 del; 0 mod; 917 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.