Print this page
XXXX Intel X540 support
        
*** 1,8 ****
  /******************************************************************************
  
!   Copyright (c) 2001-2010, Intel Corporation 
    All rights reserved.
    
    Redistribution and use in source and binary forms, with or without 
    modification, are permitted provided that the following conditions are met:
    
--- 1,8 ----
  /******************************************************************************
  
!   Copyright (c) 2001-2012, Intel Corporation 
    All rights reserved.
    
    Redistribution and use in source and binary forms, with or without 
    modification, are permitted provided that the following conditions are met:
    
*** 28,38 ****
    CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) 
    ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
    POSSIBILITY OF SUCH DAMAGE.
  
  ******************************************************************************/
! /*$FreeBSD$*/
  
  #include "ixgbe_api.h"
  #include "ixgbe_common.h"
  #include "ixgbe_phy.h"
  
--- 28,38 ----
    CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) 
    ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
    POSSIBILITY OF SUCH DAMAGE.
  
  ******************************************************************************/
! /*$FreeBSD: src/sys/dev/ixgbe/ixgbe_phy.c,v 1.13 2012/07/05 20:51:44 jfv Exp $*/
  
  #include "ixgbe_api.h"
  #include "ixgbe_common.h"
  #include "ixgbe_phy.h"
  
*** 41,55 ****
  static s32 ixgbe_clock_in_i2c_byte(struct ixgbe_hw *hw, u8 *data);
  static s32 ixgbe_clock_out_i2c_byte(struct ixgbe_hw *hw, u8 data);
  static s32 ixgbe_get_i2c_ack(struct ixgbe_hw *hw);
  static s32 ixgbe_clock_in_i2c_bit(struct ixgbe_hw *hw, bool *data);
  static s32 ixgbe_clock_out_i2c_bit(struct ixgbe_hw *hw, bool data);
! static s32 ixgbe_raise_i2c_clk(struct ixgbe_hw *hw, u32 *i2cctl);
  static void ixgbe_lower_i2c_clk(struct ixgbe_hw *hw, u32 *i2cctl);
  static s32 ixgbe_set_i2c_data(struct ixgbe_hw *hw, u32 *i2cctl, bool data);
  static bool ixgbe_get_i2c_data(u32 *i2cctl);
- void ixgbe_i2c_bus_clear(struct ixgbe_hw *hw);
  
  /**
   *  ixgbe_init_phy_ops_generic - Inits PHY function ptrs
   *  @hw: pointer to the hardware structure
   *
--- 41,54 ----
  static s32 ixgbe_clock_in_i2c_byte(struct ixgbe_hw *hw, u8 *data);
  static s32 ixgbe_clock_out_i2c_byte(struct ixgbe_hw *hw, u8 data);
  static s32 ixgbe_get_i2c_ack(struct ixgbe_hw *hw);
  static s32 ixgbe_clock_in_i2c_bit(struct ixgbe_hw *hw, bool *data);
  static s32 ixgbe_clock_out_i2c_bit(struct ixgbe_hw *hw, bool data);
! static void ixgbe_raise_i2c_clk(struct ixgbe_hw *hw, u32 *i2cctl);
  static void ixgbe_lower_i2c_clk(struct ixgbe_hw *hw, u32 *i2cctl);
  static s32 ixgbe_set_i2c_data(struct ixgbe_hw *hw, u32 *i2cctl, bool data);
  static bool ixgbe_get_i2c_data(u32 *i2cctl);
  
  /**
   *  ixgbe_init_phy_ops_generic - Inits PHY function ptrs
   *  @hw: pointer to the hardware structure
   *
*** 73,83 ****
          phy->ops.read_i2c_byte = &ixgbe_read_i2c_byte_generic;
          phy->ops.write_i2c_byte = &ixgbe_write_i2c_byte_generic;
          phy->ops.read_i2c_eeprom = &ixgbe_read_i2c_eeprom_generic;
          phy->ops.write_i2c_eeprom = &ixgbe_write_i2c_eeprom_generic;
          phy->ops.i2c_bus_clear = &ixgbe_i2c_bus_clear;
!         phy->ops.identify_sfp = &ixgbe_identify_sfp_module_generic;
          phy->sfp_type = ixgbe_sfp_type_unknown;
          phy->ops.check_overtemp = &ixgbe_tn_check_overtemp;
          return IXGBE_SUCCESS;
  }
  
--- 72,82 ----
          phy->ops.read_i2c_byte = &ixgbe_read_i2c_byte_generic;
          phy->ops.write_i2c_byte = &ixgbe_write_i2c_byte_generic;
          phy->ops.read_i2c_eeprom = &ixgbe_read_i2c_eeprom_generic;
          phy->ops.write_i2c_eeprom = &ixgbe_write_i2c_eeprom_generic;
          phy->ops.i2c_bus_clear = &ixgbe_i2c_bus_clear;
!         phy->ops.identify_sfp = &ixgbe_identify_module_generic;
          phy->sfp_type = ixgbe_sfp_type_unknown;
          phy->ops.check_overtemp = &ixgbe_tn_check_overtemp;
          return IXGBE_SUCCESS;
  }
  
*** 97,107 ****
  
          if (hw->phy.type == ixgbe_phy_unknown) {
                  for (phy_addr = 0; phy_addr < IXGBE_MAX_PHY_ADDR; phy_addr++) {
                          if (ixgbe_validate_phy_addr(hw, phy_addr)) {
                                  hw->phy.addr = phy_addr;
!                                 (void) ixgbe_get_phy_id(hw);
                                  hw->phy.type =
                                          ixgbe_get_phy_type_from_id(hw->phy.id);
  
                                  if (hw->phy.type == ixgbe_phy_unknown) {
                                          hw->phy.ops.read_reg(hw,
--- 96,106 ----
  
          if (hw->phy.type == ixgbe_phy_unknown) {
                  for (phy_addr = 0; phy_addr < IXGBE_MAX_PHY_ADDR; phy_addr++) {
                          if (ixgbe_validate_phy_addr(hw, phy_addr)) {
                                  hw->phy.addr = phy_addr;
!                                 ixgbe_get_phy_id(hw);
                                  hw->phy.type =
                                          ixgbe_get_phy_type_from_id(hw->phy.id);
  
                                  if (hw->phy.type == ixgbe_phy_unknown) {
                                          hw->phy.ops.read_reg(hw,
*** 195,205 ****
  
          switch (phy_id) {
          case TN1010_PHY_ID:
                  phy_type = ixgbe_phy_tn;
                  break;
!         case AQ1002_PHY_ID:
                  phy_type = ixgbe_phy_aq;
                  break;
          case QT2022_PHY_ID:
                  phy_type = ixgbe_phy_qt;
                  break;
--- 194,204 ----
  
          switch (phy_id) {
          case TN1010_PHY_ID:
                  phy_type = ixgbe_phy_tn;
                  break;
!         case X540_PHY_ID:
                  phy_type = ixgbe_phy_aq;
                  break;
          case QT2022_PHY_ID:
                  phy_type = ixgbe_phy_qt;
                  break;
*** 290,300 ****
          if (IXGBE_READ_REG(hw, IXGBE_STATUS) & IXGBE_STATUS_LAN_ID_1)
                  gssr = IXGBE_GSSR_PHY1_SM;
          else
                  gssr = IXGBE_GSSR_PHY0_SM;
  
!         if (ixgbe_acquire_swfw_sync(hw, gssr) != IXGBE_SUCCESS)
                  status = IXGBE_ERR_SWFW_SYNC;
  
          if (status == IXGBE_SUCCESS) {
                  /* Setup and write the address cycle command */
                  command = ((reg_addr << IXGBE_MSCA_NP_ADDR_SHIFT)  |
--- 289,299 ----
          if (IXGBE_READ_REG(hw, IXGBE_STATUS) & IXGBE_STATUS_LAN_ID_1)
                  gssr = IXGBE_GSSR_PHY1_SM;
          else
                  gssr = IXGBE_GSSR_PHY0_SM;
  
!         if (hw->mac.ops.acquire_swfw_sync(hw, gssr) != IXGBE_SUCCESS)
                  status = IXGBE_ERR_SWFW_SYNC;
  
          if (status == IXGBE_SUCCESS) {
                  /* Setup and write the address cycle command */
                  command = ((reg_addr << IXGBE_MSCA_NP_ADDR_SHIFT)  |
*** 361,371 ****
                                  data >>= IXGBE_MSRWD_READ_DATA_SHIFT;
                                  *phy_data = (u16)(data);
                          }
                  }
  
!                 ixgbe_release_swfw_sync(hw, gssr);
          }
  
          return status;
  }
  
--- 360,370 ----
                                  data >>= IXGBE_MSRWD_READ_DATA_SHIFT;
                                  *phy_data = (u16)(data);
                          }
                  }
  
!                 hw->mac.ops.release_swfw_sync(hw, gssr);
          }
  
          return status;
  }
  
*** 389,399 ****
          if (IXGBE_READ_REG(hw, IXGBE_STATUS) & IXGBE_STATUS_LAN_ID_1)
                  gssr = IXGBE_GSSR_PHY1_SM;
          else
                  gssr = IXGBE_GSSR_PHY0_SM;
  
!         if (ixgbe_acquire_swfw_sync(hw, gssr) != IXGBE_SUCCESS)
                  status = IXGBE_ERR_SWFW_SYNC;
  
          if (status == IXGBE_SUCCESS) {
                  /* Put the data in the MDI single read and write data register*/
                  IXGBE_WRITE_REG(hw, IXGBE_MSRWD, (u32)phy_data);
--- 388,398 ----
          if (IXGBE_READ_REG(hw, IXGBE_STATUS) & IXGBE_STATUS_LAN_ID_1)
                  gssr = IXGBE_GSSR_PHY1_SM;
          else
                  gssr = IXGBE_GSSR_PHY0_SM;
  
!         if (hw->mac.ops.acquire_swfw_sync(hw, gssr) != IXGBE_SUCCESS)
                  status = IXGBE_ERR_SWFW_SYNC;
  
          if (status == IXGBE_SUCCESS) {
                  /* Put the data in the MDI single read and write data register*/
                  IXGBE_WRITE_REG(hw, IXGBE_MSRWD, (u32)phy_data);
*** 455,465 ****
                                  DEBUGOUT("PHY address cmd didn't complete\n");
                                  status = IXGBE_ERR_PHY;
                          }
                  }
  
!                 ixgbe_release_swfw_sync(hw, gssr);
          }
  
          return status;
  }
  
--- 454,464 ----
                                  DEBUGOUT("PHY address cmd didn't complete\n");
                                  status = IXGBE_ERR_PHY;
                          }
                  }
  
!                 hw->mac.ops.release_swfw_sync(hw, gssr);
          }
  
          return status;
  }
  
*** 478,488 ****
          bool autoneg = FALSE;
          ixgbe_link_speed speed;
  
          DEBUGFUNC("ixgbe_setup_phy_link_generic");
  
!         (void) ixgbe_get_copper_link_capabilities_generic(hw, &speed, &autoneg);
  
          if (speed & IXGBE_LINK_SPEED_10GB_FULL) {
                  /* Set or unset auto-negotiation 10G advertisement */
                  hw->phy.ops.read_reg(hw, IXGBE_MII_10GBASE_T_AUTONEG_CTRL_REG,
                                       IXGBE_MDIO_AUTO_NEG_DEV_TYPE,
--- 477,487 ----
          bool autoneg = FALSE;
          ixgbe_link_speed speed;
  
          DEBUGFUNC("ixgbe_setup_phy_link_generic");
  
!         ixgbe_get_copper_link_capabilities_generic(hw, &speed, &autoneg);
  
          if (speed & IXGBE_LINK_SPEED_10GB_FULL) {
                  /* Set or unset auto-negotiation 10G advertisement */
                  hw->phy.ops.read_reg(hw, IXGBE_MII_10GBASE_T_AUTONEG_CTRL_REG,
                                       IXGBE_MDIO_AUTO_NEG_DEV_TYPE,
*** 518,528 ****
                  /* Set or unset auto-negotiation 100M advertisement */
                  hw->phy.ops.read_reg(hw, IXGBE_MII_AUTONEG_ADVERTISE_REG,
                                       IXGBE_MDIO_AUTO_NEG_DEV_TYPE,
                                       &autoneg_reg);
  
!                 autoneg_reg &= ~IXGBE_MII_100BASE_T_ADVERTISE;
                  if (hw->phy.autoneg_advertised & IXGBE_LINK_SPEED_100_FULL)
                          autoneg_reg |= IXGBE_MII_100BASE_T_ADVERTISE;
  
                  hw->phy.ops.write_reg(hw, IXGBE_MII_AUTONEG_ADVERTISE_REG,
                                        IXGBE_MDIO_AUTO_NEG_DEV_TYPE,
--- 517,528 ----
                  /* Set or unset auto-negotiation 100M advertisement */
                  hw->phy.ops.read_reg(hw, IXGBE_MII_AUTONEG_ADVERTISE_REG,
                                       IXGBE_MDIO_AUTO_NEG_DEV_TYPE,
                                       &autoneg_reg);
  
!                 autoneg_reg &= ~(IXGBE_MII_100BASE_T_ADVERTISE |
!                                  IXGBE_MII_100BASE_T_ADVERTISE_HALF);
                  if (hw->phy.autoneg_advertised & IXGBE_LINK_SPEED_100_FULL)
                          autoneg_reg |= IXGBE_MII_100BASE_T_ADVERTISE;
  
                  hw->phy.ops.write_reg(hw, IXGBE_MII_AUTONEG_ADVERTISE_REG,
                                        IXGBE_MDIO_AUTO_NEG_DEV_TYPE,
*** 545,558 ****
                  status = hw->phy.ops.read_reg(hw, IXGBE_MDIO_AUTO_NEG_STATUS,
                                                IXGBE_MDIO_AUTO_NEG_DEV_TYPE,
                                                &autoneg_reg);
  
                  autoneg_reg &= IXGBE_MII_AUTONEG_COMPLETE;
!                 if (autoneg_reg == IXGBE_MII_AUTONEG_COMPLETE) {
                          break;
                  }
-         }
  
          if (time_out == max_time_out) {
                  status = IXGBE_ERR_LINK_SETUP;
                  DEBUGOUT("ixgbe_setup_phy_link_generic: time out");
          }
--- 545,557 ----
                  status = hw->phy.ops.read_reg(hw, IXGBE_MDIO_AUTO_NEG_STATUS,
                                                IXGBE_MDIO_AUTO_NEG_DEV_TYPE,
                                                &autoneg_reg);
  
                  autoneg_reg &= IXGBE_MII_AUTONEG_COMPLETE;
!                 if (autoneg_reg == IXGBE_MII_AUTONEG_COMPLETE)
                          break;
          }
  
          if (time_out == max_time_out) {
                  status = IXGBE_ERR_LINK_SETUP;
                  DEBUGOUT("ixgbe_setup_phy_link_generic: time out");
          }
*** 569,580 ****
  s32 ixgbe_setup_phy_link_speed_generic(struct ixgbe_hw *hw,
                                         ixgbe_link_speed speed,
                                         bool autoneg,
                                         bool autoneg_wait_to_complete)
  {
!         UNREFERENCED_PARAMETER(autoneg);
!         UNREFERENCED_PARAMETER(autoneg_wait_to_complete);
  
          DEBUGFUNC("ixgbe_setup_phy_link_speed_generic");
  
          /*
           * Clear autoneg_advertised and set new values based on input link
--- 568,578 ----
  s32 ixgbe_setup_phy_link_speed_generic(struct ixgbe_hw *hw,
                                         ixgbe_link_speed speed,
                                         bool autoneg,
                                         bool autoneg_wait_to_complete)
  {
!         UNREFERENCED_2PARAMETER(autoneg, autoneg_wait_to_complete);
  
          DEBUGFUNC("ixgbe_setup_phy_link_speed_generic");
  
          /*
           * Clear autoneg_advertised and set new values based on input link
*** 665,676 ****
                  usec_delay(10);
                  status = hw->phy.ops.read_reg(hw,
                                          IXGBE_MDIO_VENDOR_SPECIFIC_1_STATUS,
                                          IXGBE_MDIO_VENDOR_SPECIFIC_1_DEV_TYPE,
                                          &phy_data);
!                 phy_link = phy_data &
!                            IXGBE_MDIO_VENDOR_SPECIFIC_1_LINK_STATUS;
                  phy_speed = phy_data &
                              IXGBE_MDIO_VENDOR_SPECIFIC_1_SPEED_STATUS;
                  if (phy_link == IXGBE_MDIO_VENDOR_SPECIFIC_1_LINK_STATUS) {
                          *link_up = TRUE;
                          if (phy_speed ==
--- 663,673 ----
                  usec_delay(10);
                  status = hw->phy.ops.read_reg(hw,
                                          IXGBE_MDIO_VENDOR_SPECIFIC_1_STATUS,
                                          IXGBE_MDIO_VENDOR_SPECIFIC_1_DEV_TYPE,
                                          &phy_data);
!                 phy_link = phy_data & IXGBE_MDIO_VENDOR_SPECIFIC_1_LINK_STATUS;
                  phy_speed = phy_data &
                                   IXGBE_MDIO_VENDOR_SPECIFIC_1_SPEED_STATUS;
                  if (phy_link == IXGBE_MDIO_VENDOR_SPECIFIC_1_LINK_STATUS) {
                          *link_up = TRUE;
                          if (phy_speed ==
*** 698,708 ****
          bool autoneg = FALSE;
          ixgbe_link_speed speed;
  
          DEBUGFUNC("ixgbe_setup_phy_link_tnx");
  
!         (void) ixgbe_get_copper_link_capabilities_generic(hw, &speed, &autoneg);
  
          if (speed & IXGBE_LINK_SPEED_10GB_FULL) {
                  /* Set or unset auto-negotiation 10G advertisement */
                  hw->phy.ops.read_reg(hw, IXGBE_MII_10GBASE_T_AUTONEG_CTRL_REG,
                                       IXGBE_MDIO_AUTO_NEG_DEV_TYPE,
--- 695,705 ----
          bool autoneg = FALSE;
          ixgbe_link_speed speed;
  
          DEBUGFUNC("ixgbe_setup_phy_link_tnx");
  
!         ixgbe_get_copper_link_capabilities_generic(hw, &speed, &autoneg);
  
          if (speed & IXGBE_LINK_SPEED_10GB_FULL) {
                  /* Set or unset auto-negotiation 10G advertisement */
                  hw->phy.ops.read_reg(hw, IXGBE_MII_10GBASE_T_AUTONEG_CTRL_REG,
                                       IXGBE_MDIO_AUTO_NEG_DEV_TYPE,
*** 763,776 ****
                  status = hw->phy.ops.read_reg(hw, IXGBE_MDIO_AUTO_NEG_STATUS,
                                                IXGBE_MDIO_AUTO_NEG_DEV_TYPE,
                                                &autoneg_reg);
  
                  autoneg_reg &= IXGBE_MII_AUTONEG_COMPLETE;
!                 if (autoneg_reg == IXGBE_MII_AUTONEG_COMPLETE) {
                          break;
                  }
-         }
  
          if (time_out == max_time_out) {
                  status = IXGBE_ERR_LINK_SETUP;
                  DEBUGOUT("ixgbe_setup_phy_link_tnx: time out");
          }
--- 760,772 ----
                  status = hw->phy.ops.read_reg(hw, IXGBE_MDIO_AUTO_NEG_STATUS,
                                                IXGBE_MDIO_AUTO_NEG_DEV_TYPE,
                                                &autoneg_reg);
  
                  autoneg_reg &= IXGBE_MII_AUTONEG_COMPLETE;
!                 if (autoneg_reg == IXGBE_MII_AUTONEG_COMPLETE)
                          break;
          }
  
          if (time_out == max_time_out) {
                  status = IXGBE_ERR_LINK_SETUP;
                  DEBUGOUT("ixgbe_setup_phy_link_tnx: time out");
          }
*** 874,884 ****
                          data_offset++;
                          DEBUGOUT1("DELAY: %d MS\n", edata);
                          msec_delay(edata);
                          break;
                  case IXGBE_DATA_NL:
!                         DEBUGOUT("DATA:  \n");
                          data_offset++;
                          hw->eeprom.ops.read(hw, data_offset++,
                                              &phy_offset);
                          for (i = 0; i < edata; i++) {
                                  hw->eeprom.ops.read(hw, data_offset, &eword);
--- 870,880 ----
                          data_offset++;
                          DEBUGOUT1("DELAY: %d MS\n", edata);
                          msec_delay(edata);
                          break;
                  case IXGBE_DATA_NL:
!                         DEBUGOUT("DATA:\n");
                          data_offset++;
                          hw->eeprom.ops.read(hw, data_offset++,
                                              &phy_offset);
                          for (i = 0; i < edata; i++) {
                                  hw->eeprom.ops.read(hw, data_offset, &eword);
*** 890,900 ****
                                  phy_offset++;
                          }
                          break;
                  case IXGBE_CONTROL_NL:
                          data_offset++;
!                         DEBUGOUT("CONTROL: \n");
                          if (edata == IXGBE_CONTROL_EOL_NL) {
                                  DEBUGOUT("EOL\n");
                                  end_data = TRUE;
                          } else if (edata == IXGBE_CONTROL_SOL_NL) {
                                  DEBUGOUT("SOL\n");
--- 886,896 ----
                                  phy_offset++;
                          }
                          break;
                  case IXGBE_CONTROL_NL:
                          data_offset++;
!                         DEBUGOUT("CONTROL:\n");
                          if (edata == IXGBE_CONTROL_EOL_NL) {
                                  DEBUGOUT("EOL\n");
                                  end_data = TRUE;
                          } else if (edata == IXGBE_CONTROL_SOL_NL) {
                                  DEBUGOUT("SOL\n");
*** 914,923 ****
--- 910,946 ----
  out:
          return ret_val;
  }
  
  /**
+  *  ixgbe_identify_module_generic - Identifies module type
+  *  @hw: pointer to hardware structure
+  *
+  *  Determines HW type and calls appropriate function.
+  **/
+ s32 ixgbe_identify_module_generic(struct ixgbe_hw *hw)
+ {
+         s32 status = IXGBE_ERR_SFP_NOT_PRESENT;
+ 
+         DEBUGFUNC("ixgbe_identify_module_generic");
+ 
+         switch (hw->mac.ops.get_media_type(hw)) {
+         case ixgbe_media_type_fiber:
+                 status = ixgbe_identify_sfp_module_generic(hw);
+                 break;
+ 
+ 
+         default:
+                 hw->phy.sfp_type = ixgbe_sfp_type_not_present;
+                 status = IXGBE_ERR_SFP_NOT_PRESENT;
+                 break;
+         }
+ 
+         return status;
+ }
+ 
+ /**
   *  ixgbe_identify_sfp_module_generic - Identifies SFP modules
   *  @hw: pointer to hardware structure
   *
   *  Searches for and identifies the SFP module and assigns appropriate PHY type.
   **/
*** 995,1004 ****
--- 1018,1029 ----
                    * 6   SFP_SR/LR_CORE1 - 82599-specific
                    * 7   SFP_act_lmt_DA_CORE0 - 82599-specific
                    * 8   SFP_act_lmt_DA_CORE1 - 82599-specific
                    * 9   SFP_1g_cu_CORE0 - 82599-specific
                    * 10  SFP_1g_cu_CORE1 - 82599-specific
+                   * 11  SFP_1g_sx_CORE0 - 82599-specific
+                   * 12  SFP_1g_sx_CORE1 - 82599-specific
                    */
                  if (hw->mac.type == ixgbe_mac_82598EB) {
                          if (cable_tech & IXGBE_SFF_DA_PASSIVE_CABLE)
                                  hw->phy.sfp_type = ixgbe_sfp_type_da_cu;
                          else if (comp_codes_10g & IXGBE_SFF_10GBASESR_CAPABLE)
*** 1045,1054 ****
--- 1070,1086 ----
                                          hw->phy.sfp_type =
                                                  ixgbe_sfp_type_1g_cu_core0;
                                  else
                                          hw->phy.sfp_type =
                                                  ixgbe_sfp_type_1g_cu_core1;
+                         } else if (comp_codes_1g & IXGBE_SFF_1GBASESX_CAPABLE) {
+                                 if (hw->bus.lan_id == 0)
+                                         hw->phy.sfp_type =
+                                                 ixgbe_sfp_type_1g_sx_core0;
+                                 else
+                                         hw->phy.sfp_type =
+                                                 ixgbe_sfp_type_1g_sx_core1;
                          } else {
                                  hw->phy.sfp_type = ixgbe_sfp_type_unknown;
                          }
                  }
  
*** 1137,1147 ****
                  }
  
                  /* Verify supported 1G SFP modules */
                  if (comp_codes_10g == 0 &&
                      !(hw->phy.sfp_type == ixgbe_sfp_type_1g_cu_core1 ||
!                       hw->phy.sfp_type == ixgbe_sfp_type_1g_cu_core0)) {
                          hw->phy.type = ixgbe_phy_sfp_unsupported;
                          status = IXGBE_ERR_SFP_NOT_SUPPORTED;
                          goto out;
                  }
  
--- 1169,1181 ----
                  }
  
                  /* Verify supported 1G SFP modules */
                  if (comp_codes_10g == 0 &&
                      !(hw->phy.sfp_type == ixgbe_sfp_type_1g_cu_core1 ||
!                       hw->phy.sfp_type == ixgbe_sfp_type_1g_cu_core0 ||
!                       hw->phy.sfp_type == ixgbe_sfp_type_1g_sx_core0  ||
!                       hw->phy.sfp_type == ixgbe_sfp_type_1g_sx_core1)) {
                          hw->phy.type = ixgbe_phy_sfp_unsupported;
                          status = IXGBE_ERR_SFP_NOT_SUPPORTED;
                          goto out;
                  }
  
*** 1149,1170 ****
                  if (hw->mac.type == ixgbe_mac_82598EB) {
                          status = IXGBE_SUCCESS;
                          goto out;
                  }
  
!                 (void) ixgbe_get_device_caps(hw, &enforce_sfp);
                  if (!(enforce_sfp & IXGBE_DEVICE_CAPS_ALLOW_ANY_SFP) &&
                      !((hw->phy.sfp_type == ixgbe_sfp_type_1g_cu_core0) ||
!                       (hw->phy.sfp_type == ixgbe_sfp_type_1g_cu_core1))) {
                          /* Make sure we're a supported PHY type */
                          if (hw->phy.type == ixgbe_phy_sfp_intel) {
                                  status = IXGBE_SUCCESS;
                          } else {
                                  DEBUGOUT("SFP+ module not supported\n");
!                                 hw->phy.type = ixgbe_phy_sfp_unsupported;
                                  status = IXGBE_ERR_SFP_NOT_SUPPORTED;
                          }
                  } else {
                          status = IXGBE_SUCCESS;
                  }
          }
  
--- 1183,1221 ----
                  if (hw->mac.type == ixgbe_mac_82598EB) {
                          status = IXGBE_SUCCESS;
                          goto out;
                  }
  
!                 ixgbe_get_device_caps(hw, &enforce_sfp);
                  if (!(enforce_sfp & IXGBE_DEVICE_CAPS_ALLOW_ANY_SFP) &&
                      !((hw->phy.sfp_type == ixgbe_sfp_type_1g_cu_core0) ||
!                       (hw->phy.sfp_type == ixgbe_sfp_type_1g_cu_core1) ||
!                       (hw->phy.sfp_type == ixgbe_sfp_type_1g_sx_core0)  ||
!                       (hw->phy.sfp_type == ixgbe_sfp_type_1g_sx_core1))) {
                          /* Make sure we're a supported PHY type */
                          if (hw->phy.type == ixgbe_phy_sfp_intel) {
                                  status = IXGBE_SUCCESS;
                          } else {
+                                 if (hw->allow_unsupported_sfp == TRUE) {
+                                         EWARN(hw, "WARNING: Intel (R) Network "
+                                               "Connections are quality tested "
+                                               "using Intel (R) Ethernet Optics."
+                                               " Using untested modules is not "
+                                               "supported and may cause unstable"
+                                               " operation or damage to the "
+                                               "module or the adapter. Intel "
+                                               "Corporation is not responsible "
+                                               "for any harm caused by using "
+                                               "untested modules.\n", status);
+                                         status = IXGBE_SUCCESS;
+                                 } else {
                                          DEBUGOUT("SFP+ module not supported\n");
!                                         hw->phy.type =
!                                                 ixgbe_phy_sfp_unsupported;
                                          status = IXGBE_ERR_SFP_NOT_SUPPORTED;
                                  }
+                         }
                  } else {
                          status = IXGBE_SUCCESS;
                  }
          }
  
*** 1178,1187 ****
--- 1229,1240 ----
                  hw->phy.type = ixgbe_phy_unknown;
          }
          return IXGBE_ERR_SFP_NOT_PRESENT;
  }
  
+ 
+ 
  /**
   *  ixgbe_get_sfp_init_sequence_offsets - Provides offset of PHY init sequence
   *  @hw: pointer to hardware structure
   *  @list_offset: offset to the SFP ID list
   *  @data_offset: offset to the SFP data block
*** 1211,1224 ****
          /*
           * Limiting active cables and 1G Phys must be initialized as
           * SR modules
           */
          if (sfp_type == ixgbe_sfp_type_da_act_lmt_core0 ||
!             sfp_type == ixgbe_sfp_type_1g_cu_core0)
                  sfp_type = ixgbe_sfp_type_srlr_core0;
          else if (sfp_type == ixgbe_sfp_type_da_act_lmt_core1 ||
!                  sfp_type == ixgbe_sfp_type_1g_cu_core1)
                  sfp_type = ixgbe_sfp_type_srlr_core1;
  
          /* Read offset to PHY init contents */
          hw->eeprom.ops.read(hw, IXGBE_PHY_INIT_OFFSET_NL, list_offset);
  
--- 1264,1279 ----
          /*
           * Limiting active cables and 1G Phys must be initialized as
           * SR modules
           */
          if (sfp_type == ixgbe_sfp_type_da_act_lmt_core0 ||
!             sfp_type == ixgbe_sfp_type_1g_cu_core0 ||
!             sfp_type == ixgbe_sfp_type_1g_sx_core0)
                  sfp_type = ixgbe_sfp_type_srlr_core0;
          else if (sfp_type == ixgbe_sfp_type_da_act_lmt_core1 ||
!                  sfp_type == ixgbe_sfp_type_1g_cu_core1 ||
!                  sfp_type == ixgbe_sfp_type_1g_sx_core1)
                  sfp_type = ixgbe_sfp_type_srlr_core1;
  
          /* Read offset to PHY init contents */
          hw->eeprom.ops.read(hw, IXGBE_PHY_INIT_OFFSET_NL, list_offset);
  
*** 1300,1329 ****
   *  @hw: pointer to hardware structure
   *  @byte_offset: byte offset to read
   *  @data: value read
   *
   *  Performs byte read operation to SFP module's EEPROM over I2C interface at
!  *  a specified deivce address.
   **/
  s32 ixgbe_read_i2c_byte_generic(struct ixgbe_hw *hw, u8 byte_offset,
                                  u8 dev_addr, u8 *data)
  {
          s32 status = IXGBE_SUCCESS;
          u32 max_retry = 10;
          u32 retry = 0;
          u16 swfw_mask = 0;
          bool nack = 1;
  
          DEBUGFUNC("ixgbe_read_i2c_byte_generic");
  
          if (IXGBE_READ_REG(hw, IXGBE_STATUS) & IXGBE_STATUS_LAN_ID_1)
                  swfw_mask = IXGBE_GSSR_PHY1_SM;
          else
                  swfw_mask = IXGBE_GSSR_PHY0_SM;
  
          do {
!                 if (ixgbe_acquire_swfw_sync(hw, swfw_mask) != IXGBE_SUCCESS) {
                          status = IXGBE_ERR_SWFW_SYNC;
                          goto read_byte_out;
                  }
  
                  ixgbe_i2c_start(hw);
--- 1355,1386 ----
   *  @hw: pointer to hardware structure
   *  @byte_offset: byte offset to read
   *  @data: value read
   *
   *  Performs byte read operation to SFP module's EEPROM over I2C interface at
!  *  a specified device address.
   **/
  s32 ixgbe_read_i2c_byte_generic(struct ixgbe_hw *hw, u8 byte_offset,
                                  u8 dev_addr, u8 *data)
  {
          s32 status = IXGBE_SUCCESS;
          u32 max_retry = 10;
          u32 retry = 0;
          u16 swfw_mask = 0;
          bool nack = 1;
+         *data = 0;
  
          DEBUGFUNC("ixgbe_read_i2c_byte_generic");
  
          if (IXGBE_READ_REG(hw, IXGBE_STATUS) & IXGBE_STATUS_LAN_ID_1)
                  swfw_mask = IXGBE_GSSR_PHY1_SM;
          else
                  swfw_mask = IXGBE_GSSR_PHY0_SM;
  
          do {
!                 if (hw->mac.ops.acquire_swfw_sync(hw, swfw_mask)
!                     != IXGBE_SUCCESS) {
                          status = IXGBE_ERR_SWFW_SYNC;
                          goto read_byte_out;
                  }
  
                  ixgbe_i2c_start(hw);
*** 1366,1376 ****
  
                  ixgbe_i2c_stop(hw);
                  break;
  
  fail:
!                 ixgbe_release_swfw_sync(hw, swfw_mask);
                  msec_delay(100);
                  ixgbe_i2c_bus_clear(hw);
                  retry++;
                  if (retry < max_retry)
                          DEBUGOUT("I2C byte read error - Retrying.\n");
--- 1423,1433 ----
  
                  ixgbe_i2c_stop(hw);
                  break;
  
  fail:
!                 hw->mac.ops.release_swfw_sync(hw, swfw_mask);
                  msec_delay(100);
                  ixgbe_i2c_bus_clear(hw);
                  retry++;
                  if (retry < max_retry)
                          DEBUGOUT("I2C byte read error - Retrying.\n");
*** 1377,1387 ****
                  else
                          DEBUGOUT("I2C byte read error.\n");
  
          } while (retry < max_retry);
  
!         ixgbe_release_swfw_sync(hw, swfw_mask);
  
  read_byte_out:
          return status;
  }
  
--- 1434,1444 ----
                  else
                          DEBUGOUT("I2C byte read error.\n");
  
          } while (retry < max_retry);
  
!         hw->mac.ops.release_swfw_sync(hw, swfw_mask);
  
  read_byte_out:
          return status;
  }
  
*** 1407,1417 ****
          if (IXGBE_READ_REG(hw, IXGBE_STATUS) & IXGBE_STATUS_LAN_ID_1)
                  swfw_mask = IXGBE_GSSR_PHY1_SM;
          else
                  swfw_mask = IXGBE_GSSR_PHY0_SM;
  
!         if (ixgbe_acquire_swfw_sync(hw, swfw_mask) != IXGBE_SUCCESS) {
                  status = IXGBE_ERR_SWFW_SYNC;
                  goto write_byte_out;
          }
  
          do {
--- 1464,1474 ----
          if (IXGBE_READ_REG(hw, IXGBE_STATUS) & IXGBE_STATUS_LAN_ID_1)
                  swfw_mask = IXGBE_GSSR_PHY1_SM;
          else
                  swfw_mask = IXGBE_GSSR_PHY0_SM;
  
!         if (hw->mac.ops.acquire_swfw_sync(hw, swfw_mask) != IXGBE_SUCCESS) {
                  status = IXGBE_ERR_SWFW_SYNC;
                  goto write_byte_out;
          }
  
          do {
*** 1451,1461 ****
                          DEBUGOUT("I2C byte write error - Retrying.\n");
                  else
                          DEBUGOUT("I2C byte write error.\n");
          } while (retry < max_retry);
  
!         ixgbe_release_swfw_sync(hw, swfw_mask);
  
  write_byte_out:
          return status;
  }
  
--- 1508,1518 ----
                          DEBUGOUT("I2C byte write error - Retrying.\n");
                  else
                          DEBUGOUT("I2C byte write error.\n");
          } while (retry < max_retry);
  
!         hw->mac.ops.release_swfw_sync(hw, swfw_mask);
  
  write_byte_out:
          return status;
  }
  
*** 1470,1486 ****
          u32 i2cctl = IXGBE_READ_REG(hw, IXGBE_I2CCTL);
  
          DEBUGFUNC("ixgbe_i2c_start");
  
          /* Start condition must begin with data and clock high */
!         (void) ixgbe_set_i2c_data(hw, &i2cctl, 1);
!         (void) ixgbe_raise_i2c_clk(hw, &i2cctl);
  
          /* Setup time for start condition (4.7us) */
          usec_delay(IXGBE_I2C_T_SU_STA);
  
!         (void) ixgbe_set_i2c_data(hw, &i2cctl, 0);
  
          /* Hold time for start condition (4us) */
          usec_delay(IXGBE_I2C_T_HD_STA);
  
          ixgbe_lower_i2c_clk(hw, &i2cctl);
--- 1527,1543 ----
          u32 i2cctl = IXGBE_READ_REG(hw, IXGBE_I2CCTL);
  
          DEBUGFUNC("ixgbe_i2c_start");
  
          /* Start condition must begin with data and clock high */
!         ixgbe_set_i2c_data(hw, &i2cctl, 1);
!         ixgbe_raise_i2c_clk(hw, &i2cctl);
  
          /* Setup time for start condition (4.7us) */
          usec_delay(IXGBE_I2C_T_SU_STA);
  
!         ixgbe_set_i2c_data(hw, &i2cctl, 0);
  
          /* Hold time for start condition (4us) */
          usec_delay(IXGBE_I2C_T_HD_STA);
  
          ixgbe_lower_i2c_clk(hw, &i2cctl);
*** 1501,1517 ****
          u32 i2cctl = IXGBE_READ_REG(hw, IXGBE_I2CCTL);
  
          DEBUGFUNC("ixgbe_i2c_stop");
  
          /* Stop condition must begin with data low and clock high */
!         (void) ixgbe_set_i2c_data(hw, &i2cctl, 0);
!         (void) ixgbe_raise_i2c_clk(hw, &i2cctl);
  
          /* Setup time for stop condition (4us) */
          usec_delay(IXGBE_I2C_T_SU_STO);
  
!         (void) ixgbe_set_i2c_data(hw, &i2cctl, 1);
  
          /* bus free time between stop and start (4.7us)*/
          usec_delay(IXGBE_I2C_T_BUF);
  }
  
--- 1558,1574 ----
          u32 i2cctl = IXGBE_READ_REG(hw, IXGBE_I2CCTL);
  
          DEBUGFUNC("ixgbe_i2c_stop");
  
          /* Stop condition must begin with data low and clock high */
!         ixgbe_set_i2c_data(hw, &i2cctl, 0);
!         ixgbe_raise_i2c_clk(hw, &i2cctl);
  
          /* Setup time for stop condition (4us) */
          usec_delay(IXGBE_I2C_T_SU_STO);
  
!         ixgbe_set_i2c_data(hw, &i2cctl, 1);
  
          /* bus free time between stop and start (4.7us)*/
          usec_delay(IXGBE_I2C_T_BUF);
  }
  
*** 1522,1546 ****
   *
   *  Clocks in one byte data via I2C data/clock
   **/
  static s32 ixgbe_clock_in_i2c_byte(struct ixgbe_hw *hw, u8 *data)
  {
-         s32 status = IXGBE_SUCCESS;
          s32 i;
          bool bit = 0;
  
          DEBUGFUNC("ixgbe_clock_in_i2c_byte");
  
          for (i = 7; i >= 0; i--) {
!                 status = ixgbe_clock_in_i2c_bit(hw, &bit);
                  *data |= bit << i;
- 
-                 if (status != IXGBE_SUCCESS)
-                         break;
          }
  
!         return status;
  }
  
  /**
   *  ixgbe_clock_out_i2c_byte - Clocks out one byte via I2C
   *  @hw: pointer to hardware structure
--- 1579,1599 ----
   *
   *  Clocks in one byte data via I2C data/clock
   **/
  static s32 ixgbe_clock_in_i2c_byte(struct ixgbe_hw *hw, u8 *data)
  {
          s32 i;
          bool bit = 0;
  
          DEBUGFUNC("ixgbe_clock_in_i2c_byte");
  
          for (i = 7; i >= 0; i--) {
!                 ixgbe_clock_in_i2c_bit(hw, &bit);
                  *data |= bit << i;
          }
  
!         return IXGBE_SUCCESS;
  }
  
  /**
   *  ixgbe_clock_out_i2c_byte - Clocks out one byte via I2C
   *  @hw: pointer to hardware structure
*** 1567,1576 ****
--- 1620,1630 ----
  
          /* Release SDA line (set high) */
          i2cctl = IXGBE_READ_REG(hw, IXGBE_I2CCTL);
          i2cctl |= IXGBE_I2C_DATA_OUT;
          IXGBE_WRITE_REG(hw, IXGBE_I2CCTL, i2cctl);
+         IXGBE_WRITE_FLUSH(hw);
  
          return status;
  }
  
  /**
*** 1579,1600 ****
   *
   *  Clocks in/out one bit via I2C data/clock
   **/
  static s32 ixgbe_get_i2c_ack(struct ixgbe_hw *hw)
  {
!         s32 status;
          u32 i = 0;
          u32 i2cctl = IXGBE_READ_REG(hw, IXGBE_I2CCTL);
          u32 timeout = 10;
          bool ack = 1;
  
          DEBUGFUNC("ixgbe_get_i2c_ack");
  
!         status = ixgbe_raise_i2c_clk(hw, &i2cctl);
  
-         if (status != IXGBE_SUCCESS)
-                 goto out;
  
          /* Minimum high period of clock is 4us */
          usec_delay(IXGBE_I2C_T_HIGH);
  
          /* Poll for ACK.  Note that ACK in I2C spec is
--- 1633,1652 ----
   *
   *  Clocks in/out one bit via I2C data/clock
   **/
  static s32 ixgbe_get_i2c_ack(struct ixgbe_hw *hw)
  {
!         s32 status = IXGBE_SUCCESS;
          u32 i = 0;
          u32 i2cctl = IXGBE_READ_REG(hw, IXGBE_I2CCTL);
          u32 timeout = 10;
          bool ack = 1;
  
          DEBUGFUNC("ixgbe_get_i2c_ack");
  
!         ixgbe_raise_i2c_clk(hw, &i2cctl);
  
  
          /* Minimum high period of clock is 4us */
          usec_delay(IXGBE_I2C_T_HIGH);
  
          /* Poll for ACK.  Note that ACK in I2C spec is
*** 1616,1626 ****
          ixgbe_lower_i2c_clk(hw, &i2cctl);
  
          /* Minimum low period of clock is 4.7 us */
          usec_delay(IXGBE_I2C_T_LOW);
  
- out:
          return status;
  }
  
  /**
   *  ixgbe_clock_in_i2c_bit - Clocks in one bit via I2C data/clock
--- 1668,1677 ----
*** 1629,1644 ****
   *
   *  Clocks in one bit via I2C data/clock
   **/
  static s32 ixgbe_clock_in_i2c_bit(struct ixgbe_hw *hw, bool *data)
  {
-         s32 status;
          u32 i2cctl = IXGBE_READ_REG(hw, IXGBE_I2CCTL);
  
          DEBUGFUNC("ixgbe_clock_in_i2c_bit");
  
!         status = ixgbe_raise_i2c_clk(hw, &i2cctl);
  
          /* Minimum high period of clock is 4us */
          usec_delay(IXGBE_I2C_T_HIGH);
  
          i2cctl = IXGBE_READ_REG(hw, IXGBE_I2CCTL);
--- 1680,1694 ----
   *
   *  Clocks in one bit via I2C data/clock
   **/
  static s32 ixgbe_clock_in_i2c_bit(struct ixgbe_hw *hw, bool *data)
  {
          u32 i2cctl = IXGBE_READ_REG(hw, IXGBE_I2CCTL);
  
          DEBUGFUNC("ixgbe_clock_in_i2c_bit");
  
!         ixgbe_raise_i2c_clk(hw, &i2cctl);
  
          /* Minimum high period of clock is 4us */
          usec_delay(IXGBE_I2C_T_HIGH);
  
          i2cctl = IXGBE_READ_REG(hw, IXGBE_I2CCTL);
*** 1647,1657 ****
          ixgbe_lower_i2c_clk(hw, &i2cctl);
  
          /* Minimum low period of clock is 4.7 us */
          usec_delay(IXGBE_I2C_T_LOW);
  
!         return status;
  }
  
  /**
   *  ixgbe_clock_out_i2c_bit - Clocks in/out one bit via I2C data/clock
   *  @hw: pointer to hardware structure
--- 1697,1707 ----
          ixgbe_lower_i2c_clk(hw, &i2cctl);
  
          /* Minimum low period of clock is 4.7 us */
          usec_delay(IXGBE_I2C_T_LOW);
  
!         return IXGBE_SUCCESS;
  }
  
  /**
   *  ixgbe_clock_out_i2c_bit - Clocks in/out one bit via I2C data/clock
   *  @hw: pointer to hardware structure
*** 1666,1676 ****
  
          DEBUGFUNC("ixgbe_clock_out_i2c_bit");
  
          status = ixgbe_set_i2c_data(hw, &i2cctl, data);
          if (status == IXGBE_SUCCESS) {
!                 status = ixgbe_raise_i2c_clk(hw, &i2cctl);
  
                  /* Minimum high period of clock is 4us */
                  usec_delay(IXGBE_I2C_T_HIGH);
  
                  ixgbe_lower_i2c_clk(hw, &i2cctl);
--- 1716,1726 ----
  
          DEBUGFUNC("ixgbe_clock_out_i2c_bit");
  
          status = ixgbe_set_i2c_data(hw, &i2cctl, data);
          if (status == IXGBE_SUCCESS) {
!                 ixgbe_raise_i2c_clk(hw, &i2cctl);
  
                  /* Minimum high period of clock is 4us */
                  usec_delay(IXGBE_I2C_T_HIGH);
  
                  ixgbe_lower_i2c_clk(hw, &i2cctl);
*** 1691,1714 ****
   *  @hw: pointer to hardware structure
   *  @i2cctl: Current value of I2CCTL register
   *
   *  Raises the I2C clock line '0'->'1'
   **/
! static s32 ixgbe_raise_i2c_clk(struct ixgbe_hw *hw, u32 *i2cctl)
  {
!         s32 status = IXGBE_SUCCESS;
  
          DEBUGFUNC("ixgbe_raise_i2c_clk");
  
          *i2cctl |= IXGBE_I2C_CLK_OUT;
  
          IXGBE_WRITE_REG(hw, IXGBE_I2CCTL, *i2cctl);
! 
          /* SCL rise time (1000ns) */
          usec_delay(IXGBE_I2C_T_RISE);
  
!         return status;
  }
  
  /**
   *  ixgbe_lower_i2c_clk - Lowers the I2C SCL clock
   *  @hw: pointer to hardware structure
--- 1741,1770 ----
   *  @hw: pointer to hardware structure
   *  @i2cctl: Current value of I2CCTL register
   *
   *  Raises the I2C clock line '0'->'1'
   **/
! static void ixgbe_raise_i2c_clk(struct ixgbe_hw *hw, u32 *i2cctl)
  {
!         u32 i = 0;
!         u32 timeout = IXGBE_I2C_CLOCK_STRETCHING_TIMEOUT;
!         u32 i2cctl_r = 0;
  
          DEBUGFUNC("ixgbe_raise_i2c_clk");
  
+         for (i = 0; i < timeout; i++) {
                  *i2cctl |= IXGBE_I2C_CLK_OUT;
  
                  IXGBE_WRITE_REG(hw, IXGBE_I2CCTL, *i2cctl);
!                 IXGBE_WRITE_FLUSH(hw);
                  /* SCL rise time (1000ns) */
                  usec_delay(IXGBE_I2C_T_RISE);
  
!                 i2cctl_r = IXGBE_READ_REG(hw, IXGBE_I2CCTL);
!                 if (i2cctl_r & IXGBE_I2C_CLK_IN)
!                         break;
!         }
  }
  
  /**
   *  ixgbe_lower_i2c_clk - Lowers the I2C SCL clock
   *  @hw: pointer to hardware structure
*** 1722,1731 ****
--- 1778,1788 ----
          DEBUGFUNC("ixgbe_lower_i2c_clk");
  
          *i2cctl &= ~IXGBE_I2C_CLK_OUT;
  
          IXGBE_WRITE_REG(hw, IXGBE_I2CCTL, *i2cctl);
+         IXGBE_WRITE_FLUSH(hw);
  
          /* SCL fall time (300ns) */
          usec_delay(IXGBE_I2C_T_FALL);
  }
  
*** 1747,1756 ****
--- 1804,1814 ----
                  *i2cctl |= IXGBE_I2C_DATA_OUT;
          else
                  *i2cctl &= ~IXGBE_I2C_DATA_OUT;
  
          IXGBE_WRITE_REG(hw, IXGBE_I2CCTL, *i2cctl);
+         IXGBE_WRITE_FLUSH(hw);
  
          /* Data rise/fall (1000ns/300ns) and set-up time (250ns) */
          usec_delay(IXGBE_I2C_T_RISE + IXGBE_I2C_T_FALL + IXGBE_I2C_T_SU_DATA);
  
          /* Verify data was set correctly */
*** 1798,1811 ****
  
          DEBUGFUNC("ixgbe_i2c_bus_clear");
  
          ixgbe_i2c_start(hw);
  
!         (void) ixgbe_set_i2c_data(hw, &i2cctl, 1);
  
          for (i = 0; i < 9; i++) {
!                 (void) ixgbe_raise_i2c_clk(hw, &i2cctl);
  
                  /* Min high period of clock is 4us */
                  usec_delay(IXGBE_I2C_T_HIGH);
  
                  ixgbe_lower_i2c_clk(hw, &i2cctl);
--- 1856,1869 ----
  
          DEBUGFUNC("ixgbe_i2c_bus_clear");
  
          ixgbe_i2c_start(hw);
  
!         ixgbe_set_i2c_data(hw, &i2cctl, 1);
  
          for (i = 0; i < 9; i++) {
!                 ixgbe_raise_i2c_clk(hw, &i2cctl);
  
                  /* Min high period of clock is 4us */
                  usec_delay(IXGBE_I2C_T_HIGH);
  
                  ixgbe_lower_i2c_clk(hw, &i2cctl);
*** 1819,1829 ****
          /* Put the i2c bus back to default state */
          ixgbe_i2c_stop(hw);
  }
  
  /**
!  *  ixgbe_tn_check_overtemp - Checks if an overtemp occured.
   *  @hw: pointer to hardware structure
   *
   *  Checks if the LASI temp alarm status was triggered due to overtemp
   **/
  s32 ixgbe_tn_check_overtemp(struct ixgbe_hw *hw)
--- 1877,1887 ----
          /* Put the i2c bus back to default state */
          ixgbe_i2c_stop(hw);
  }
  
  /**
!  *  ixgbe_tn_check_overtemp - Checks if an overtemp occurred.
   *  @hw: pointer to hardware structure
   *
   *  Checks if the LASI temp alarm status was triggered due to overtemp
   **/
  s32 ixgbe_tn_check_overtemp(struct ixgbe_hw *hw)