Print this page
Code review comments

*** 549,559 **** } /* * mrsas_alloc_cmd_pool_tbolt * ! * TODO: merge tbolt-specific codee into mrsas_alloc_cmd_pool() to have single * routine */ int mrsas_alloc_cmd_pool_tbolt(struct mrsas_instance *instance) { --- 549,559 ---- } /* * mrsas_alloc_cmd_pool_tbolt * ! * TODO: merge tbolt-specific code into mrsas_alloc_cmd_pool() to have single * routine */ int mrsas_alloc_cmd_pool_tbolt(struct mrsas_instance *instance) {
*** 2797,2808 **** mutex_exit(&instance->cmd_pend_mtx); tbolt_complete_cmd(instance, cmd); } ! /* set it back to all 0xfffffffff. */ ! desc->Words = (uint64_t)~0; instance->reply_read_index++; if (instance->reply_read_index >= (instance->reply_q_depth)) { con_log(CL_ANN1, (CE_NOTE, "wrap around")); --- 2797,2808 ---- mutex_exit(&instance->cmd_pend_mtx); tbolt_complete_cmd(instance, cmd); } ! /* set it back to all 1s. */ ! desc->Words = -1LL; instance->reply_read_index++; if (instance->reply_read_index >= (instance->reply_q_depth)) { con_log(CL_ANN1, (CE_NOTE, "wrap around"));