Print this page
Code review comments

Split Close
Expand all
Collapse all
          --- old/usr/src/uts/common/io/mr_sas/mr_sas.h
          +++ new/usr/src/uts/common/io/mr_sas/mr_sas.h
↓ open down ↓ 551 lines elided ↑ open up ↑
 552  552                  uint8_t mutexs;         /* Mutex's allocated. */
 553  553                  uint8_t taskq;          /* Task q's created. */
 554  554                  uint8_t tran;           /* Tran struct allocated */
 555  555                  uint8_t tranSetup;      /* Tran attached to the ddi. */
 556  556                  uint8_t devctl;         /* Device nodes for cfgadm created. */
 557  557                  uint8_t scsictl;        /* Device nodes for cfgadm created. */
 558  558                  uint8_t ioctl;          /* Device nodes for ioctl's created. */
 559  559                  uint8_t timer;          /* Timer started. */
 560  560                  uint8_t aenPend;        /* AEN cmd pending f/w. */
 561  561                  uint8_t mapUpdate_pend; /* LD MAP update cmd pending f/w. */
 562      -                uint8_t soft_isr;
 563      -                uint8_t ldlist_buff;
 564      -                uint8_t pdlist_buff;
 565      -                uint8_t syncCmd;
 566      -                uint8_t verBuff;
 567      -                uint8_t alloc_space_mfi;
 568      -                uint8_t alloc_space_mpi2;
      562 +                uint8_t soft_isr;       /* Soft interrupt handler allocated. */
      563 +                uint8_t ldlist_buff;    /* Logical disk list allocated. */
      564 +                uint8_t pdlist_buff;    /* Physical disk list allocated. */
      565 +                uint8_t syncCmd;        /* Sync map command allocated. */
      566 +                uint8_t verBuff;        /* 2108 MFI buffer allocated. */
      567 +                uint8_t alloc_space_mfi;  /* Allocated space for 2108 MFI. */
      568 +                uint8_t alloc_space_mpi2; /* Allocated space for 2208 MPI2. */
 569  569          } unroll;
 570  570  
 571  571  
 572  572          /* function template pointer */
 573  573          struct mrsas_function_template *func_ptr;
 574  574  
 575  575  
 576  576          /* MSI interrupts specific */
 577  577          ddi_intr_handle_t *intr_htable;         /* Interrupt handle array */
 578  578          size_t          intr_htable_size;       /* Int. handle array size */
↓ open down ↓ 77 lines elided ↑ open up ↑
 656  656   *
 657  657   * con_log displays the error messages on the console based on the current
 658  658   * debug level. Also it attaches the appropriate kernel severity level with
 659  659   * the message.
 660  660   *
 661  661   *
 662  662   * console messages debug levels
 663  663   */
 664  664  #define CL_NONE         0       /* No debug information */
 665  665  #define CL_ANN          1       /* print unconditionally, announcements */
 666      -#define CL_ANN1         2       /* No o/p  */
      666 +#define CL_ANN1         2       /* No-op  */
 667  667  #define CL_DLEVEL1      3       /* debug level 1, informative */
 668  668  #define CL_DLEVEL2      4       /* debug level 2, verbose */
 669  669  #define CL_DLEVEL3      5       /* debug level 3, very verbose */
 670  670  
 671  671  #ifdef __SUNPRO_C
 672  672  #define __func__ ""
 673  673  #endif
 674  674  
 675  675  #define con_log(level, fmt) { if (debug_level_g >= level) cmn_err fmt; }
 676  676  
↓ open down ↓ 1269 lines elided ↑ open up ↑
1946 1946          uint32_t        seq_num;
1947 1947          uint32_t        class_locale_word;
1948 1948  };
1949 1949  
1950 1950  #pragma pack()
1951 1951  
1952 1952  #ifndef DDI_VENDOR_LSI
1953 1953  #define DDI_VENDOR_LSI          "LSI"
1954 1954  #endif /* DDI_VENDOR_LSI */
1955 1955  
1956      -int     mrsas_config_scsi_device(struct mrsas_instance *,
1957      -                    struct scsi_device *, dev_info_t **);
     1956 +int mrsas_config_scsi_device(struct mrsas_instance *,
     1957 +    struct scsi_device *, dev_info_t **);
1958 1958  
1959 1959  #ifdef PDSUPPORT
1960      -int     mrsas_tbolt_config_pd(struct mrsas_instance *, uint16_t,
1961      -                        uint8_t, dev_info_t **);
     1960 +int mrsas_tbolt_config_pd(struct mrsas_instance *, uint16_t,
     1961 +    uint8_t, dev_info_t **);
1962 1962  #endif
1963 1963  
1964      -dev_info_t *mrsas_find_child(struct mrsas_instance *, uint16_t,
1965      -                        uint8_t);
1966      -int     mrsas_service_evt(struct mrsas_instance *, int, int, int,
1967      -                        uint64_t);
     1964 +dev_info_t *mrsas_find_child(struct mrsas_instance *, uint16_t, uint8_t);
     1965 +int mrsas_service_evt(struct mrsas_instance *, int, int, int, uint64_t);
1968 1966  void return_raid_msg_pkt(struct mrsas_instance *, struct mrsas_cmd *);
1969 1967  struct mrsas_cmd *get_raid_msg_mfi_pkt(struct mrsas_instance *);
1970 1968  void return_raid_msg_mfi_pkt(struct mrsas_instance *, struct mrsas_cmd *);
1971 1969  
1972 1970  int     alloc_space_for_mpi2(struct mrsas_instance *);
1973 1971  void    fill_up_drv_ver(struct mrsas_drv_ver *dv);
1974 1972  
1975 1973  int     mrsas_issue_init_mpi2(struct mrsas_instance *);
1976 1974  struct scsi_pkt *mrsas_tbolt_tran_init_pkt(struct scsi_address *, register
1977 1975                      struct scsi_pkt *, struct buf *, int, int, int, int,
↓ open down ↓ 83 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX