Print this page
Code review comments
@@ -557,17 +557,17 @@
uint8_t scsictl; /* Device nodes for cfgadm created. */
uint8_t ioctl; /* Device nodes for ioctl's created. */
uint8_t timer; /* Timer started. */
uint8_t aenPend; /* AEN cmd pending f/w. */
uint8_t mapUpdate_pend; /* LD MAP update cmd pending f/w. */
- uint8_t soft_isr;
- uint8_t ldlist_buff;
- uint8_t pdlist_buff;
- uint8_t syncCmd;
- uint8_t verBuff;
- uint8_t alloc_space_mfi;
- uint8_t alloc_space_mpi2;
+ uint8_t soft_isr; /* Soft interrupt handler allocated. */
+ uint8_t ldlist_buff; /* Logical disk list allocated. */
+ uint8_t pdlist_buff; /* Physical disk list allocated. */
+ uint8_t syncCmd; /* Sync map command allocated. */
+ uint8_t verBuff; /* 2108 MFI buffer allocated. */
+ uint8_t alloc_space_mfi; /* Allocated space for 2108 MFI. */
+ uint8_t alloc_space_mpi2; /* Allocated space for 2208 MPI2. */
} unroll;
/* function template pointer */
struct mrsas_function_template *func_ptr;
@@ -661,11 +661,11 @@
*
* console messages debug levels
*/
#define CL_NONE 0 /* No debug information */
#define CL_ANN 1 /* print unconditionally, announcements */
-#define CL_ANN1 2 /* No o/p */
+#define CL_ANN1 2 /* No-op */
#define CL_DLEVEL1 3 /* debug level 1, informative */
#define CL_DLEVEL2 4 /* debug level 2, verbose */
#define CL_DLEVEL3 5 /* debug level 3, very verbose */
#ifdef __SUNPRO_C
@@ -1959,14 +1959,12 @@
#ifdef PDSUPPORT
int mrsas_tbolt_config_pd(struct mrsas_instance *, uint16_t,
uint8_t, dev_info_t **);
#endif
-dev_info_t *mrsas_find_child(struct mrsas_instance *, uint16_t,
- uint8_t);
-int mrsas_service_evt(struct mrsas_instance *, int, int, int,
- uint64_t);
+dev_info_t *mrsas_find_child(struct mrsas_instance *, uint16_t, uint8_t);
+int mrsas_service_evt(struct mrsas_instance *, int, int, int, uint64_t);
void return_raid_msg_pkt(struct mrsas_instance *, struct mrsas_cmd *);
struct mrsas_cmd *get_raid_msg_mfi_pkt(struct mrsas_instance *);
void return_raid_msg_mfi_pkt(struct mrsas_instance *, struct mrsas_cmd *);
int alloc_space_for_mpi2(struct mrsas_instance *);