Code Review for sasl-login

Prepared by:Dan McDonald <danmcd@nexenta.com> on 2011-Feb-23 21:24 -0500 EST
Workspace:/export/home/danmcd/ws/sasl-login (at 484971665501)
Compare against: /export/home/danmcd/ws/illumos-clone (at fe7962c08d1d)
Summary of changes: 780 lines changed: 775 ins; 4 del; 1 mod; 318 unchg
Patch of changes: sasl-login.patch
Printable review: sasl-login.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libsasl/Makefile

750 Add the LOGIN authenticator to libsasl
Reviewed by: Albert Lee <trisk@opensolaris.org>
Reviewed by: Roland Mainz <roland.mainz@nrubsig.org>
4 lines changed: 2 ins; 2 del; 0 mod; 166 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/sasl_plugins/Makefile

750 Add the LOGIN authenticator to libsasl
Reviewed by: Albert Lee <trisk@opensolaris.org>
Reviewed by: Roland Mainz <roland.mainz@nrubsig.org>
4 lines changed: 1 ins; 2 del; 1 mod; 98 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/sasl_plugins/login/Makefile

750 Add the LOGIN authenticator to libsasl
Reviewed by: Albert Lee <trisk@opensolaris.org>
Reviewed by: Roland Mainz <roland.mainz@nrubsig.org>
26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/sasl_plugins/login/Makefile.com

750 Add the LOGIN authenticator to libsasl
Reviewed by: Albert Lee <trisk@opensolaris.org>
Reviewed by: Roland Mainz <roland.mainz@nrubsig.org>
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/sasl_plugins/login/amd64/Makefile

750 Add the LOGIN authenticator to libsasl
Reviewed by: Albert Lee <trisk@opensolaris.org>
Reviewed by: Roland Mainz <roland.mainz@nrubsig.org>
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/sasl_plugins/login/i386/Makefile

750 Add the LOGIN authenticator to libsasl
Reviewed by: Albert Lee <trisk@opensolaris.org>
Reviewed by: Roland Mainz <roland.mainz@nrubsig.org>
28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/sasl_plugins/login/login.c

750 Add the LOGIN authenticator to libsasl
Reviewed by: Albert Lee <trisk@opensolaris.org>
Reviewed by: Roland Mainz <roland.mainz@nrubsig.org>
554 lines changed: 554 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/sasl_plugins/login/login_init.c

750 Add the LOGIN authenticator to libsasl
Reviewed by: Albert Lee <trisk@opensolaris.org>
Reviewed by: Roland Mainz <roland.mainz@nrubsig.org>
43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/sasl_plugins/login/sparc/Makefile

750 Add the LOGIN authenticator to libsasl
Reviewed by: Albert Lee <trisk@opensolaris.org>
Reviewed by: Roland Mainz <roland.mainz@nrubsig.org>
28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/sasl_plugins/login/sparcv9/Makefile

750 Add the LOGIN authenticator to libsasl
Reviewed by: Albert Lee <trisk@opensolaris.org>
Reviewed by: Roland Mainz <roland.mainz@nrubsig.org>
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-library-security-libsasl.mf

750 Add the LOGIN authenticator to libsasl
Reviewed by: Albert Lee <trisk@opensolaris.org>
Reviewed by: Roland Mainz <roland.mainz@nrubsig.org>
3 lines changed: 3 ins; 0 del; 0 mod; 54 unchg

This code review page was prepared using /export/home/danmcd/ws/sasl-login/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.