Code Review for omnios-build

Prepared by:Dan McDonald (danmcd) on 2016-Feb-10 16:25 -0500 EST
Workspace:/data/danmcd/ws/omnios-build (at 9bdcec5532b5)
Compare against: origin/master (http://github.com/omniti-labs/omnios-build at 8063f0aa5a8a)
Summary of changes: 5783 lines changed: 5613 ins; 93 del; 77 mod; 11993 unchg
Patch of changes: omnios-build.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw build/openssh/build.sh

Now (mostly?) pkglint clean and using more SunSSH-like method and SMF manifest.
First stab at the full Joyent wad (still needs work!!!)
25 lines changed: 8 ins; 4 del; 13 mod; 82 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw build/openssh/client.mog

Now (mostly?) pkglint clean and using more SunSSH-like method and SMF manifest.
6 lines changed: 6 ins; 0 del; 0 mod; 10 unchg

------ ------ ------ ------ ------ Old --- Patch --- build/openssh/method-sshd (deleted)

Now (mostly?) pkglint clean and using more SunSSH-like method and SMF manifest.
21 lines changed: 0 ins; 21 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/0001-upstream-commit.patch

First stab at the full Joyent wad (still needs work!!!)
36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/0002-Support-Illumos-Solaris-fine-grained-privileges.patch

First stab at the full Joyent wad (still needs work!!!)
588 lines changed: 588 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/0003-Skip-config-check.patch

First stab at the full Joyent wad (still needs work!!!)
41 lines changed: 41 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw build/openssh/patches/0004-PAM-Support.patch (renamed and modified from build/openssh/patches/0002-PAM-Support.patch)

First stab at the full Joyent wad (still needs work!!!)
3 lines changed: 0 ins; 0 del; 3 mod; 51 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw build/openssh/patches/0005-lastlogin.patch (renamed and modified from build/openssh/patches/0003-lastlogin.patch)

First stab at the full Joyent wad (still needs work!!!)
3 lines changed: 0 ins; 0 del; 3 mod; 66 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw build/openssh/patches/0006-Reorganise-man-pages-into-Illumos-numbering-adjust-t.patch (renamed and modified from build/openssh/patches/0004-Reorganise-man-pages-into-Illumos-numbering-adjust-t.patch)

First stab at the full Joyent wad (still needs work!!!)
37 lines changed: 25 ins; 0 del; 12 mod; 9893 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/0007-Deprecated-SunSSH-options.patch

First stab at the full Joyent wad (still needs work!!!)
49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/0008-GSS-store-creds-for-Solaris.patch

First stab at the full Joyent wad (still needs work!!!)
178 lines changed: 178 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/0009-DTrace-support-for-SFTP.patch

First stab at the full Joyent wad (still needs work!!!)
380 lines changed: 380 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/0010-Add-DisableBanner-option.patch

First stab at the full Joyent wad (still needs work!!!)
182 lines changed: 182 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw build/openssh/patches/0011-PAM-conversation-fix.patch (renamed and modified from build/openssh/patches/0009-PAM-conversation-fix.patch)

First stab at the full Joyent wad (still needs work!!!)
3 lines changed: 0 ins; 0 del; 3 mod; 101 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw build/openssh/patches/0012-PAM-enhancements-for-Solaris.patch (renamed and modified from build/openssh/patches/0010-PAM-enhancements-for-Solaris.patch)

First stab at the full Joyent wad (still needs work!!!)
6 lines changed: 0 ins; 0 del; 6 mod; 670 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/0013-SunSSH-compat-default-config-values.patch

First stab at the full Joyent wad (still needs work!!!)
135 lines changed: 135 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/0014-Deprecate-SunSSH-compatible-server-options.patch

First stab at the full Joyent wad (still needs work!!!)
61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw build/openssh/patches/0015-Solaris-Auditing-support.patch (renamed and modified from build/openssh/patches/0014-Solaris-Auditing-support.patch)

First stab at the full Joyent wad (still needs work!!!)
11 lines changed: 0 ins; 0 del; 11 mod; 737 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/0016-GSS-API-key-exchange-support.patch

First stab at the full Joyent wad (still needs work!!!)
1941 lines changed: 1941 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw build/openssh/patches/0017-Enable-login-to-a-role-if-PAM-is-ok-with-it.patch (renamed and modified from build/openssh/patches/0016-Enable-login-to-a-role-if-PAM-is-ok-with-it.patch)

First stab at the full Joyent wad (still needs work!!!)
3 lines changed: 0 ins; 0 del; 3 mod; 159 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw build/openssh/patches/0018-PAM-setcred-failures.patch (renamed and modified from build/openssh/patches/0017-PAM-setcred-failures.patch)

First stab at the full Joyent wad (still needs work!!!)
3 lines changed: 0 ins; 0 del; 3 mod; 62 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/0019-Don-t-call-do_pam_setcred-twice.patch

First stab at the full Joyent wad (still needs work!!!)
47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/0020-Per-session-xauthfile.patch

First stab at the full Joyent wad (still needs work!!!)
230 lines changed: 230 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/0021-PubKeyPlugin-support.patch

First stab at the full Joyent wad (still needs work!!!)
259 lines changed: 259 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/0022-Compatibility-fix-for-ListenAddress.patch

First stab at the full Joyent wad (still needs work!!!)
43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/0023-Hack-around-umac_ctx-name-punning.patch

First stab at the full Joyent wad (still needs work!!!)
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/0024-Try-to-create-privsep-chroot-dir-if-it-doesn-t-exist.patch

First stab at the full Joyent wad (still needs work!!!)
51 lines changed: 51 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/0025-Add-SMF-manifest-and-method-and-install-them.patch

First stab at the full Joyent wad (still needs work!!!)
344 lines changed: 344 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/0027-Add-with-key-dir-configure-option-to-place-SSH-host-.patch

First stab at the full Joyent wad (still needs work!!!)
126 lines changed: 126 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/0028-Re-enable-DSA-keys-for-pk-auth.patch

First stab at the full Joyent wad (still needs work!!!)
61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/0029-Don-t-use-krb5-config-to-check-for-GSSAPI-on-Illumos.patch

First stab at the full Joyent wad (still needs work!!!)
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/0030-Set-default-sshd-options-based-on-etc-default-login.patch

First stab at the full Joyent wad (still needs work!!!)
147 lines changed: 147 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/0031-Compatibility-for-SunSSH_1.5-should-include-old-DH-K.patch

First stab at the full Joyent wad (still needs work!!!)
75 lines changed: 75 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw build/openssh/patches/0032-Accept-LANG-and-LC_-environment-variables-from-clien.patch

First stab at the full Joyent wad (still needs work!!!)
10 lines changed: 0 ins; 0 del; 10 mod; 162 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/0033-Temporarily-set-ssh-keygen-and-ssh-add-to-old-FP-for.patch

First stab at the full Joyent wad (still needs work!!!)
146 lines changed: 146 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/0034-Restore-tcpwrappers-libwrap-support.patch

First stab at the full Joyent wad (still needs work!!!)
159 lines changed: 159 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/0035-Let-us-put-a-fallback-copy-of-DH-moduli-in-a-system-.patch

First stab at the full Joyent wad (still needs work!!!)
108 lines changed: 108 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/0036-Default-to-enabling-sandbox-when-built-with-sandbox-.patch

First stab at the full Joyent wad (still needs work!!!)
44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/openssh/patches/1001-dtrace32.patch

First stab at the full Joyent wad (still needs work!!!)
43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw build/openssh/patches/series

First stab at the full Joyent wad (still needs work!!!)
38 lines changed: 28 ins; 0 del; 10 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- build/openssh/ssh.xml (deleted)

Now (mostly?) pkglint clean and using more SunSSH-like method and SMF manifest.
68 lines changed: 0 ins; 68 del; 0 mod; 0 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.