Code Review for io-lx

Prepared by:Dan McDonald (danmcd) on 2016-Aug-31 11:44 -0400 EDT
Workspace:/export/home/danmcd/ws/io-lx (at 2af62b502662)
Compare against: origin/master (/export/home/danmcd/ws/io-lx-public at 8559e18262bb)
Summary of changes: 1295 lines changed: 1137 ins; 99 del; 59 mod; 28316 unchg
Patch of changes: io-lx.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zoneadm/zoneadm.c

OS-200 need a better mechanism for storing persistent zone_did
96 lines changed: 77 ins; 16 del; 3 mod; 5789 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zoneadmd/zcons.c

Merge cleanup from previous six commits
OS-2564 zone boot failed: could not start zoneadmd
96 lines changed: 76 ins; 7 del; 13 mod; 953 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zoneadmd/zoneadmd.c

Merge cleanup from previous six commits
OS-200 need a better mechanism for storing persistent zone_did
OS-2564 zone boot failed: could not start zoneadmd
OS-1763 mount of /etc/svc/volatile failed: Device busy
OS-511 make zonecfg device resource extensible, like the net resource
OS-224 add more zonecfg net properties
148 lines changed: 143 ins; 0 del; 5 mod; 2438 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zoneadmd/zoneadmd.h

OS-2564 zone boot failed: could not start zoneadmd
1 line changed: 1 ins; 0 del; 0 mod; 185 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zonecfg/zonecfg.c

OS-200 need a better mechanism for storing persistent zone_did
OS-511 make zonecfg device resource extensible, like the net resource
OS-224 add more zonecfg net properties
OS-216 store all net config info on zone
352 lines changed: 329 ins; 13 del; 10 mod; 7261 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zonecfg/zonecfg.h

OS-224 add more zonecfg net properties
OS-216 store all net config info on zone
6 lines changed: 5 ins; 0 del; 1 mod; 240 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zonecfg/zonecfg_grammar.y

OS-224 add more zonecfg net properties
OS-216 store all net config info on zone
6 lines changed: 5 ins; 0 del; 1 mod; 1139 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zonecfg/zonecfg_lex.l

OS-224 add more zonecfg net properties
OS-216 store all net config info on zone
21 lines changed: 20 ins; 0 del; 1 mod; 532 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/libzonecfg.h

Merge cleanup from previous six commits
OS-200 need a better mechanism for storing persistent zone_did
OS-511 make zonecfg device resource extensible, like the net resource
OS-224 add more zonecfg net properties
OS-216 store all net config info on zone
31 lines changed: 31 ins; 0 del; 0 mod; 590 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/brand/lx/lx_init/lxinit.c

Re-enable commented-out lxinit code, as a prelude to
enabling zonecfg(1M)-property networking configuration for LX.
90 lines changed: 17 ins; 63 del; 10 mod; 816 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzonecfg/common/libzonecfg.c

OS-200 need a better mechanism for storing persistent zone_did
OS-511 make zonecfg device resource extensible, like the net resource
OS-224 add more zonecfg net properties
OS-216 store all net config info on zone
429 lines changed: 417 ins; 0 del; 12 mod; 7977 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzonecfg/common/mapfile-vers

OS-200 need a better mechanism for storing persistent zone_did
OS-511 make zonecfg device resource extensible, like the net resource
OS-224 add more zonecfg net properties
7 lines changed: 7 ins; 0 del; 0 mod; 238 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzonecfg/dtd/zonecfg.dtd.1
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

OS-200 need a better mechanism for storing persistent zone_did
OS-511 make zonecfg device resource extensible, like the net resource
OS-224 add more zonecfg net properties
OS-216 store all net config info on zone
12 lines changed: 9 ins; 0 del; 3 mod; 158 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.