Code Review for ldap

Prepared by:Dan McDonald <danmcd@nexenta.com> on 2011-Nov-01 12:05 -0400 EDT
Workspace:/export/home/danmcd/ws/ldap (at b3eb432f2686)
Compare against: /export/home/danmcd/ws/illumos-clone (at e702644ca141)
Summary of changes: 82 lines changed: 66 ins; 8 del; 8 mod; 1977 unchg
Patch of changes: ldap.patch
Printable review: ldap.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/idmap/idmapd/nldaputils.c

1668 CVE 2011-3508 (ldap format string issues)
18 lines changed: 18 ins; 0 del; 0 mod; 920 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ldap/ns_ldap/ldaplist.c

1668 CVE 2011-3508 (ldap format string issues)
16 lines changed: 16 ins; 0 del; 0 mod; 566 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libsldap/common/ns_getalias.c

1668 CVE 2011-3508 (ldap format string issues)
26 lines changed: 16 ins; 4 del; 6 mod; 208 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/nsswitch/ldap/common/ldap_utils.c

1668 CVE 2011-3508 (ldap format string issues)
22 lines changed: 16 ins; 4 del; 2 mod; 283 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.