Code Review for kayak

Prepared by:Dan McDonald (danmcd) on 2017-Mar-23 16:21 -0400 EDT
Workspace:/export/home/danmcd/ws/kayak (at 4c897c8b2bde)
Compare against: origin/master (https://github.com/omniti-labs/kayak at 048566e68d90)
Summary of changes: 1317 lines changed: 1198 ins; 54 del; 65 mod; 2403 unchg
Patch of changes: kayak.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw .gitignore

Remove iso-install.xml, hijacking console-login instead.
Fix controlling-terminal problem.
1 line changed: 1 ins; 0 del; 0 mod; 1 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw Makefile

build_iso shouldn't put the ISO in /tmp.
Add pxeboot/BSD Loader as an option for PXE Kayak boots.
Add usbgen.sh, add "install-usb" Makefile target, and declare Kayak for
ISO and USB at beta.
usbgen.sh courtesy of: Toomas Soome <tsoome@me.com>
Have build_iso.sh use BUILDSEND_MP
Make sure takeover-console.c appears in the package.
Remove iso-install.xml, hijacking console-login instead.
Fix controlling-terminal problem.
Kayak for ISO checkpoint 1
51 lines changed: 30 ins; 14 del; 7 mod; 97 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw README.md

Add pxeboot/BSD Loader as an option for PXE Kayak boots.
3 lines changed: 0 ins; 0 del; 3 mod; 28 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw build_image.sh

Modernize CDDL license text and copyrights for OmniTI-original code.
Add pxeboot/BSD Loader as an option for PXE Kayak boots.
Fix PXE regressions.
Add web/curl explicitly, because removing svm broke a long
dependency string that included web/curl.
Remove pcser and pcata, which no longer exist
Kayak for ISO checkpoint 1
34 lines changed: 9 ins; 14 del; 11 mod; 363 unchg

------ ------ ------ ------ ------ --- New Patch Raw build_iso.sh

Not all items are available in PREBUILT_ILLUMOS
Reduce PXE footprint after overcompensating for ISO.
build_iso shouldn't put the ISO in /tmp.
Remove commented-out-cruft from build_iso.sh
Fix PXE regressions.
Add ability to shift files and subdirs from_one_to_other
Do better on keyboard selection, plus save it in installed image.
Also, pv(1) output for install doesn't scroll anymore.
Customize loader using proper mechanisms
Clean up build_iso for readability, and workaround digest(1) problem.
Have build_iso.sh use BUILDSEND_MP
Remove iso-install.xml, hijacking console-login instead.
Fix controlling-terminal problem.
Kayak for ISO checkpoint 1
Initial foray into Kayak for ISO
153 lines changed: 153 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw data/access.log

Add /lib/amd64/libnvpair... for prtconf.
Reduce PXE footprint after overcompensating for ISO.
Update libnghttp2
Kayak for ISO checkpoint 1
Add terminal types for ISO/USB
2 lines changed: 1 ins; 0 del; 1 mod; 1505 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw data/known_extras

Do better on keyboard selection, plus save it in installed image.
Also, pv(1) output for install doesn't scroll anymore.
Clean up build_iso for readability, and workaround digest(1) problem.
Invoke kbd -s first-thing in kayak-menu
Kayak for ISO checkpoint 1
5 lines changed: 5 ins; 0 del; 0 mod; 69 unchg

------ ------ ------ ------ ------ --- New Patch Raw digest

Modernize CDDL license text and copyrights for OmniTI-original code.
Fix PXE regressions.
36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw disk_help.sh

Modernize CDDL license text and copyrights for OmniTI-original code.
Checkpoint for find-and-install
Generalize rpool to variable RPOOL in disk_help.sh
39 lines changed: 7 ins; 13 del; 19 mod; 148 unchg

------ ------ ------ ------ ------ --- New Patch Raw find-and-install.sh

Disk-selection was hopelessly naive.  Improve it, AND allow explicit
drive naming.
Reviewed by: Lauri Tirkkonen <lotheac@iki.fi>
Clean up find-and-install.
Do better on keyboard selection, plus save it in installed image.
Also, pv(1) output for install doesn't scroll anymore.
Checkpoint for find-and-install
Initial foray into Kayak for ISO
129 lines changed: 129 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw install_help.sh

Modernize CDDL license text and copyrights for OmniTI-original code.
Factor out SetKeyboardLayout so a PXE server-side config can call it out.
Fix PXE regressions.
Do better on keyboard selection, plus save it in installed image.
Also, pv(1) output for install doesn't scroll anymore.
Kayak for ISO checkpoint 1
Initial foray into Kayak for ISO
107 lines changed: 70 ins; 13 del; 24 mod; 192 unchg

------ ------ ------ ------ ------ --- New Patch Raw kayak-menu.sh

Modernize CDDL license text and copyrights for OmniTI-original code.
Some keyboard layouts aren't properly installed.
The selected keyboard layout should stick to the installation environment.
Do better on keyboard selection, plus save it in installed image.
Also, pv(1) output for install doesn't scroll anymore.
Invoke kbd -s first-thing in kayak-menu
Kayak for ISO checkpoint 1
Initial foray into Kayak for ISO
207 lines changed: 207 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw loader.conf.local

Typo in loader.conf.local
Add NFS tuning and advice to loader.conf.local
Add pxeboot/BSD Loader as an option for PXE Kayak boots.
24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw rpool-install.sh

Just use LANG=C for Kayak installs.
Do better on keyboard selection, plus save it in installed image.
Also, pv(1) output for install doesn't scroll anymore.
Kayak for ISO checkpoint 1
Initial foray into Kayak for ISO
84 lines changed: 84 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw takeover-console.c

Remove iso-install.xml, hijacking console-login instead.
Fix controlling-terminal problem.
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usbgen.sh

README.md
407 lines changed: 407 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.