Code Review for git-ixgbe

Prepared by:Dan McDonald (danmcd) on 2013-Apr-30 09:54 -0400 EDT
Workspace:/export/home/danmcd/ws/git-ixgbe (at 816df01b820f)
Compare against: origin/master (/export/home/danmcd/ws/git-illumos at d8fa96c30212)
Summary of changes: 873 lines changed: 649 ins; 71 del; 153 mod; 21402 unchg
Patch of changes: git-ixgbe.patch
Printable review: git-ixgbe.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ixgbe/ixgbe_82598.c

Import some changes from FreeBSD (details later, this is quick-n-dirty for now).
49 lines changed: 34 ins; 5 del; 10 mod; 1362 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ixgbe/ixgbe_82599.c

Import some changes from FreeBSD (details later, this is quick-n-dirty for now).
337 lines changed: 258 ins; 29 del; 50 mod; 2178 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ixgbe/ixgbe_82599.h

Import some changes from FreeBSD (details later, this is quick-n-dirty for now).
5 lines changed: 0 ins; 1 del; 4 mod; 60 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ixgbe/ixgbe_api.c

Import some changes from FreeBSD (details later, this is quick-n-dirty for now).
54 lines changed: 1 ins; 5 del; 48 mod; 1143 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ixgbe/ixgbe_api.h

Import some changes from FreeBSD (details later, this is quick-n-dirty for now).
4 lines changed: 1 ins; 1 del; 2 mod; 173 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ixgbe/ixgbe_common.c

Import some changes from FreeBSD (details later, this is quick-n-dirty for now).
268 lines changed: 257 ins; 3 del; 8 mod; 4151 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ixgbe/ixgbe_common.h

Import some changes from FreeBSD (details later, this is quick-n-dirty for now).
22 lines changed: 20 ins; 1 del; 1 mod; 144 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ixgbe/ixgbe_main.c

Import some changes from FreeBSD (details later, this is quick-n-dirty for now).
4 lines changed: 0 ins; 0 del; 4 mod; 5840 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ixgbe/ixgbe_mbx.h

Import some changes from FreeBSD (details later, this is quick-n-dirty for now).
13 lines changed: 12 ins; 0 del; 1 mod; 111 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ixgbe/ixgbe_phy.c

Import some changes from FreeBSD (details later, this is quick-n-dirty for now).
46 lines changed: 20 ins; 17 del; 9 mod; 1890 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ixgbe/ixgbe_phy.h

Import some changes from FreeBSD (details later, this is quick-n-dirty for now).
20 lines changed: 17 ins; 1 del; 2 mod; 140 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ixgbe/ixgbe_type.h

Import some changes from FreeBSD (details later, this is quick-n-dirty for now).
42 lines changed: 27 ins; 6 del; 9 mod; 3177 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ixgbe/ixgbe_x540.c

Import some changes from FreeBSD (details later, this is quick-n-dirty for now).
7 lines changed: 2 ins; 2 del; 3 mod; 970 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ixgbe/ixgbe_x540.h

Import some changes from FreeBSD (details later, this is quick-n-dirty for now).
2 lines changed: 0 ins; 0 del; 2 mod; 63 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.