Code Review for dual-package

Prepared by:Dan McDonald (danmcd) on 2016-Dec-12 15:05 -0500 EST
Workspace:/export/home/danmcd/ws/omnios-build (at cc3e0a07de0a)
Compare against: origin/master (https://github.com/omniti-labs/omnios-build at 1c25b7d8f87e)
Summary of changes: 1850 lines changed: 1116 ins; 727 del; 7 mod; 2146 unchg
Patch of changes: dual-package.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw build/entire/entire.p5m 

Make simplejson build for both 2.6 and 2.7
Make pyrex build for both 2.6 and 2.7
Make pyopenssl build for both 2.6 and 2.7
Make pycurl build for both 2.6 and 2.7
Make pybonjour build for both 2.6 and 2.7
Make ply build for both 2.6 and 2.7
Make numpy build for both 2.6 and 2.7
Make mako build for both 2.6 and 2.7
Make m2crypto build for both 2.6 and 2.7
Make setuptools build for both 2.6 and 2.7
Make cherrypy build for both 2.6 and 2.7
Reviewed by: Dale Ghent <daleg@omniti.com>
Reviewed by: Eric Sproul <eric.sproul@circonus.com>
11 lines changed: 11 ins; 0 del; 0 mod; 375 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw build/jeos/omnios-userland.p5m 

Make simplejson build for both 2.6 and 2.7
Make pyrex build for both 2.6 and 2.7
Make pyopenssl build for both 2.6 and 2.7
Make pycurl build for both 2.6 and 2.7
Make pybonjour build for both 2.6 and 2.7
Make ply build for both 2.6 and 2.7
Make numpy build for both 2.6 and 2.7
Make mako build for both 2.6 and 2.7
Make m2crypto build for both 2.6 and 2.7
Make lxml build for both 2.6 and 2.7
Make setuptools build for both 2.6 and 2.7
Make cherrypy build for both 2.6 and 2.7
Reviewed by: Dale Ghent <daleg@omniti.com>
Reviewed by: Eric Sproul <eric.sproul@circonus.com>
12 lines changed: 12 ins; 0 del; 0 mod; 148 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/python-cherrypy/build.sh 

Make cherrypy build for both 2.6 and 2.7
Reviewed by: Dale Ghent <daleg@omniti.com>
Reviewed by: Eric Sproul <eric.sproul@circonus.com>
64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw build/python-cherrypy/local.mog (renamed and modified from build/python26-cherrypy/local.mog) 

Make cherrypy build for both 2.6 and 2.7
Reviewed by: Dale Ghent <daleg@omniti.com>
Reviewed by: Eric Sproul <eric.sproul@circonus.com>
1 line changed: 0 ins; 0 del; 1 mod; 26 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/python-coverage/build.sh 

Make coverage build for both 2.6 and 2.7
64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/python-jsonrpclib/build.sh 

Make jsonrpclib build for both 2.6 and 2.7
64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/python-lxml/build.sh 

Make lxml build for both 2.6 and 2.7
66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/python-m2crypto/build.sh 

Make m2crypto build for both 2.6 and 2.7
66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/python-mako/build.sh 

Make mako build for both 2.6 and 2.7
64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/python-numpy/build.sh 

Make numpy build for both 2.6 and 2.7
80 lines changed: 80 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/python-numpy/local.mog 

Make numpy build for both 2.6 and 2.7
20 lines changed: 20 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/python-ply/build.sh 

Make ply build for both 2.6 and 2.7
72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/python-pybonjour/build.sh 

Make pybonjour build for both 2.6 and 2.7
71 lines changed: 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/python-pycurl/build.sh 

Make pycurl build for both 2.6 and 2.7
64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/python-pycurl/local.mog 

Make pycurl build for both 2.6 and 2.7
6 lines changed: 6 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/python-pylint/build.sh 

Make pylint build for both 2.6 and 2.7
64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/python-pyopenssl/build.sh 

Make pyopenssl build for both 2.6 and 2.7
64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/python-pyrex/build.sh 

Make pyrex build for both 2.6 and 2.7
70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/python-setuptools/build.sh 

Make setuptools build for both 2.6 and 2.7
68 lines changed: 68 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/python-setuptools/local.mog 

Make setuptools build for both 2.6 and 2.7
6 lines changed: 6 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/python-simplejson/build.sh 

Make simplejson build for both 2.6 and 2.7
62 lines changed: 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- build/python26-cherrypy/build.sh (deleted) 

Rename python26-* to python-* for dual-builds
44 lines changed: 0 ins; 44 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- build/python26-coverage/build.sh (deleted) 

Rename python26-* to python-* for dual-builds
44 lines changed: 0 ins; 44 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- build/python26-jsonrpclib/build.sh (deleted) 

Rename python26-* to python-* for dual-builds
44 lines changed: 0 ins; 44 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- build/python26-lxml/build.sh (deleted) 

Rename python26-* to python-* for dual-builds
45 lines changed: 0 ins; 45 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- build/python26-m2crypto/build.sh (deleted) 

Rename python26-* to python-* for dual-builds
45 lines changed: 0 ins; 45 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- build/python26-mako/build.sh (deleted) 

Rename python26-* to python-* for dual-builds
44 lines changed: 0 ins; 44 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- build/python26-numpy/build.sh (deleted) 

Rename python26-* to python-* for dual-builds
58 lines changed: 0 ins; 58 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- build/python26-numpy/local.mog (deleted) 

Rename python26-* to python-* for dual-builds
20 lines changed: 0 ins; 20 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- build/python26-ply/build.sh (deleted) 

Rename python26-* to python-* for dual-builds
50 lines changed: 0 ins; 50 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- build/python26-pybonjour/build.sh (deleted) 

Rename python26-* to python-* for dual-builds
50 lines changed: 0 ins; 50 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- build/python26-pycurl/build.sh (deleted) 

Rename python26-* to python-* for dual-builds
44 lines changed: 0 ins; 44 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- build/python26-pycurl/local.mog (deleted) 

Rename python26-* to python-* for dual-builds
6 lines changed: 0 ins; 6 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- build/python26-pylint/build.sh (deleted) 

Rename python26-* to python-* for dual-builds
44 lines changed: 0 ins; 44 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- build/python26-pyopenssl/build.sh (deleted) 

Rename python26-* to python-* for dual-builds
44 lines changed: 0 ins; 44 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- build/python26-pyrex/build.sh (deleted) 

Rename python26-* to python-* for dual-builds
49 lines changed: 0 ins; 49 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- build/python26-setuptools/build.sh (deleted) 

Rename python26-* to python-* for dual-builds
46 lines changed: 0 ins; 46 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- build/python26-setuptools/local.mog (deleted) 

Rename python26-* to python-* for dual-builds
6 lines changed: 0 ins; 6 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- build/python26-simplejson/build.sh (deleted) 

Rename python26-* to python-* for dual-builds
44 lines changed: 0 ins; 44 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw build/python27/build.sh 

Python2.7 needs to be aware we're a 32-and-64-bit Python.
31 lines changed: 27 ins; 0 del; 4 mod; 127 unchg

------ ------ ------ ------ ------ --- New Patch Raw build/python27/files/pyconfig.h 

Python2.7 needs to be aware we're a 32-and-64-bit Python.
22 lines changed: 22 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw lib/config.sh 

Infrastructure for python version agility
Reviewed by: Dale Ghent <daleg@omniti.com>
Reviewed by: Eric Sproul <eric.sproul@circonus.com>
1 line changed: 0 ins; 0 del; 1 mod; 211 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw lib/functions.sh 

Infrastructure for python version agility
Reviewed by: Dale Ghent <daleg@omniti.com>
Reviewed by: Eric Sproul <eric.sproul@circonus.com>
10 lines changed: 9 ins; 0 del; 1 mod; 1259 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.