Code Review for 8541

Prepared by:Dan McDonald (danmcd) on 2017-Aug-07 11:40 -0400 EDT
Workspace:/export/home/danmcd/ws/acquire-fixes (at ac804c643e95)
Compare against: origin/master (/export/home/danmcd/ws/illumos-gate at c5b186dedd5a)
Summary of changes: 120 lines changed: 115 ins; 1 del; 4 mod; 10704 unchg
Patch of changes: 8541.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ptools/pfiles/pfiles.c

8541 pfiles does not properly identify PF_KEY or PF_POLICY
Reviewed by: Mike Zeller <mike.zeller@joyent.com>
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
3 lines changed: 2 ins; 0 del; 1 mod; 813 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ip/keysock.c

8541 pfiles does not properly identify PF_KEY or PF_POLICY
Reviewed by: Mike Zeller <mike.zeller@joyent.com>
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
91 lines changed: 91 ins; 0 del; 0 mod; 2386 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ip/spdsock.c

8541 pfiles does not properly identify PF_KEY or PF_POLICY
Reviewed by: Mike Zeller <mike.zeller@joyent.com>
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
15 lines changed: 15 ins; 0 del; 0 mod; 3750 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ipsec_impl.h

8541 pfiles does not properly identify PF_KEY or PF_POLICY
Reviewed by: Mike Zeller <mike.zeller@joyent.com>
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
4 lines changed: 4 ins; 0 del; 0 mod; 1033 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/ia32/ml/modstubs.s

Yuri P's code review feedback
8541 pfiles does not properly identify PF_KEY or PF_POLICY
Reviewed by: Mike Zeller <mike.zeller@joyent.com>
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
4 lines changed: 1 ins; 0 del; 3 mod; 1429 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/ml/modstubs.s

Yuri P's code review feedback
8541 pfiles does not properly identify PF_KEY or PF_POLICY
Reviewed by: Mike Zeller <mike.zeller@joyent.com>
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
3 lines changed: 2 ins; 1 del; 0 mod; 1293 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.