Code Review for 7388

Prepared by:Dan McDonald (danmcd) on 2016-Nov-14 16:21 -0500 EST
Workspace:/export/home/danmcd/ws/7388 (at 3767f1b271f0)
Compare against: origin/master (/export/home/danmcd/ws/illumos-gate at 9185393f2919)
Summary of changes: 1900 lines changed: 1587 ins; 116 del; 197 mod; 35504 unchg
Patch of changes: 7388.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/etc/dhcp/inittab

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
3 lines changed: 2 ins; 0 del; 1 mod; 183 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/lib/ipmgmtd/ipmgmt_door.c

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
54 lines changed: 32 ins; 9 del; 13 mod; 842 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/lib/ipmgmtd/ipmgmt_impl.h

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
14 lines changed: 10 ins; 1 del; 3 mod; 191 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/lib/ipmgmtd/ipmgmt_persist.c

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
42 lines changed: 14 ins; 2 del; 26 mod; 1664 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/lib/nwamd/ncu.c

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
66 lines changed: 62 ins; 0 del; 4 mod; 2096 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/lib/nwamd/ncu.h

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
3 lines changed: 3 ins; 0 del; 0 mod; 231 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/sbin/dhcpagent/Makefile

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
3 lines changed: 2 ins; 0 del; 1 mod; 70 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/sbin/dhcpagent/agent.c

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
156 lines changed: 146 ins; 5 del; 5 mod; 1529 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/sbin/dhcpagent/defaults.c

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
4 lines changed: 3 ins; 0 del; 1 mod; 286 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/sbin/dhcpagent/defaults.h

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
4 lines changed: 3 ins; 0 del; 1 mod; 69 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/sbin/dhcpagent/dhcpagent.dfl

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
45 lines changed: 40 ins; 0 del; 5 mod; 125 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/sbin/dhcpagent/init_reboot.c

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
30 lines changed: 4 ins; 24 del; 2 mod; 264 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/sbin/dhcpagent/ipc_action.c

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
5 lines changed: 3 ins; 0 del; 2 mod; 273 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/sbin/dhcpagent/packet.c

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
67 lines changed: 44 ins; 11 del; 12 mod; 1558 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/sbin/dhcpagent/packet.h

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
3 lines changed: 3 ins; 0 del; 0 mod; 146 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/sbin/dhcpagent/renew.c

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
6 lines changed: 5 ins; 0 del; 1 mod; 555 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/sbin/dhcpagent/request.c

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
6 lines changed: 5 ins; 0 del; 1 mod; 1217 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/sbin/dhcpagent/select.c

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
27 lines changed: 4 ins; 21 del; 2 mod; 246 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/sbin/dhcpagent/states.c

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
17 lines changed: 15 ins; 0 del; 2 mod; 1616 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/sbin/dhcpagent/states.h

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
14 lines changed: 14 ins; 0 del; 0 mod; 330 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/sbin/dhcpagent/util.c

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
457 lines changed: 427 ins; 29 del; 1 mod; 677 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/sbin/dhcpagent/util.h

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
4 lines changed: 4 ins; 0 del; 0 mod; 83 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.sbin/ipadm/ipadm.c

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
34 lines changed: 27 ins; 0 del; 7 mod; 2217 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.sbin/nwamcfg/Makefile

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
2 lines changed: 1 ins; 0 del; 1 mod; 76 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.sbin/nwamcfg/nwamcfg.c

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
24 lines changed: 21 ins; 0 del; 3 mod; 4335 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.sbin/nwamcfg/nwamcfg.h

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
4 lines changed: 3 ins; 0 del; 1 mod; 180 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.sbin/nwamcfg/nwamcfg_grammar.y

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
25 lines changed: 25 ins; 0 del; 0 mod; 904 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.sbin/nwamcfg/nwamcfg_lex.l

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
3 lines changed: 3 ins; 0 del; 0 mod; 291 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/net/dhcp/dhcp_impl.h

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
6 lines changed: 6 ins; 0 del; 0 mod; 151 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/arpa/nameser.h

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
3 lines changed: 3 ins; 0 del; 0 mod; 701 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/Makefile

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
3 lines changed: 1 ins; 0 del; 2 mod; 720 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libipadm/Makefile.com

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
2 lines changed: 1 ins; 0 del; 1 mod; 53 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libipadm/common/ipadm_addr.c

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
394 lines changed: 330 ins; 14 del; 50 mod; 3532 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libipadm/common/ipadm_ipmgmt.h

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
32 lines changed: 29 ins; 0 del; 3 mod; 283 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libipadm/common/ipadm_ndpd.c

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
1 line changed: 0 ins; 0 del; 1 mod; 367 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libipadm/common/libipadm.c

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
83 lines changed: 79 ins; 0 del; 4 mod; 954 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libipadm/common/libipadm.h

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
20 lines changed: 17 ins; 0 del; 3 mod; 362 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libipadm/common/libipadm_impl.h

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
5 lines changed: 3 ins; 0 del; 2 mod; 231 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libipadm/common/mapfile-vers

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
4 lines changed: 4 ins; 0 del; 0 mod; 98 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnwam/Makefile.com

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
3 lines changed: 2 ins; 0 del; 1 mod; 62 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnwam/common/libnwam.h

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
3 lines changed: 3 ins; 0 del; 0 mod; 1062 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnwam/common/libnwam_ncp.c

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
24 lines changed: 23 ins; 0 del; 1 mod; 1718 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libresolv2/common/mapfile-vers

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
2 lines changed: 2 ins; 0 del; 0 mod; 360 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1m/dhcpagent.1m
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
126 lines changed: 98 ins; 0 del; 28 mod; 745 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1m/ipadm.1m
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
47 lines changed: 44 ins; 0 del; 3 mod; 831 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man4/dhcp_inittab.4
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
4 lines changed: 2 ins; 0 del; 2 mod; 626 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/onu.1onbld
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
8 lines changed: 7 ins; 0 del; 1 mod; 166 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/netinet/dhcp.h

7388 Support DHCP Client FQDN. Allow IAID/DUID for all v4.
8 lines changed: 8 ins; 0 del; 0 mod; 228 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.