7290 ZFS test suite needs to control what utilities it can run
Reviewed by: Dan Kimmel <dan.kimmel@delphix.com>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>

          --- old/usr/src/test/zfs-tests/tests/functional/userquota/userquota_005_neg.ksh
          +++ new/usr/src/test/zfs-tests/tests/functional/userquota/userquota_005_neg.ksh

   1    1  #!/usr/bin/ksh -p
   2    2  #
   3    3  # CDDL HEADER START
   4    4  #
   5    5  # The contents of this file are subject to the terms of the
   6    6  # Common Development and Distribution License (the "License").
   7    7  # You may not use this file except in compliance with the License.
   8    8  #
   9    9  # You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
  10   10  # or http://www.opensolaris.org/os/licensing.
  11   11  # See the License for the specific language governing permissions
  12   12  # and limitations under the License.
  13   13  #
  14   14  # When distributing Covered Code, include this CDDL HEADER in each
  15   15  # file and include the License file at usr/src/OPENSOLARIS.LICENSE.
  16   16  # If applicable, add the following below this CDDL HEADER, with the
  17   17  # fields enclosed by brackets "[]" replaced with your own identifying
  18   18  # information: Portions Copyright [yyyy] [name of copyright owner]

  19   19  #
  20   20  # CDDL HEADER END
  21   21  #
  22   22  
  23   23  #
  24   24  # Copyright 2009 Sun Microsystems, Inc.  All rights reserved.
  25   25  # Use is subject to license terms.
  26   26  #
  27   27  
  28   28  #
  29      -# Copyright (c) 2013 by Delphix. All rights reserved.
       29 +# Copyright (c) 2013, 2016 by Delphix. All rights reserved.
  30   30  #
  31   31  
  32   32  . $STF_SUITE/include/libtest.shlib
  33   33  . $STF_SUITE/tests/functional/userquota/userquota_common.kshlib
  34   34  
  35   35  #
  36   36  # DESCRIPTION:
  37   37  #       Check the invalid parameter of zfs set user|group quota
  38   38  #
  39   39  #
  40   40  # STRATEGY:
  41   41  #       1. check the invalid zfs set user|group quota to fs
  42   42  #       1. check the valid zfs set user|group quota to snapshots
  43   43  #
  44   44  
  45   45  function cleanup
  46   46  {
  47   47          if datasetexists $snap_fs; then
  48      -                log_must $ZFS destroy $snap_fs
       48 +                log_must zfs destroy $snap_fs
  49   49          fi
  50   50  
  51   51          log_must cleanup_quota
  52   52  }
  53   53  
  54   54  log_onexit cleanup
  55   55  
  56   56  log_assert "Check the invalid parameter of zfs set user|group quota"
  57   57  typeset snap_fs=$QFS@snap
  58   58  
  59      -log_must $ZFS snapshot $snap_fs
       59 +log_must zfs snapshot $snap_fs
  60   60  
  61   61  set -A no_users "mms1234" "ss@#" "root-122"
  62   62  for user in "${no_users[@]}"; do
  63      -        log_mustnot $ID $user
  64      -        log_mustnot $ZFS set userquota@$user=100m $QFS
       63 +        log_mustnot id $user
       64 +        log_mustnot zfs set userquota@$user=100m $QFS
  65   65  done
  66   66  
  67   67  log_note "can set all numberic id even that id is not existed"
  68      -log_must $ZFS set userquota@12345678=100m $QFS
  69      -log_mustnot $ZFS set userquota@12345678=100m $snap_fs
       68 +log_must zfs set userquota@12345678=100m $QFS
       69 +log_mustnot zfs set userquota@12345678=100m $snap_fs
  70   70  
  71   71  set -A sizes "100mfsd" "m0.12m" "GGM" "-1234-m" "123m-m"
  72   72  
  73   73  for size in "${sizes[@]}"; do
  74   74          log_note "can not set user quota with invalid size parameter"
  75      -        log_mustnot $ZFS set userquota@root=$size $QFS
       75 +        log_mustnot zfs set userquota@root=$size $QFS
  76   76  done
  77   77  
  78   78  log_note "can not set user quota to snapshot $snap_fs"
  79      -log_mustnot $ZFS set userquota@root=100m $snap_fs
       79 +log_mustnot zfs set userquota@root=100m $snap_fs
  80   80  
  81   81  
  82   82  set -A no_groups "aidsf@dfsd@" "123223-dsfds#sdfsd" "mss_#ss" "@@@@"
  83   83  for group in "${no_groups[@]}"; do
  84      -        log_mustnot eval "$GREP $group /etc/group"
  85      -        log_mustnot $ZFS set groupquota@$group=100m $QFS
       84 +        log_mustnot eval "grep $group /etc/group"
       85 +        log_mustnot zfs set groupquota@$group=100m $QFS
  86   86  done
  87   87  
  88   88  log_note "can not set group quota with invalid size parameter"
  89      -log_mustnot $ZFS set groupquota@root=100msfsd $QFS
       89 +log_mustnot zfs set groupquota@root=100msfsd $QFS
  90   90  
  91   91  log_note "can not set group quota to snapshot $snap_fs"
  92      -log_mustnot $ZFS set groupquota@root=100m $snap_fs
       92 +log_mustnot zfs set groupquota@root=100m $snap_fs
  93   93  
  94   94  log_pass "Check the invalid parameter of zfs set user|group quota pas as expect"
    

XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX