7290 ZFS test suite needs to control what utilities it can run
Reviewed by: Dan Kimmel <dan.kimmel@delphix.com>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>

          --- old/usr/src/test/zfs-tests/tests/functional/refquota/refquota_006_neg.ksh
          +++ new/usr/src/test/zfs-tests/tests/functional/refquota/refquota_006_neg.ksh

   1    1  #!/bin/ksh -p
   2    2  #
   3    3  # CDDL HEADER START
   4    4  #
   5    5  # The contents of this file are subject to the terms of the
   6    6  # Common Development and Distribution License (the "License").
   7    7  # You may not use this file except in compliance with the License.
   8    8  #
   9    9  # You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
  10   10  # or http://www.opensolaris.org/os/licensing.
  11   11  # See the License for the specific language governing permissions
  12   12  # and limitations under the License.
  13   13  #
  14   14  # When distributing Covered Code, include this CDDL HEADER in each
  15   15  # file and include the License file at usr/src/OPENSOLARIS.LICENSE.
  16   16  # If applicable, add the following below this CDDL HEADER, with the
  17   17  # fields enclosed by brackets "[]" replaced with your own identifying
  18   18  # information: Portions Copyright [yyyy] [name of copyright owner]

  19   19  #
  20   20  # CDDL HEADER END
  21   21  #
  22   22  
  23   23  #
  24   24  # Copyright 2008 Sun Microsystems, Inc.  All rights reserved.
  25   25  # Use is subject to license terms.
  26   26  #
  27   27  
  28   28  #
  29      -# Copyright (c) 2013 by Delphix. All rights reserved.
       29 +# Copyright (c) 2013, 2016 by Delphix. All rights reserved.
  30   30  #
  31   31  
  32   32  . $STF_SUITE/include/libtest.shlib
  33   33  
  34   34  #
  35   35  # DESCRIPTION:
  36   36  #       'zfs set refquota/refreserv' can handle incorrect arguments correctly.
  37   37  #
  38   38  # STRATEGY:
  39   39  #       1. Setup incorrect arguments arrays.
  40   40  #       2. Set the bad argument to refquota.
  41   41  #       3. Verify zfs can handle it correctly.
  42   42  #
  43   43  
  44   44  verify_runnable "both"
  45   45  
  46   46  function cleanup
  47   47  {
  48      -        log_must $ZFS set refquota=none $TESTPOOL/$TESTFS
  49      -        log_must $ZFS set refreserv=none $TESTPOOL/$TESTFS
       48 +        log_must zfs set refquota=none $TESTPOOL/$TESTFS
       49 +        log_must zfs set refreserv=none $TESTPOOL/$TESTFS
  50   50  }
  51   51  
  52   52  log_assert "'zfs set refquota' can handle incorrect arguments correctly."
  53   53  log_onexit cleanup
  54   54  
  55   55  set -A badopt   \
  56   56          "None"          "-1"            "1TT"           "%5"            \
  57   57          "123!"          "@456"          "7#89"          "0\$"           \
  58   58          "abc123%"       "123%s"         "12%s3"         "%c123"         \
  59   59          "123%d"         "%x123"         "12%p3"         "^def456"       \
  60   60          "\0"            "x0"
  61   61  
  62   62  typeset -i i=0
  63   63  while ((i < ${#badopt[@]})); do
  64      -        log_mustnot $ZFS set refquota=${badopt[$i]} $TESTPOOL/$TESTFS
  65      -        log_mustnot $ZFS set refreserv=${badopt[$i]} $TESTPOOL/$TESTFS
       64 +        log_mustnot zfs set refquota=${badopt[$i]} $TESTPOOL/$TESTFS
       65 +        log_mustnot zfs set refreserv=${badopt[$i]} $TESTPOOL/$TESTFS
  66   66  
  67   67          ((i += 1))
  68   68  done
  69   69  
  70   70  log_pass "'zfs set refquota' can handle incorrect arguments correctly."
    

XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX