7290 ZFS test suite needs to control what utilities it can run
Reviewed by: Dan Kimmel <dan.kimmel@delphix.com>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>

          --- old/usr/src/test/zfs-tests/tests/functional/nopwrite/nopwrite_varying_compression.ksh
          +++ new/usr/src/test/zfs-tests/tests/functional/nopwrite/nopwrite_varying_compression.ksh

   1    1  #!/usr/bin/ksh
   2    2  
   3    3  #
   4    4  # This file and its contents are supplied under the terms of the

   5    5  # Common Development and Distribution License ("CDDL"), version 1.0.
   6    6  # You may only use this file in accordance with the terms of version
   7    7  # 1.0 of the CDDL.
   8    8  #
   9    9  # A full copy of the text of the CDDL should have accompanied this
  10   10  # source.  A copy of the CDDL is also available via the Internet at
  11   11  # http://www.illumos.org/license/CDDL.
  12   12  #
  13   13  
  14   14  #
  15      -# Copyright (c) 2012 by Delphix. All rights reserved.
       15 +# Copyright (c) 2012, 2016 by Delphix. All rights reserved.
  16   16  #
  17   17  
  18   18  . $STF_SUITE/include/libtest.shlib
  19   19  . $STF_SUITE/include/properties.shlib
  20   20  . $STF_SUITE/tests/functional/nopwrite/nopwrite.shlib
  21   21  
  22   22  #
  23   23  # Description:
  24   24  # Verify that if the checksum on the origin and clone is sha256, any compression
  25   25  # algorithm enables nopwrite.

  26   26  #
  27   27  # Strategy:
  28   28  # 1. Create an origin dataset with compression and sha256 checksum.
  29   29  # 2. Write a 64M file into the origin dataset.
  30   30  # 3. For each of 4 randomly chosen compression types:
  31   31  # 3a. Create a snap and clone (inheriting the checksum property) of the origin.
  32   32  # 3b. Apply the compression property to the clone.

  33   33  # 3c. Write the same 64M of data into the file that exists in the clone.
  34   34  # 3d. Verify that no new space was consumed.
  35   35  #
  36   36  
  37   37  verify_runnable "global"
  38   38  origin="$TESTPOOL/$TESTFS"
  39   39  log_onexit cleanup
  40   40  
  41   41  function cleanup
  42   42  {
  43      -        datasetexists $origin && log_must $ZFS destroy -R $origin
  44      -        log_must $ZFS create -o mountpoint=$TESTDIR $origin
       43 +        datasetexists $origin && log_must zfs destroy -R $origin
       44 +        log_must zfs create -o mountpoint=$TESTDIR $origin
  45   45  }
  46   46  
  47   47  log_assert "nopwrite works with sha256 and any compression algorithm"
  48   48  
  49      -log_must $ZFS set compress=on $origin
  50      -log_must $ZFS set checksum=sha256 $origin
  51      -$DD if=/dev/urandom of=$TESTDIR/file bs=1024k count=$MEGS conv=notrunc \
       49 +log_must zfs set compress=on $origin
       50 +log_must zfs set checksum=sha256 $origin
       51 +dd if=/dev/urandom of=$TESTDIR/file bs=1024k count=$MEGS conv=notrunc \
  52   52      >/dev/null 2>&1 || log_fail "initial dd failed."
  53   53  
  54   54  # Verify nop_write for 4 random compression algorithms
  55   55  for i in $(get_rand_compress 4); do
  56      -        $ZFS snapshot $origin@a || log_fail "zfs snap failed"
  57      -        log_must $ZFS clone -o compress=$i $origin@a $origin/clone
  58      -        $DD if=/$TESTDIR/file of=/$TESTDIR/clone/file bs=1024k count=$MEGS \
       56 +        zfs snapshot $origin@a || log_fail "zfs snap failed"
       57 +        log_must zfs clone -o compress=$i $origin@a $origin/clone
       58 +        dd if=/$TESTDIR/file of=/$TESTDIR/clone/file bs=1024k count=$MEGS \
  59   59              conv=notrunc >/dev/null 2>&1 || log_fail "dd failed."
  60   60          log_must verify_nopwrite $origin $origin@a $origin/clone
  61      -        $ZFS destroy -R $origin@a || log_fail "zfs destroy failed"
       61 +        zfs destroy -R $origin@a || log_fail "zfs destroy failed"
  62   62  done
  63   63  
  64   64  log_pass "nopwrite works with sha256 and any compression algorithm"
    

XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX