7290 ZFS test suite needs to control what utilities it can run
Reviewed by: Dan Kimmel <dan.kimmel@delphix.com>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>

          --- old/usr/src/test/zfs-tests/tests/functional/nopwrite/nopwrite_promoted_clone.ksh
          +++ new/usr/src/test/zfs-tests/tests/functional/nopwrite/nopwrite_promoted_clone.ksh

   1    1  #!/usr/bin/ksh
   2    2  
   3    3  #
   4    4  # This file and its contents are supplied under the terms of the

   5    5  # Common Development and Distribution License ("CDDL"), version 1.0.
   6    6  # You may only use this file in accordance with the terms of version
   7    7  # 1.0 of the CDDL.
   8    8  #
   9    9  # A full copy of the text of the CDDL should have accompanied this
  10   10  # source.  A copy of the CDDL is also available via the Internet at
  11   11  # http://www.illumos.org/license/CDDL.
  12   12  #
  13   13  
  14   14  #
  15      -# Copyright (c) 2012 by Delphix. All rights reserved.
       15 +# Copyright (c) 2012, 2016 by Delphix. All rights reserved.
  16   16  #
  17   17  
  18   18  . $STF_SUITE/include/libtest.shlib
  19   19  . $STF_SUITE/tests/functional/nopwrite/nopwrite.shlib
  20   20  
  21   21  #
  22   22  # Description:
  23   23  # Verify that nopwrite still works for a dataset that becomes a clone via
  24   24  # promotion.
  25   25  #

  26   26  # Strategy:
  27   27  # 1. Create a clone suitable for nopwrite.
  28   28  # 2. Disable compression and checksum on the clone, and promote it.

  29   29  # 3. Overwrite the file in the clone (former origin fs) and verify it
  30   30  # consumes no additional space.
  31   31  #
  32   32  
  33   33  verify_runnable "global"
  34   34  origin="$TESTPOOL/$TESTFS"
  35   35  log_onexit cleanup
  36   36  
  37   37  function cleanup
  38   38  {
  39      -        datasetexists $origin && log_must $ZFS destroy -R $TESTPOOL/clone
  40      -        log_must $ZFS create -o mountpoint=$TESTDIR $origin
       39 +        datasetexists $origin && log_must zfs destroy -R $TESTPOOL/clone
       40 +        log_must zfs create -o mountpoint=$TESTDIR $origin
  41   41  }
  42   42  
  43   43  log_assert "nopwrite works on a dataset that becomes a clone via promotion."
  44   44  
  45      -log_must $ZFS set compress=on $origin
  46      -log_must $ZFS set checksum=sha256 $origin
  47      -$DD if=/dev/urandom of=$TESTDIR/file bs=1024k count=$MEGS conv=notrunc \
       45 +log_must zfs set compress=on $origin
       46 +log_must zfs set checksum=sha256 $origin
       47 +dd if=/dev/urandom of=$TESTDIR/file bs=1024k count=$MEGS conv=notrunc \
  48   48      >/dev/null 2>&1 || log_fail "dd into $TESTDIR/file failed."
  49      -$ZFS snapshot $origin@a || log_fail "zfs snap failed"
  50      -log_must $ZFS clone $origin@a $TESTPOOL/clone
  51      -log_must $ZFS set compress=off $TESTPOOL/clone
  52      -log_must $ZFS set checksum=off $TESTPOOL/clone
  53      -log_must $ZFS promote $TESTPOOL/clone
  54      -$DD if=/$TESTPOOL/clone/file of=/$TESTDIR/file bs=1024k count=$MEGS \
       49 +zfs snapshot $origin@a || log_fail "zfs snap failed"
       50 +log_must zfs clone $origin@a $TESTPOOL/clone
       51 +log_must zfs set compress=off $TESTPOOL/clone
       52 +log_must zfs set checksum=off $TESTPOOL/clone
       53 +log_must zfs promote $TESTPOOL/clone
       54 +dd if=/$TESTPOOL/clone/file of=/$TESTDIR/file bs=1024k count=$MEGS \
  55   55      conv=notrunc >/dev/null 2>&1 || log_fail "dd failed."
  56   56  log_must verify_nopwrite $TESTPOOL/clone $TESTPOOL/clone@a $origin
  57   57  
  58   58  log_pass "nopwrite works on a dataset that becomes a clone via promotion."
    

XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX