7290 ZFS test suite needs to control what utilities it can run
Reviewed by: Dan Kimmel <dan.kimmel@delphix.com>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>

          --- old/usr/src/test/zfs-tests/tests/functional/mdb/mdb_001_pos.ksh
          +++ new/usr/src/test/zfs-tests/tests/functional/mdb/mdb_001_pos.ksh

   1    1  #!/bin/ksh -p
   2    2  #
   3    3  # CDDL HEADER START
   4    4  #
   5    5  # The contents of this file are subject to the terms of the
   6    6  # Common Development and Distribution License (the "License").
   7    7  # You may not use this file except in compliance with the License.
   8    8  #
   9    9  # You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
  10   10  # or http://www.opensolaris.org/os/licensing.
  11   11  # See the License for the specific language governing permissions
  12   12  # and limitations under the License.
  13   13  #
  14   14  # When distributing Covered Code, include this CDDL HEADER in each
  15   15  # file and include the License file at usr/src/OPENSOLARIS.LICENSE.
  16   16  # If applicable, add the following below this CDDL HEADER, with the
  17   17  # fields enclosed by brackets "[]" replaced with your own identifying
  18   18  # information: Portions Copyright [yyyy] [name of copyright owner]

  19   19  #
  20   20  # CDDL HEADER END
  21   21  #
  22   22  
  23   23  #
  24   24  # Copyright 2008 Sun Microsystems, Inc.  All rights reserved.
  25   25  # Use is subject to license terms.
  26   26  #
  27   27  
  28   28  #
  29      -# Copyright (c) 2013 by Delphix. All rights reserved.
       29 +# Copyright (c) 2013, 2016 by Delphix. All rights reserved.
  30   30  #
  31   31  
  32   32  . $STF_SUITE/include/libtest.shlib
  33   33  
  34   34  #
  35   35  # DESCRIPTION:
  36   36  #       Verify that the ZFS mdb dcmds and walkers are working as expected.
  37   37  #
  38   38  # STRATEGY:
  39   39  #       1) Given a list of dcmds and walkers
  40   40  #       2) Step through each element of the list
  41   41  #       3) Verify the output by checking for "mdb:" in the output string
  42   42  #
  43   43  
  44   44  function cleanup
  45   45  {
  46      -        $RM -f $OUTFILE
       46 +        rm -f $OUTFILE
  47   47  }
  48   48  
  49   49  verify_runnable "global"
  50   50  log_onexit cleanup
  51   51  
  52   52  OUTFILE='/var/tmp/mdb-outfile'
  53   53  set -A dcmds "::walk spa" \
  54   54          "::walk spa | ::spa " \
  55   55          "::walk spa | ::spa -c" \
  56   56          "::walk spa | ::spa -v" \

  57   57          "::walk spa | ::spa_config" \
  58   58          "::walk spa | ::spa_space" \
  59   59          "::walk spa | ::spa_space -b" \
  60   60          "::walk spa | ::spa_vdevs" \
  61   61          "::walk spa | ::walk metaslab" \
  62   62          "::walk spa | ::print struct spa spa_root_vdev | ::vdev" \
  63   63          "::walk spa | ::print struct spa spa_root_vdev | ::vdev -re" \
  64   64          "::dbufs" \
  65   65          "::dbufs -n mos -o mdn -l 0 -b 0" \
  66   66          "::dbufs | ::dbuf" \
  67   67          "::dbuf_stats" \
  68   68          "::abuf_find 1 2" \
  69   69          "::walk spa | ::print -a struct spa spa_uberblock.ub_rootbp | ::blkptr" \
  70   70          "::walk spa | ::print -a struct spa spa_dsl_pool->dp_dirty_datasets | ::walk txg_list" \
  71   71          "::walk spa | ::walk zms_freelist"
  72   72  #
  73   73  # The commands above were supplied by the ZFS development team. The idea is to

  74   74  # do as much checking as possible without the need to hardcode addresses.
  75   75  #
  76   76  
  77   77  log_assert "Verify that the ZFS mdb dcmds and walkers are working as expected."
  78   78  
  79   79  typeset -i RET=0
  80   80  
  81   81  i=0
  82   82  while (( $i < ${#dcmds[*]} )); do
  83   83          log_note "Verifying: '${dcmds[i]}'"
  84      -        $ECHO "${dcmds[i]}" | $MDB -k > $OUTFILE 2>&1
       84 +        echo "${dcmds[i]}" | mdb -k > $OUTFILE 2>&1
  85   85          RET=$?
  86   86          if (( $RET != 0 )); then
  87   87                  log_fail "mdb '${dcmds[i]}' returned error $RET"
  88   88          fi
  89   89  
  90   90          #
  91   91          # mdb prefixes all errors with "mdb: " so we check the output.
  92   92          #
  93      -        $GREP "mdb:" $OUTFILE > /dev/null 2>&1
       93 +        grep "mdb:" $OUTFILE > /dev/null 2>&1
  94   94          RET=$?
  95   95          if (( $RET == 0 )); then
  96      -                $ECHO "mdb '${dcmds[i]}' contained 'mdb:'"
  97      -                # Using $TAIL limits the number of lines in the log
  98      -                $TAIL -100 $OUTFILE
       96 +                echo "mdb '${dcmds[i]}' contained 'mdb:'"
       97 +                # Using tail limits the number of lines in the log
       98 +                tail -100 $OUTFILE
  99   99                  log_fail "mdb walker or dcmd failed"
 100  100          fi
 101  101  
 102  102          ((i = i + 1))
 103  103  done
 104  104  
 105  105  log_pass "The ZFS mdb dcmds and walkers are working as expected."
    

XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX