7290 ZFS test suite needs to control what utilities it can run
Reviewed by: Dan Kimmel <dan.kimmel@delphix.com>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>

          --- old/usr/src/test/zfs-tests/tests/functional/inuse/inuse_006_pos.ksh
          +++ new/usr/src/test/zfs-tests/tests/functional/inuse/inuse_006_pos.ksh

   1    1  #!/usr/bin/ksh -p
   2    2  #
   3    3  # CDDL HEADER START
   4    4  #
   5    5  # The contents of this file are subject to the terms of the
   6    6  # Common Development and Distribution License (the "License").
   7    7  # You may not use this file except in compliance with the License.
   8    8  #
   9    9  # You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
  10   10  # or http://www.opensolaris.org/os/licensing.
  11   11  # See the License for the specific language governing permissions
  12   12  # and limitations under the License.
  13   13  #
  14   14  # When distributing Covered Code, include this CDDL HEADER in each
  15   15  # file and include the License file at usr/src/OPENSOLARIS.LICENSE.
  16   16  # If applicable, add the following below this CDDL HEADER, with the
  17   17  # fields enclosed by brackets "[]" replaced with your own identifying
  18   18  # information: Portions Copyright [yyyy] [name of copyright owner]

  19   19  #
  20   20  # CDDL HEADER END
  21   21  #
  22   22  
  23   23  #
  24   24  # Copyright 2009 Sun Microsystems, Inc.  All rights reserved.
  25   25  # Use is subject to license terms.
  26   26  #
  27   27  
  28   28  #
  29      -# Copyright (c) 2013, 2015 by Delphix. All rights reserved.
       29 +# Copyright (c) 2013, 2016 by Delphix. All rights reserved.
  30   30  #
  31   31  
  32   32  . $STF_SUITE/include/libtest.shlib
  33   33  . $STF_SUITE/tests/functional/inuse/inuse.cfg
  34   34  
  35   35  #
  36   36  # DESCRIPTION:
  37   37  # dumpadm will not interfere with devices and spare devices that are in use
  38   38  # by active pool.
  39   39  #
  40   40  # STRATEGY:
  41   41  # 1. Create a regular|mirror|raidz|raidz2 pool with the given disk
  42   42  # 2. Try to dumpadm against the disk, verify it fails as expect.
  43   43  #
  44   44  
  45   45  verify_runnable "global"
  46   46  
  47   47  function cleanup
  48   48  {
  49   49          if [[ -n $PREVDUMPDEV ]]; then
  50      -                log_must $DUMPADM -u -d $PREVDUMPDEV
       50 +                log_must dumpadm -u -d $PREVDUMPDEV
  51   51          fi
  52   52  
  53   53          poolexists $TESTPOOL1 && destroy_pool $TESTPOOL1
  54   54  
  55   55          #
  56   56          # Tidy up the disks we used.
  57   57          #
  58   58          cleanup_devices $vdisks $sdisks
  59   59  }
  60   60  
  61   61  function verify_assertion #slices
  62   62  {
  63   63          typeset targets=$1
  64   64  
  65   65          for t in $targets; do
  66      -                log_mustnot $DUMPADM -d $t
       66 +                log_mustnot dumpadm -d $t
  67   67          done
  68   68  
  69   69          return 0
  70   70  }
  71   71  
  72   72  log_assert "Verify dumpadm over active pool fails."
  73   73  
  74   74  log_onexit cleanup
  75   75  
  76   76  set -A vdevs "" "mirror" "raidz" "raidz1" "raidz2"
  77   77  
  78   78  typeset -i i=0
  79   79  
  80      -PREVDUMPDEV=`$DUMPADM | $GREP "Dump device" | $AWK '{print $3}'`
       80 +PREVDUMPDEV=`dumpadm | grep "Dump device" | awk '{print $3}'`
  81   81  
  82   82  unset NOINUSE_CHECK
  83   83  while (( i < ${#vdevs[*]} )); do
  84   84  
  85   85          for num in 0 1 2 3 ; do
  86   86                  eval typeset slice=\${FS_SIDE$num}
  87   87                  disk=${slice%s*}
  88   88                  slice=${slice##*s}
  89   89                  log_must set_partition $slice "" $FS_SIZE $disk
  90   90          done

  91   91  
  92   92          if [[ -n $SINGLE_DISK && -n ${vdevs[i]} ]]; then
  93   93                  (( i = i + 1 ))
  94   94                  continue
  95   95          fi
  96   96  
  97   97          create_pool $TESTPOOL1 ${vdevs[i]} $vslices spare $sslices
  98   98          verify_assertion "$disktargets"
  99   99          destroy_pool $TESTPOOL1
 100  100  
 101  101          if [[ ( $FS_DISK0 == $FS_DISK2 ) && -n ${vdevs[i]} ]]; then
 102  102                  (( i = i + 1 ))
 103  103                  continue
 104  104          fi
 105  105  
 106  106          if [[ ( $FS_DISK0 == $FS_DISK3 ) && ( ${vdevs[i]} == "raidz2" ) ]]; then
 107  107                  (( i = i + 1 ))
 108  108                  continue
 109  109          fi
 110  110  
 111  111          create_pool $TESTPOOL1 ${vdevs[i]} $vdisks spare $sdisks
 112  112          verify_assertion "$disktargets"
 113  113          destroy_pool $TESTPOOL1
 114  114  
 115  115          (( i = i + 1 ))
 116  116  done
 117  117  
 118  118  log_pass "Dumpadm over active pool fails."

XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX