7290 ZFS test suite needs to control what utilities it can run
Reviewed by: Dan Kimmel <dan.kimmel@delphix.com>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>

          --- old/usr/src/test/zfs-tests/tests/functional/inuse/inuse_005_pos.ksh
          +++ new/usr/src/test/zfs-tests/tests/functional/inuse/inuse_005_pos.ksh

   1    1  #!/usr/bin/ksh -p
   2    2  #
   3    3  # CDDL HEADER START
   4    4  #
   5    5  # The contents of this file are subject to the terms of the
   6    6  # Common Development and Distribution License (the "License").
   7    7  # You may not use this file except in compliance with the License.
   8    8  #
   9    9  # You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
  10   10  # or http://www.opensolaris.org/os/licensing.
  11   11  # See the License for the specific language governing permissions
  12   12  # and limitations under the License.
  13   13  #
  14   14  # When distributing Covered Code, include this CDDL HEADER in each
  15   15  # file and include the License file at usr/src/OPENSOLARIS.LICENSE.
  16   16  # If applicable, add the following below this CDDL HEADER, with the
  17   17  # fields enclosed by brackets "[]" replaced with your own identifying
  18   18  # information: Portions Copyright [yyyy] [name of copyright owner]

  19   19  #
  20   20  # CDDL HEADER END
  21   21  #
  22   22  
  23   23  #
  24   24  # Copyright 2009 Sun Microsystems, Inc.  All rights reserved.
  25   25  # Use is subject to license terms.
  26   26  #
  27   27  
  28   28  #
  29      -# Copyright (c) 2013, 2015 by Delphix. All rights reserved.
       29 +# Copyright (c) 2013, 2016 by Delphix. All rights reserved.
  30   30  #
  31   31  
  32   32  . $STF_SUITE/include/libtest.shlib
  33   33  . $STF_SUITE/tests/functional/inuse/inuse.cfg
  34   34  
  35   35  #
  36   36  # DESCRIPTION:
  37   37  # newfs will not interfere with devices and spare devices that are in use
  38   38  # by active pool.
  39   39  #

  40   40  # STRATEGY:
  41   41  # 1. Create a regular|mirror|raidz|raidz2 pool with the given disk
  42   42  # 2. Try to newfs against the disk, verify it fails as expect.
  43   43  #
  44   44  
  45   45  verify_runnable "global"
  46   46  
  47   47  function cleanup
  48   48  {
  49   49          poolexists $TESTPOOL1 && destroy_pool $TESTPOOL1
  50   50  
  51   51          #

  52   52          # Tidy up the disks we used.
  53   53          #
  54   54          cleanup_devices $vdisks $sdisks
  55   55  }
  56   56  
  57   57  function verify_assertion #slices
  58   58  {
  59   59          typeset targets=$1
  60   60  
  61   61          for t in $targets; do
  62      -                $ECHO "y" | $NEWFS -v $t > /dev/null 2>&1
       62 +                echo "y" | newfs -v $t > /dev/null 2>&1
  63   63                  (( $? !=0 )) || \
  64   64                          log_fail "newfs over active pool " \
  65   65                          "unexpected return code of 0"
  66   66          done
  67   67  
  68   68          return 0
  69   69  }
  70   70  
  71   71  log_assert "Verify newfs over active pool fails."
  72   72  

  73   73  log_onexit cleanup
  74   74  
  75   75  set -A vdevs "" "mirror" "raidz" "raidz1" "raidz2"
  76   76  
  77   77  typeset -i i=0
  78   78  
  79   79  unset NOINUSE_CHECK
  80   80  while (( i < ${#vdevs[*]} )); do
  81   81  
  82   82          for num in 0 1 2 3 ; do
  83   83                  eval typeset slice=\${FS_SIDE$num}
  84   84                  disk=${slice%s*}
  85   85                  slice=${slice##*s}
  86   86                  log_must set_partition $slice "" $FS_SIZE $disk
  87   87          done
  88   88  
  89   89          if [[ -n $SINGLE_DISK && -n ${vdevs[i]} ]]; then
  90   90                  (( i = i + 1 ))
  91   91                  continue
  92   92          fi
  93   93  
  94   94          create_pool $TESTPOOL1 ${vdevs[i]} $vslices spare $sslices
  95   95          verify_assertion "$rawtargets"
  96   96          destroy_pool $TESTPOOL1
  97   97  
  98   98          if [[ ( $FS_DISK0 == $FS_DISK2 ) && -n ${vdevs[i]} ]]; then
  99   99                  (( i = i + 1 ))
 100  100                  continue
 101  101          fi
 102  102  
 103  103          if [[ ( $FS_DISK0 == $FS_DISK3 ) && ( ${vdevs[i]} == "raidz2" ) ]]; then
 104  104                  (( i = i + 1 ))
 105  105                  continue
 106  106          fi
 107  107  
 108  108          create_pool $TESTPOOL1 ${vdevs[i]} $vdisks spare $sdisks
 109  109          verify_assertion "$rawtargets"
 110  110          destroy_pool $TESTPOOL1
 111  111  
 112  112          (( i = i + 1 ))
 113  113  done
 114  114  
 115  115  log_pass "Newfs over active pool fails."

XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX