7290 ZFS test suite needs to control what utilities it can run
Reviewed by: Dan Kimmel <dan.kimmel@delphix.com>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>

          --- old/usr/src/test/zfs-tests/tests/functional/exec/exec_002_neg.ksh
          +++ new/usr/src/test/zfs-tests/tests/functional/exec/exec_002_neg.ksh

   1    1  #!/bin/ksh -p
   2    2  #
   3    3  # CDDL HEADER START
   4    4  #
   5    5  # The contents of this file are subject to the terms of the
   6    6  # Common Development and Distribution License (the "License").
   7    7  # You may not use this file except in compliance with the License.
   8    8  #
   9    9  # You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
  10   10  # or http://www.opensolaris.org/os/licensing.
  11   11  # See the License for the specific language governing permissions
  12   12  # and limitations under the License.
  13   13  #
  14   14  # When distributing Covered Code, include this CDDL HEADER in each
  15   15  # file and include the License file at usr/src/OPENSOLARIS.LICENSE.
  16   16  # If applicable, add the following below this CDDL HEADER, with the
  17   17  # fields enclosed by brackets "[]" replaced with your own identifying
  18   18  # information: Portions Copyright [yyyy] [name of copyright owner]

  19   19  #
  20   20  # CDDL HEADER END
  21   21  #
  22   22  
  23   23  #
  24   24  # Copyright 2007 Sun Microsystems, Inc.  All rights reserved.
  25   25  # Use is subject to license terms.
  26   26  #
  27   27  
  28   28  #
  29      -# Copyright (c) 2013 by Delphix. All rights reserved.
       29 +# Copyright (c) 2013, 2016 by Delphix. All rights reserved.
  30   30  #
  31   31  
  32   32  . $STF_SUITE/include/libtest.shlib
  33   33  
  34   34  #
  35   35  # DESCRIPTION:
  36   36  # When set property exec=off on a filesystem, processes can not be executed from
  37   37  # this filesystem.
  38   38  #
  39   39  # STRATEGY:

  40   40  # 1. Create pool and file system.
  41   41  # 2. Copy '/usr/bin/ls' to the ZFS file system.

  42   42  # 3. Setting exec=off on this file system.
  43   43  # 4. Make sure '/usr/bin/ls' can not work in this ZFS file system.
  44   44  # 5. Make sure mmap which is using the PROT_EXEC calls failed.
  45   45  #
  46   46  
  47   47  verify_runnable "both"
  48   48  MMAP_EXEC=$STF_SUITE/tests/functional/exec/mmap_exec
  49   49  
  50   50  function cleanup
  51   51  {
  52      -        log_must $RM $TESTDIR/myls
       52 +        log_must rm $TESTDIR/myls
  53   53  }
  54   54  
  55   55  #
  56   56  # Execute and check if the return value is equal to expected.
  57   57  #
  58   58  # $1 expected value
  59   59  # $2..$n executed item
  60   60  #
  61   61  function exec_n_check
  62   62  {

  63   63          typeset expect_value=$1
  64   64  
  65   65          shift
  66   66          $@
  67   67          ret=$?
  68   68          if [[ $ret != $expect_value ]]; then

  69   69                  log_fail "Unexpected return code: '$ret'"
  70   70          fi
  71   71  
  72   72          return 0
  73   73  }
  74   74  
  75   75  log_assert "Setting exec=off on a filesystem, processes can not be executed " \
  76   76          "from this file system."
  77   77  log_onexit cleanup
  78   78  
  79      -log_must $CP $LS $TESTDIR/myls
  80      -log_must $ZFS set exec=off $TESTPOOL/$TESTFS
       79 +log_must cp /usr/bin/ls $TESTDIR/myls
       80 +log_must zfs set exec=off $TESTPOOL/$TESTFS
  81   81  
  82   82  log_must exec_n_check 126 $TESTDIR/myls
  83   83  log_must exec_n_check 13 $MMAP_EXEC $TESTDIR/myls
  84   84  
  85   85  log_pass "Setting exec=off on filesystem testing passed."
    

XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX