7290 ZFS test suite needs to control what utilities it can run
Reviewed by: Dan Kimmel <dan.kimmel@delphix.com>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>

          --- old/usr/src/test/zfs-tests/tests/functional/bootfs/bootfs_008_neg.ksh
          +++ new/usr/src/test/zfs-tests/tests/functional/bootfs/bootfs_008_neg.ksh

   1    1  #!/usr/bin/ksh -p
   2    2  #
   3    3  # CDDL HEADER START
   4    4  #
   5    5  # The contents of this file are subject to the terms of the
   6    6  # Common Development and Distribution License (the "License").
   7    7  # You may not use this file except in compliance with the License.
   8    8  #
   9    9  # You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
  10   10  # or http://www.opensolaris.org/os/licensing.
  11   11  # See the License for the specific language governing permissions
  12   12  # and limitations under the License.
  13   13  #
  14   14  # When distributing Covered Code, include this CDDL HEADER in each
  15   15  # file and include the License file at usr/src/OPENSOLARIS.LICENSE.
  16   16  # If applicable, add the following below this CDDL HEADER, with the
  17   17  # fields enclosed by brackets "[]" replaced with your own identifying
  18   18  # information: Portions Copyright [yyyy] [name of copyright owner]

  19   19  #
  20   20  # CDDL HEADER END
  21   21  #
  22   22  
  23   23  #
  24   24  # Copyright 2009 Sun Microsystems, Inc.  All rights reserved.
  25   25  # Use is subject to license terms.
  26   26  #
  27   27  
  28   28  #
  29      -# Copyright (c) 2012, 2015 by Delphix. All rights reserved.
       29 +# Copyright (c) 2012, 2016 by Delphix. All rights reserved.
  30   30  #
  31   31  
  32   32  . $STF_SUITE/include/libtest.shlib
  33   33  
  34   34  #
  35   35  # DESCRIPTION:
  36   36  #
  37   37  # setting bootfs on a dataset which has gzip compression enabled will fail
  38   38  #
  39   39  # STRATEGY:

  40   40  # 1. create pools based on a valid vdev
  41   41  # 2. create a filesytem on this pool and set the compression property to gzip1-9
  42   42  # 3. set the pool's bootfs property to filesystem we just configured which
  43   43  #    should fail

  44   44  #
  45   45  
  46   46  verify_runnable "global"
  47   47  
  48   48  function cleanup {
  49   49          if poolexists $TESTPOOL ; then
  50   50                  destroy_pool "$TESTPOOL"
  51   51          fi
  52   52  
  53   53          if [[ -f $VDEV ]]; then
  54      -                log_must $RM -f $VDEV
       54 +                log_must rm -f $VDEV
  55   55          fi
  56   56  }
  57   57  
  58   58  typeset assert_msg="setting bootfs on a dataset which has gzip \
  59   59      compression enabled will fail"
  60   60  
  61   61  typeset VDEV=/bootfs_008_neg_a.$$.dat
  62   62  typeset COMP_FS=$TESTPOOL/COMP_FS
  63   63  
  64   64  log_onexit cleanup
  65   65  log_assert $assert_msg
  66   66  
  67      -log_must $MKFILE $MINVDEVSIZE $VDEV
  68      -log_must $ZPOOL create $TESTPOOL $VDEV
  69      -log_must $ZFS create $COMP_FS
       67 +log_must mkfile $MINVDEVSIZE $VDEV
       68 +log_must zpool create $TESTPOOL $VDEV
       69 +log_must zfs create $COMP_FS
  70   70  
  71   71  typeset -i i=0
  72   72  set -A gtype "gzip" "gzip-1" "gzip-2" "gzip-3" "gzip-4" "gzip-5" \
  73   73               "gzip-6" "gzip-7" "gzip-8" "gzip-9"
  74   74  
  75   75  while (( i < ${#gtype[@]} )); do
  76      -        log_must $ZFS set compression=${gtype[i]} $COMP_FS
  77      -        log_mustnot $ZPOOL set bootfs=$COMP_FS $TESTPOOL
  78      -        log_must $ZFS set compression=off $COMP_FS
       76 +        log_must zfs set compression=${gtype[i]} $COMP_FS
       77 +        log_mustnot zpool set bootfs=$COMP_FS $TESTPOOL
       78 +        log_must zfs set compression=off $COMP_FS
  79   79          (( i += 1 ))
  80   80  done
  81   81  
  82   82  log_pass $assert_msg
    

XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX