Print this page
6121 Copy-paste bug in mac_init_rings()
        
*** 4034,4049 ****
  
                  /*
                   * Driver must register group->mgi_addmac/remmac() for rx groups
                   * to support multiple MAC addresses.
                   */
!                 if (rtype == MAC_RING_TYPE_RX) {
!                         if ((group_info.mgi_addmac == NULL) ||
!                             (group_info.mgi_addmac == NULL)) {
                                  goto bail;
                          }
-                 }
  
                  /* Cache driver-supplied information */
                  group->mrg_info = group_info;
  
                  /* Update the group's status and group count. */
--- 4034,4049 ----
  
                  /*
                   * Driver must register group->mgi_addmac/remmac() for rx groups
                   * to support multiple MAC addresses.
                   */
!                 if (rtype == MAC_RING_TYPE_RX &&
!                     ((group_info.mgi_addmac == NULL) ||
!                     (group_info.mgi_remmac == NULL))) {
!                         err = EINVAL;
                          goto bail;
                  }
  
                  /* Cache driver-supplied information */
                  group->mrg_info = group_info;
  
                  /* Update the group's status and group count. */