Print this page
5056 ZFS deadlock on db_mtx and dn_holds
Reviewed by: Will Andrews <willa@spectralogic.com>
Reviewed by: Matt Ahrens <mahrens@delphix.com>
Reviewed by: George Wilson <george.wilson@delphix.com>
Approved by: Dan McDonald <danmcd@omniti.com>
| Split |
Close |
| Expand all |
| Collapse all |
--- old/usr/src/uts/common/fs/zfs/sys/dmu_objset.h
+++ new/usr/src/uts/common/fs/zfs/sys/dmu_objset.h
1 1 /*
2 2 * CDDL HEADER START
3 3 *
4 4 * The contents of this file are subject to the terms of the
5 5 * Common Development and Distribution License (the "License").
6 6 * You may not use this file except in compliance with the License.
7 7 *
8 8 * You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
9 9 * or http://www.opensolaris.org/os/licensing.
10 10 * See the License for the specific language governing permissions
11 11 * and limitations under the License.
12 12 *
13 13 * When distributing Covered Code, include this CDDL HEADER in each
14 14 * file and include the License file at usr/src/OPENSOLARIS.LICENSE.
|
↓ open down ↓ |
14 lines elided |
↑ open up ↑ |
15 15 * If applicable, add the following below this CDDL HEADER, with the
16 16 * fields enclosed by brackets "[]" replaced with your own identifying
17 17 * information: Portions Copyright [yyyy] [name of copyright owner]
18 18 *
19 19 * CDDL HEADER END
20 20 */
21 21 /*
22 22 * Copyright (c) 2005, 2010, Oracle and/or its affiliates. All rights reserved.
23 23 * Copyright (c) 2012, 2014 by Delphix. All rights reserved.
24 24 * Copyright (c) 2013 by Saso Kiselkov. All rights reserved.
25 + * Copyright (c) 2014 Spectra Logic Corporation, All rights reserved.
25 26 */
26 27
27 28 /* Portions Copyright 2010 Robert Milkowski */
28 29
29 30 #ifndef _SYS_DMU_OBJSET_H
30 31 #define _SYS_DMU_OBJSET_H
31 32
32 33 #include <sys/spa.h>
33 34 #include <sys/arc.h>
34 35 #include <sys/txg.h>
35 36 #include <sys/zfs_context.h>
36 37 #include <sys/dnode.h>
37 38 #include <sys/zio.h>
38 39 #include <sys/zil.h>
39 40 #include <sys/sa.h>
40 41
41 42 #ifdef __cplusplus
42 43 extern "C" {
43 44 #endif
44 45
45 46 extern krwlock_t os_lock;
46 47
47 48 struct dsl_pool;
48 49 struct dsl_dataset;
49 50 struct dmu_tx;
50 51
51 52 #define OBJSET_PHYS_SIZE 2048
52 53 #define OBJSET_OLD_PHYS_SIZE 1024
53 54
54 55 #define OBJSET_BUF_HAS_USERUSED(buf) \
55 56 (arc_buf_size(buf) > OBJSET_OLD_PHYS_SIZE)
56 57
57 58 #define OBJSET_FLAG_USERACCOUNTING_COMPLETE (1ULL<<0)
58 59
59 60 typedef struct objset_phys {
60 61 dnode_phys_t os_meta_dnode;
61 62 zil_header_t os_zil_header;
62 63 uint64_t os_type;
63 64 uint64_t os_flags;
64 65 char os_pad[OBJSET_PHYS_SIZE - sizeof (dnode_phys_t)*3 -
65 66 sizeof (zil_header_t) - sizeof (uint64_t)*2];
66 67 dnode_phys_t os_userused_dnode;
|
↓ open down ↓ |
32 lines elided |
↑ open up ↑ |
67 68 dnode_phys_t os_groupused_dnode;
68 69 } objset_phys_t;
69 70
70 71 struct objset {
71 72 /* Immutable: */
72 73 struct dsl_dataset *os_dsl_dataset;
73 74 spa_t *os_spa;
74 75 arc_buf_t *os_phys_buf;
75 76 objset_phys_t *os_phys;
76 77 /*
77 - * The following "special" dnodes have no parent and are exempt from
78 - * dnode_move(), but they root their descendents in this objset using
79 - * handles anyway, so that all access to dnodes from dbufs consistently
80 - * uses handles.
78 + * The following "special" dnodes have no parent, are exempt
79 + * from dnode_move(), and are not recorded in os_dnodes, but they
80 + * root their descendents in this objset using handles anyway, so
81 + * that all access to dnodes from dbufs consistently uses handles.
81 82 */
82 83 dnode_handle_t os_meta_dnode;
83 84 dnode_handle_t os_userused_dnode;
84 85 dnode_handle_t os_groupused_dnode;
85 86 zilog_t *os_zil;
86 87
88 + list_node_t os_evicting_node;
89 +
87 90 /* can change, under dsl_dir's locks: */
88 91 enum zio_checksum os_checksum;
89 92 enum zio_compress os_compress;
90 93 uint8_t os_copies;
91 94 enum zio_checksum os_dedup_checksum;
92 95 boolean_t os_dedup_verify;
96 + boolean_t os_evicting;
93 97 zfs_logbias_op_t os_logbias;
94 98 zfs_cache_type_t os_primary_cache;
95 99 zfs_cache_type_t os_secondary_cache;
96 100 zfs_sync_type_t os_sync;
97 101 zfs_redundant_metadata_type_t os_redundant_metadata;
98 102 int os_recordsize;
99 103
100 104 /* no lock needed: */
101 105 struct dmu_tx *os_synctx; /* XXX sketchy */
102 106 blkptr_t *os_rootbp;
103 107 zil_header_t os_zil_header;
104 108 list_t os_synced_dnodes;
105 109 uint64_t os_flags;
106 110
107 111 /* Protected by os_obj_lock */
108 112 kmutex_t os_obj_lock;
109 113 uint64_t os_obj_next;
110 114
111 115 /* Protected by os_lock */
112 116 kmutex_t os_lock;
113 117 list_t os_dirty_dnodes[TXG_SIZE];
114 118 list_t os_free_dnodes[TXG_SIZE];
115 119 list_t os_dnodes;
116 120 list_t os_downgraded_dbufs;
117 121
118 122 /* stuff we store for the user */
119 123 kmutex_t os_user_ptr_lock;
120 124 void *os_user_ptr;
121 125 sa_os_t *os_sa;
122 126 };
123 127
124 128 #define DMU_META_OBJSET 0
125 129 #define DMU_META_DNODE_OBJECT 0
126 130 #define DMU_OBJECT_IS_SPECIAL(obj) ((int64_t)(obj) <= 0)
127 131 #define DMU_META_DNODE(os) ((os)->os_meta_dnode.dnh_dnode)
128 132 #define DMU_USERUSED_DNODE(os) ((os)->os_userused_dnode.dnh_dnode)
129 133 #define DMU_GROUPUSED_DNODE(os) ((os)->os_groupused_dnode.dnh_dnode)
130 134
131 135 #define DMU_OS_IS_L2CACHEABLE(os) \
132 136 ((os)->os_secondary_cache == ZFS_CACHE_ALL || \
133 137 (os)->os_secondary_cache == ZFS_CACHE_METADATA)
134 138
135 139 #define DMU_OS_IS_L2COMPRESSIBLE(os) (zfs_mdcomp_disable == B_FALSE)
136 140
137 141 /* called from zpl */
138 142 int dmu_objset_hold(const char *name, void *tag, objset_t **osp);
139 143 int dmu_objset_own(const char *name, dmu_objset_type_t type,
140 144 boolean_t readonly, void *tag, objset_t **osp);
141 145 void dmu_objset_refresh_ownership(objset_t *os, void *tag);
142 146 void dmu_objset_rele(objset_t *os, void *tag);
143 147 void dmu_objset_disown(objset_t *os, void *tag);
144 148 int dmu_objset_from_ds(struct dsl_dataset *ds, objset_t **osp);
145 149
146 150 void dmu_objset_stats(objset_t *os, nvlist_t *nv);
147 151 void dmu_objset_fast_stat(objset_t *os, dmu_objset_stats_t *stat);
148 152 void dmu_objset_space(objset_t *os, uint64_t *refdbytesp, uint64_t *availbytesp,
149 153 uint64_t *usedobjsp, uint64_t *availobjsp);
150 154 uint64_t dmu_objset_fsid_guid(objset_t *os);
151 155 int dmu_objset_find_dp(struct dsl_pool *dp, uint64_t ddobj,
152 156 int func(struct dsl_pool *, struct dsl_dataset *, void *),
153 157 void *arg, int flags);
154 158 int dmu_objset_prefetch(const char *name, void *arg);
155 159 void dmu_objset_evict_dbufs(objset_t *os);
156 160 timestruc_t dmu_objset_snap_cmtime(objset_t *os);
157 161
158 162 /* called from dsl */
159 163 void dmu_objset_sync(objset_t *os, zio_t *zio, dmu_tx_t *tx);
160 164 boolean_t dmu_objset_is_dirty(objset_t *os, uint64_t txg);
161 165 objset_t *dmu_objset_create_impl(spa_t *spa, struct dsl_dataset *ds,
162 166 blkptr_t *bp, dmu_objset_type_t type, dmu_tx_t *tx);
|
↓ open down ↓ |
60 lines elided |
↑ open up ↑ |
163 167 int dmu_objset_open_impl(spa_t *spa, struct dsl_dataset *ds, blkptr_t *bp,
164 168 objset_t **osp);
165 169 void dmu_objset_evict(objset_t *os);
166 170 void dmu_objset_do_userquota_updates(objset_t *os, dmu_tx_t *tx);
167 171 void dmu_objset_userquota_get_ids(dnode_t *dn, boolean_t before, dmu_tx_t *tx);
168 172 boolean_t dmu_objset_userused_enabled(objset_t *os);
169 173 int dmu_objset_userspace_upgrade(objset_t *os);
170 174 boolean_t dmu_objset_userspace_present(objset_t *os);
171 175 int dmu_fsname(const char *snapname, char *buf);
172 176
177 +void dmu_objset_evict_done(objset_t *os);
178 +
173 179 void dmu_objset_init(void);
174 180 void dmu_objset_fini(void);
175 181
176 182 #ifdef __cplusplus
177 183 }
178 184 #endif
179 185
180 186 #endif /* _SYS_DMU_OBJSET_H */
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX