Code Review for gwr-2-plus

Prepared by:Dan McDonald on 2019-Oct-15 13:53 -0400 EDT
Workspace:/export/home/danmcd/ws/illumos-joyent (at c9977352e35a)
Compare against: origin/nfs-zone (https://github.com/joyent/illumos-joyent at 89fc0c92cf52)
Summary of changes: 71 lines changed: 49 ins; 5 del; 17 mod; 29293 unchg
Patch of changes: gwr-2-plus.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/nfs/nfs3_srv.c

Caution with use after exi_rele()
Be far more judicious in the use of curzone-using macros.
5 lines changed: 4 ins; 1 del; 0 mod; 4461 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/nfs/nfs4_srv.c

Hyperaggressive asserts pt 2/N
Be far more judicious in the use of curzone-using macros.
14 lines changed: 4 ins; 2 del; 8 mod; 10095 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/nfs/nfs4_srv_attr.c

Be far more judicious in the use of curzone-using macros.
15 lines changed: 12 ins; 0 del; 3 mod; 2859 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/nfs/nfs4_srv_ns.c

Caution with use after exi_rele()
Ooops exi_zoneid isn't a variable again yet
Be far more judicious in the use of curzone-using macros.
9 lines changed: 7 ins; 1 del; 1 mod; 1284 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/nfs/nfs_export.c

Hyperaggressive asserts pt 1/N
Ooops exi_zoneid isn't a variable again yet
Be far more judicious in the use of curzone-using macros.
16 lines changed: 10 ins; 1 del; 5 mod; 2980 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/nfs/nfs_server.c

Caution with use after exi_rele()
Be far more judicious in the use of curzone-using macros.
4 lines changed: 4 ins; 0 del; 0 mod; 3401 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/nfs/nfs_srv.c

Caution with use after exi_rele()
1 line changed: 1 ins; 0 del; 0 mod; 3163 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/zone.h

Be far more judicious in the use of curzone-using macros.
7 lines changed: 7 ins; 0 del; 0 mod; 1050 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.