Code Review for illumos-gate

Prepared by:Dan McDonald (danmcd) on 2015-Jan-21 15:51 -0500 EST
Workspace:/export/home/danmcd/ws/rmustacc/illumos-gate (at 44ef224157af)
Compare against: origin/master (/export/home/danmcd/ws/rmustacc/../illumos-gate at 22253b45e469)
Summary of changes: 1092 lines changed: 776 ins; 102 del; 214 mod; 58996 unchg
Patch of changes: illumos-gate.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/Makefile.lint

OS-478 -- lint
1 line changed: 0 ins; 1 del; 0 mod; 525 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dladm/dladm.c

OS-792 dladm show-linkprop -z zonename doesn't restrict output to that zone, unless you also specify the vnic name
OS-406
OS-249
103 lines changed: 72 ins; 0 del; 31 mod; 9660 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dlmgmtd/dlmgmt_db.c

Fixes to allow compilation on OmniOS and OI
OS-3342+co
OS-3007 dlmgmtd needs to work with non-native zones
OS-375 i_dls_mgmt_upcall()/dlmgmt_zfop() deadlock in dlmgmtd
OS-383 dladm rename-link doesn't update /etc/svc/volatile/dladm/network-datalink-management:default.cache
OS-249
172 lines changed: 154 ins; 0 del; 18 mod; 1441 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dlmgmtd/dlmgmt_door.c

OS-3342+co
OS-722
OS-478 -- lint
OS-375-1
OS-328 dlmgmtd/mac_link_flow_add() deadlock
OS-249
65 lines changed: 63 ins; 1 del; 1 mod; 1446 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dlmgmtd/dlmgmt_impl.h

OS-3342+co
OS-375 i_dls_mgmt_upcall()/dlmgmt_zfop() deadlock in dlmgmtd
OS-375-1
5 lines changed: 4 ins; 0 del; 1 mod; 147 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dlmgmtd/dlmgmt_main.c

OS-3007 dlmgmtd needs to work with non-native zones
OS-1572
OS-375 i_dls_mgmt_upcall()/dlmgmt_zfop() deadlock in dlmgmtd
OS-375-1
OS-327
56 lines changed: 46 ins; 0 del; 10 mod; 536 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dlmgmtd/dlmgmt_util.c

OS-3342+co
OS-249
16 lines changed: 2 ins; 13 del; 1 mod; 781 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dlstat/dlstat.c

OS-277 add ZONE column to dlstat output
43 lines changed: 15 ins; 1 del; 27 mod; 2429 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/flowadm/flowadm.c

OS-281
45 lines changed: 29 ins; 10 del; 6 mod; 1286 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/flowstat/flowstat.c

OS-276 global zone duplicate kstat when two zones have same vnic name
18 lines changed: 12 ins; 3 del; 3 mod; 1143 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ibd_upgrade/ibd_delete_link.c

OS-249
2 lines changed: 2 ins; 0 del; 0 mod; 151 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zoneadm/zoneadm.c

Fixes to allow compilation on OmniOS and OI
OS-478 -- lint
2 lines changed: 1 ins; 1 del; 0 mod; 5793 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zoneadmd/vplat.c

OS-478 -- lint
OS-406
OS-327
44 lines changed: 2 ins; 37 del; 5 mod; 5281 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zoneadmd/zoneadmd.c

Fixes to allow compilation on OmniOS and OI
OS-3342+co
OS-1572
OS-327
10 lines changed: 9 ins; 0 del; 1 mod; 2290 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/libdladm.h

OS-406
6 lines changed: 6 ins; 0 del; 0 mod; 295 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/libdllink.c

OS-249
20 lines changed: 12 ins; 0 del; 8 mod; 1018 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/libdllink.h

OS-249
5 lines changed: 4 ins; 0 del; 1 mod; 226 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/libdlmgmt.c

OS-478 -- lint
OS-249
18 lines changed: 17 ins; 0 del; 1 mod; 759 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/libdlvnic.c

OS-406
OS-249
22 lines changed: 12 ins; 3 del; 7 mod; 805 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/linkprop.c

OS-406
3 lines changed: 3 ins; 0 del; 0 mod; 4772 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/mapfile-vers

OS-249
2 lines changed: 2 ins; 0 del; 0 mod; 275 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1m/dladm.1m
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

manuals
80 lines changed: 62 ins; 6 del; 12 mod; 5473 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1m/flowadm.1m
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

manuals
42 lines changed: 31 ins; 4 del; 7 mod; 1009 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/dld/dld_drv.c

OS-406
OS-249
4 lines changed: 2 ins; 0 del; 2 mod; 1511 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/dls/dls_mgmt.c

OS-1885 deadlock between vnic destroy and kstat read
OS-676 debug kernel blew assertion in dls_devnet_stat_create()
OS-428 add link zonename kstat
OS-406
OS-327
OS-276 global zone duplicate kstat when two zones have same vnic name
OS-249
148 lines changed: 117 ins; 0 del; 31 mod; 1746 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/dls/dls_stat.c

OS-428 add link zonename kstat (change ks_data_size before init)
OS-428 add link zonename kstat
134 lines changed: 74 ins; 22 del; 38 mod; 73 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/zone.c

OS-3342+co
15 lines changed: 15 ins; 0 del; 0 mod; 7174 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/dld.h

OS-406
OS-249
3 lines changed: 3 ins; 0 del; 0 mod; 433 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/dls.h

OS-406
OS-249
3 lines changed: 1 ins; 0 del; 2 mod; 153 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/dls_impl.h

OS-428 add link zonename kstat
3 lines changed: 2 ins; 0 del; 1 mod; 133 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/dls_mgmt.h

OS-249
2 lines changed: 2 ins; 0 del; 0 mod; 232 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.