Code Review for ij-tcp-connstat

Prepared by:Dan McDonald (danmcd) on 2018-Mar-01 14:54 -0500 EST
Workspace:/export/home/danmcd/ws/ij-tcp-connstat (at 89240d53a687)
Compare against: origin/master (/export/home/danmcd/ws/illumos-joyent at bc6e5c6cabe4)
Summary of changes: 4855 lines changed: 4417 ins; 267 del; 171 mod; 59195 unchg
Patch of changes: ij-tcp-connstat.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw exception_lists/cstyle 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
4 lines changed: 4 ins; 0 del; 0 mod; 1468 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw exception_lists/hdrchk 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
2 lines changed: 2 ins; 0 del; 0 mod; 449 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/Makefile 

DLPX-37540 TCP per-connection kernel statistics DLPX-37544 connstat command to display per-connection TCP statistics
3 lines changed: 2 ins; 0 del; 1 mod; 840 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/connstat/Makefile 

Properly enable C99 support for connstat in illumos-gate.
DLPX-37540 TCP per-connection kernel statistics DLPX-37544 connstat command to display per-connection TCP statistics
58 lines changed: 58 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/connstat/connstat.h 

DLPX-39339 need a connstat man page DLPX-45914 combining connstat address and port filters doesn't always work DLPX-45941 connstat should support filtering based on TCP state
DLPX-37540 TCP per-connection kernel statistics DLPX-37544 connstat command to display per-connection TCP statistics
77 lines changed: 77 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/connstat/connstat.xcl 

DLPX-37540 TCP per-connection kernel statistics DLPX-37544 connstat command to display per-connection TCP statistics
84 lines changed: 84 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/connstat/connstat_main.c 

DLPX-39339 need a connstat man page DLPX-45914 combining connstat address and port filters doesn't always work DLPX-45941 connstat should support filtering based on TCP state
DLPX-45697 Adding Avg. RTT to connstat
DLPX-45049 include unsent bytes in connstat output
DLPX-43064 include high-resolution round-trip times in connstat (EP-652)
DLPX-37540 TCP per-connection kernel statistics DLPX-37544 connstat command to display per-connection TCP statistics
565 lines changed: 565 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/connstat/connstat_mib.c 

DLPX-37540 TCP per-connection kernel statistics DLPX-37544 connstat command to display per-connection TCP statistics
137 lines changed: 137 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/connstat/connstat_mib.h 

DLPX-37540 TCP per-connection kernel statistics DLPX-37544 connstat command to display per-connection TCP statistics
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/connstat/connstat_tcp.c 

DLPX-39339 need a connstat man page DLPX-45914 combining connstat address and port filters doesn't always work DLPX-45941 connstat should support filtering based on TCP state
DLPX-45697 Adding Avg. RTT to connstat
DLPX-44739 connstat rtt field should be 0 for connections that have not sent data
DLPX-45049 include unsent bytes in connstat output
DLPX-43064 include high-resolution round-trip times in connstat (EP-652)
DLPX-37540 TCP per-connection kernel statistics DLPX-37544 connstat command to display per-connection TCP statistics
384 lines changed: 384 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/connstat/connstat_tcp.h 

DLPX-39339 need a connstat man page DLPX-45914 combining connstat address and port filters doesn't always work DLPX-45941 connstat should support filtering based on TCP state
DLPX-43064 include high-resolution round-trip times in connstat (EP-652)
DLPX-37540 TCP per-connection kernel statistics DLPX-37544 connstat command to display per-connection TCP statistics
50 lines changed: 50 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libinetutil/common/mapfile-vers 

DLPX-37540 TCP per-connection kernel statistics DLPX-37544 connstat command to display per-connection TCP statistics
Bring in Delphix enhancements to libofmt.
3 lines changed: 3 ins; 0 del; 0 mod; 78 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libipadm/common/ipadm_prop.c 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
44 lines changed: 42 ins; 0 del; 2 mod; 1955 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libofmt/common/mapfile-vers 

Bring in Delphix enhancements to libofmt.
4 lines changed: 3 ins; 1 del; 0 mod; 43 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libofmt/common/ofmt.c 

Bring in Delphix enhancements to libofmt.
63 lines changed: 19 ins; 18 del; 26 mod; 616 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libofmt/common/ofmt.h 

Bring in Delphix enhancements to libofmt.
17 lines changed: 15 ins; 2 del; 0 mod; 218 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1m/Makefile 

DLPX-39339 need a connstat man page DLPX-45914 combining connstat address and port filters doesn't always work DLPX-45941 connstat should support filtering based on TCP state
1 line changed: 1 ins; 0 del; 0 mod; 757 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man1m/connstat.1m
man: ------ ------ ------ ------ ------ TXT HTML Raw 

Update connstat(1M) man page to modern specs.
DLPX-39339 need a connstat man page DLPX-45914 combining connstat address and port filters doesn't always work DLPX-45941 connstat should support filtering based on TCP state
387 lines changed: 387 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1m/ipadm.1m
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
4 lines changed: 3 ins; 0 del; 1 mod; 899 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/SUNWcs.man1m.inc 

DLPX-39339 need a connstat man page DLPX-45914 combining connstat address and port filters doesn't always work DLPX-45941 connstat should support filtering based on TCP state
2 lines changed: 2 ins; 0 del; 0 mod; 292 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/SUNWcs.mf 

DLPX-37540 TCP per-connection kernel statistics DLPX-37544 connstat command to display per-connection TCP statistics
2 lines changed: 2 ins; 0 del; 0 mod; 1787 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-header.mf 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
2 lines changed: 1 ins; 0 del; 1 mod; 2119 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-kernel.mf 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
6 lines changed: 6 ins; 0 del; 0 mod; 704 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/Makefile.targ 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
4 lines changed: 4 ins; 0 del; 0 mod; 487 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/Makefile.uts 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
7 lines changed: 4 ins; 0 del; 3 mod; 637 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/Makefile.files 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
7 lines changed: 7 ins; 0 del; 0 mod; 2327 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/Makefile.rules 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
8 lines changed: 7 ins; 0 del; 1 mod; 2892 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/Makefile 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
3 lines changed: 2 ins; 0 del; 1 mod; 56 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/cc.h 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
212 lines changed: 212 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/cc/cc.c 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
163 lines changed: 163 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/cc/cc_cubic.c 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
427 lines changed: 427 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/cc/cc_cubic.h 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
208 lines changed: 208 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/cc/cc_module.h 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
56 lines changed: 56 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/cc/cc_newreno.c 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
268 lines changed: 268 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/cc/cc_sunreno.c 

DLPX-56025 sunreno's tcp_cwnd_ssthresh should be halved after RTO
Reviewed at: http://reviews.delphix.com/r/36669/
DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
223 lines changed: 223 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ip/ip.c 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
DLPX-37540 TCP per-connection kernel statistics DLPX-37544 connstat command to display per-connection TCP statistics
10 lines changed: 10 ins; 0 del; 0 mod; 15297 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/mib2.h 

DLPX-45697 Adding Avg. RTT to connstat
DLPX-45049 include unsent bytes in connstat output
DLPX-43064 include high-resolution round-trip times in connstat (EP-652)
DLPX-37540 TCP per-connection kernel statistics DLPX-37544 connstat command to display per-connection TCP statistics
51 lines changed: 24 ins; 19 del; 8 mod; 1767 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp.h 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
DLPX-45697 Adding Avg. RTT to connstat
DLPX-43064 include high-resolution round-trip times in connstat (EP-652)
DLPX-37540 TCP per-connection kernel statistics DLPX-37544 connstat command to display per-connection TCP statistics
21 lines changed: 8 ins; 7 del; 6 mod; 593 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp/tcp.c 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
DLPX-45697 Adding Avg. RTT to connstat
DLPX-43064 include high-resolution round-trip times in connstat (EP-652)
DLPX-42721 Create inline function for TCP RTO calculation
DLPX-37540 TCP per-connection kernel statistics DLPX-37544 connstat command to display per-connection TCP statistics
95 lines changed: 55 ins; 29 del; 11 mod; 4457 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp/tcp_fusion.c 

DLPX-37540 TCP per-connection kernel statistics DLPX-37544 connstat command to display per-connection TCP statistics
9 lines changed: 6 ins; 3 del; 0 mod; 885 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp/tcp_input.c 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
DLPX-45697 Adding Avg. RTT to connstat
DLPX-43064 include high-resolution round-trip times in connstat (EP-652)
DLPX-42721 Create inline function for TCP RTO calculation
DLPX-37540 TCP per-connection kernel statistics DLPX-37544 connstat command to display per-connection TCP statistics
347 lines changed: 208 ins; 72 del; 67 mod; 5649 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp/tcp_opt_data.c 

DLPX-43064 include high-resolution round-trip times in connstat (EP-652)
DLPX-42721 Create inline function for TCP RTO calculation
12 lines changed: 1 ins; 7 del; 4 mod; 1201 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp/tcp_output.c 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
DLPX-43064 include high-resolution round-trip times in connstat (EP-652)
DLPX-37540 TCP per-connection kernel statistics DLPX-37544 connstat command to display per-connection TCP statistics
60 lines changed: 40 ins; 3 del; 17 mod; 3694 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp/tcp_stats.c 

DLPX-45697 Adding Avg. RTT to connstat
DLPX-45049 include unsent bytes in connstat output
DLPX-43064 include high-resolution round-trip times in connstat (EP-652)
DLPX-37540 TCP per-connection kernel statistics DLPX-37544 connstat command to display per-connection TCP statistics
108 lines changed: 45 ins; 59 del; 4 mod; 994 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp/tcp_time_wait.c 

DLPX-37540 TCP per-connection kernel statistics DLPX-37544 connstat command to display per-connection TCP statistics
3 lines changed: 2 ins; 0 del; 1 mod; 831 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp/tcp_timers.c 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
DLPX-43064 include high-resolution round-trip times in connstat (EP-652)
DLPX-42721 Create inline function for TCP RTO calculation
DLPX-37540 TCP per-connection kernel statistics DLPX-37544 connstat command to display per-connection TCP statistics
55 lines changed: 12 ins; 31 del; 12 mod; 1067 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp/tcp_tunables.c 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
55 lines changed: 54 ins; 0 del; 1 mod; 534 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp_impl.h 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
DLPX-43064 include high-resolution round-trip times in connstat (EP-652)
DLPX-42721 Create inline function for TCP RTO calculation
16 lines changed: 4 ins; 11 del; 1 mod; 789 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp_stack.h 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
3 lines changed: 3 ins; 0 del; 0 mod; 135 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp_stats.h 

DLPX-37540 TCP per-connection kernel statistics DLPX-37544 connstat command to display per-connection TCP statistics
21 lines changed: 21 ins; 0 del; 0 mod; 251 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/queue.h 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
15 lines changed: 10 ins; 5 del; 0 mod; 673 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/time.h 

DLPX-43064 include high-resolution round-trip times in connstat (EP-652)
3 lines changed: 0 ins; 0 del; 3 mod; 490 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/Makefile.intel 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
6 lines changed: 6 ins; 0 del; 0 mod; 757 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/intel/cc_cubic/Makefile 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
73 lines changed: 73 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/intel/cc_newreno/Makefile 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
73 lines changed: 73 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/intel/cc_sunreno/Makefile 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
73 lines changed: 73 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/Makefile.sparc 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
7 lines changed: 7 ins; 0 del; 0 mod; 507 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/sparc/cc_cubic/Makefile 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
73 lines changed: 73 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/sparc/cc_newreno/Makefile 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
73 lines changed: 73 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/sparc/cc_sunreno/Makefile 

DLPX-25998 TCP congestion control is inadequate
Reviewed at: http://reviews.delphix.com/r/34808/
73 lines changed: 73 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.