Code Review for ij-15167

Prepared by:Dan McDonald on 2023-Mar-15 20:39 -0400 EDT
Workspace:/export/home/danmcd/ij-15167 (at 22bdba06d8f1)
Compare against: origin/master (https://github.com/joyent/illumos-joyent.git at 17a73190e09f)
Summary of changes: 414 lines changed: 272 ins; 70 del; 72 mod; 12785 unchg
Patch of changes: ij-15167.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dlmgmtd/dlmgmt_db.c

post-merge correct dlmgmt_db.c
15167 Panic when halting a zone with self-created links
15407 zone_free asserts to its destruction when dlmgmtd has fallen
15408 dlmgmtd/zoneadmd interdependencies prevent dlmgmtd from starting
15409 dlmgmtd forking with write locks results in deadlock chaos
Portions contributed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Portions contributed by: Joshua M. Clulow <jmc@joyent.com>
Portions contributed by: Robert Mustacchi <rm@joyent.com>
Portions contributed by: Ryan Zezeski <rpz@joyent.com>
Change-ID: I17810387d2142c5c7e426e106e4c2dbb8f2496d4
Conflicts:
    usr/src/cmd/dlmgmtd/dlmgmt_db.c
    usr/src/cmd/dlmgmtd/dlmgmt_door.c
    usr/src/cmd/dlmgmtd/dlmgmt_impl.h
    usr/src/cmd/dlmgmtd/dlmgmt_main.c
    usr/src/cmd/dlmgmtd/dlmgmt_util.c
    usr/src/cmd/zoneadmd/vplat.c
    usr/src/lib/libdladm/common/libdladm.h
    usr/src/lib/libdladm/common/libdlmgmt.c
    usr/src/uts/common/io/dls/dls_mgmt.c
31 lines changed: 26 ins; 2 del; 3 mod; 1544 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dlmgmtd/dlmgmt_door.c

usr/src/cmd/dlmgmtd/dlmgmt_door.c
9 lines changed: 3 ins; 2 del; 4 mod; 1455 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dlmgmtd/dlmgmt_impl.h

usr/src/cmd/dlmgmtd/dlmgmt_door.c
10 lines changed: 7 ins; 0 del; 3 mod; 156 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dlmgmtd/dlmgmt_main.c

usr/src/cmd/dlmgmtd/dlmgmt_door.c
4 lines changed: 2 ins; 0 del; 2 mod; 588 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dlmgmtd/dlmgmt_util.c

usr/src/cmd/dlmgmtd/dlmgmt_door.c
7 lines changed: 2 ins; 0 del; 5 mod; 846 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zoneadmd/vplat.c

usr/src/cmd/dlmgmtd/dlmgmt_door.c
277 lines changed: 172 ins; 59 del; 46 mod; 5374 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/libdlmgmt.c

usr/src/cmd/dlmgmtd/dlmgmt_door.c
17 lines changed: 16 ins; 0 del; 1 mod; 779 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/dls/dls_mgmt.c

usr/src/cmd/dlmgmtd/dlmgmt_door.c
59 lines changed: 44 ins; 7 del; 8 mod; 2043 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.