Print this page
XXXXX update i40e Intel code to 1.12.16
        (includes: Restore 9601 & 13041, fix one header file)

@@ -1,8 +1,8 @@
 /******************************************************************************
 
-  Copyright (c) 2013-2018, Intel Corporation
+  Copyright (c) 2013-2019, Intel Corporation
   All rights reserved.
 
   Redistribution and use in source and binary forms, with or without
   modification, are permitted provided that the following conditions are met:
 

@@ -30,16 +30,18 @@
   POSSIBILITY OF SUCH DAMAGE.
 
 ******************************************************************************/
 /*$FreeBSD$*/
 
+
 #ifndef _VIRTCHNL_H_
 #define _VIRTCHNL_H_
 
 /* Description:
- * This header file describes the VF-PF communication protocol used
- * by the drivers for all devices starting from our 40G product line
+ * This header file describes the Virtual Function (VF) - Physical Function
+ * (PF) communication protocol used by the drivers for all devices starting
+ * from our 40G product line
  *
  * Admin queue buffer usage:
  * desc->opcode is always aqc_opc_send_msg_to_pf
  * flags, retval, datalen, and data addr are all used normally.
  * The Firmware copies the cookie fields when sending messages between the

@@ -49,12 +51,12 @@
  * All the VSI indexes are relative to the VF. Each VF can have maximum of
  * three VSIs. All the queue indexes are relative to the VSI.  Each VF can
  * have a maximum of sixteen queues for all of its VSIs.
  *
  * The PF is required to return a status code in v_retval for all messages
- * except RESET_VF, which does not require any response. The return value
- * is of status_code type, defined in the shared type.h.
+ * except RESET_VF, which does not require any response. The returned value
+ * is of virtchnl_status_code type, defined in the shared type.h.
  *
  * In general, VF driver initialization should roughly follow the order of
  * these opcodes. The VF driver must first validate the API version of the
  * PF driver, then request a reset, then get resources, then configure
  * queues and interrupts. After these operations are complete, the VF

@@ -65,20 +67,27 @@
 /* START GENERIC DEFINES
  * Need to ensure the following enums and defines hold the same meaning and
  * value in current and future projects
  */
 
+
 /* Error Codes */
 enum virtchnl_status_code {
         VIRTCHNL_STATUS_SUCCESS                         = 0,
-        VIRTCHNL_ERR_PARAM                              = -5,
+        VIRTCHNL_STATUS_ERR_PARAM                       = -5,
+        VIRTCHNL_STATUS_ERR_NO_MEMORY                   = -18,
         VIRTCHNL_STATUS_ERR_OPCODE_MISMATCH             = -38,
         VIRTCHNL_STATUS_ERR_CQP_COMPL_ERROR             = -39,
         VIRTCHNL_STATUS_ERR_INVALID_VF_ID               = -40,
-        VIRTCHNL_STATUS_NOT_SUPPORTED                   = -64,
+        VIRTCHNL_STATUS_ERR_ADMIN_QUEUE_ERROR           = -53,
+        VIRTCHNL_STATUS_ERR_NOT_SUPPORTED               = -64,
 };
 
+/* Backward compatibility */
+#define VIRTCHNL_ERR_PARAM VIRTCHNL_STATUS_ERR_PARAM
+#define VIRTCHNL_STATUS_NOT_SUPPORTED VIRTCHNL_STATUS_ERR_NOT_SUPPORTED
+
 #define VIRTCHNL_LINK_SPEED_2_5GB_SHIFT         0x0
 #define VIRTCHNL_LINK_SPEED_100MB_SHIFT         0x1
 #define VIRTCHNL_LINK_SPEED_1000MB_SHIFT        0x2
 #define VIRTCHNL_LINK_SPEED_10GB_SHIFT          0x3
 #define VIRTCHNL_LINK_SPEED_40GB_SHIFT          0x4

@@ -137,10 +146,11 @@
         VIRTCHNL_OP_DEL_VLAN = 13,
         VIRTCHNL_OP_CONFIG_PROMISCUOUS_MODE = 14,
         VIRTCHNL_OP_GET_STATS = 15,
         VIRTCHNL_OP_RSVD = 16,
         VIRTCHNL_OP_EVENT = 17, /* must ALWAYS be 17 */
+        /* opcode 19 is reserved */
         VIRTCHNL_OP_IWARP = 20, /* advanced opcode */
         VIRTCHNL_OP_CONFIG_IWARP_IRQ_MAP = 21, /* advanced opcode */
         VIRTCHNL_OP_RELEASE_IWARP_IRQ_MAP = 22, /* advanced opcode */
         VIRTCHNL_OP_CONFIG_RSS_KEY = 23,
         VIRTCHNL_OP_CONFIG_RSS_LUT = 24,

@@ -147,35 +157,163 @@
         VIRTCHNL_OP_GET_RSS_HENA_CAPS = 25,
         VIRTCHNL_OP_SET_RSS_HENA = 26,
         VIRTCHNL_OP_ENABLE_VLAN_STRIPPING = 27,
         VIRTCHNL_OP_DISABLE_VLAN_STRIPPING = 28,
         VIRTCHNL_OP_REQUEST_QUEUES = 29,
-
+        VIRTCHNL_OP_ENABLE_CHANNELS = 30,
+        VIRTCHNL_OP_DISABLE_CHANNELS = 31,
+        VIRTCHNL_OP_ADD_CLOUD_FILTER = 32,
+        VIRTCHNL_OP_DEL_CLOUD_FILTER = 33,
+        /* opcode 34 is reserved */
+        /* opcodes 38, 39, 40, 41, 42 and 43 are reserved */
+        /* opcode 44 is reserved */
+        /* opcode 45, 46, 47, 48 and 49 are reserved */
+        VIRTCHNL_OP_GET_MAX_RSS_QREGION = 50,
+        VIRTCHNL_OP_GET_OFFLOAD_VLAN_V2_CAPS = 51,
+        VIRTCHNL_OP_ADD_VLAN_V2 = 52,
+        VIRTCHNL_OP_DEL_VLAN_V2 = 53,
+        VIRTCHNL_OP_ENABLE_VLAN_STRIPPING_V2 = 54,
+        VIRTCHNL_OP_DISABLE_VLAN_STRIPPING_V2 = 55,
+        VIRTCHNL_OP_ENABLE_VLAN_INSERTION_V2 = 56,
+        VIRTCHNL_OP_DISABLE_VLAN_INSERTION_V2 = 57,
+        VIRTCHNL_OP_ENABLE_VLAN_FILTERING_V2 = 58,
+        VIRTCHNL_OP_DISABLE_VLAN_FILTERING_V2 = 59,
+        /* opcodes 60 through 69 are reserved */
+        VIRTCHNL_OP_ENABLE_QUEUES_V2 = 107,
+        VIRTCHNL_OP_DISABLE_QUEUES_V2 = 108,
+        VIRTCHNL_OP_MAP_QUEUE_VECTOR = 111,
+        VIRTCHNL_OP_MAX,
 };
 
-/* This macro is used to generate a compilation error if a structure
+static inline const char *virtchnl_op_str(enum virtchnl_ops v_opcode)
+{
+        switch (v_opcode) {
+        case VIRTCHNL_OP_UNKNOWN:
+                return "VIRTCHNL_OP_UNKNOWN";
+        case VIRTCHNL_OP_VERSION:
+                return "VIRTCHNL_OP_VERSION";
+        case VIRTCHNL_OP_RESET_VF:
+                return "VIRTCHNL_OP_RESET_VF";
+        case VIRTCHNL_OP_GET_VF_RESOURCES:
+                return "VIRTCHNL_OP_GET_VF_RESOURCES";
+        case VIRTCHNL_OP_CONFIG_TX_QUEUE:
+                return "VIRTCHNL_OP_CONFIG_TX_QUEUE";
+        case VIRTCHNL_OP_CONFIG_RX_QUEUE:
+                return "VIRTCHNL_OP_CONFIG_RX_QUEUE";
+        case VIRTCHNL_OP_CONFIG_VSI_QUEUES:
+                return "VIRTCHNL_OP_CONFIG_VSI_QUEUES";
+        case VIRTCHNL_OP_CONFIG_IRQ_MAP:
+                return "VIRTCHNL_OP_CONFIG_IRQ_MAP";
+        case VIRTCHNL_OP_ENABLE_QUEUES:
+                return "VIRTCHNL_OP_ENABLE_QUEUES";
+        case VIRTCHNL_OP_DISABLE_QUEUES:
+                return "VIRTCHNL_OP_DISABLE_QUEUES";
+        case VIRTCHNL_OP_ADD_ETH_ADDR:
+                return "VIRTCHNL_OP_ADD_ETH_ADDR";
+        case VIRTCHNL_OP_DEL_ETH_ADDR:
+                return "VIRTCHNL_OP_DEL_ETH_ADDR";
+        case VIRTCHNL_OP_ADD_VLAN:
+                return "VIRTCHNL_OP_ADD_VLAN";
+        case VIRTCHNL_OP_DEL_VLAN:
+                return "VIRTCHNL_OP_DEL_VLAN";
+        case VIRTCHNL_OP_CONFIG_PROMISCUOUS_MODE:
+                return "VIRTCHNL_OP_CONFIG_PROMISCUOUS_MODE";
+        case VIRTCHNL_OP_GET_STATS:
+                return "VIRTCHNL_OP_GET_STATS";
+        case VIRTCHNL_OP_RSVD:
+                return "VIRTCHNL_OP_RSVD";
+        case VIRTCHNL_OP_EVENT:
+                return "VIRTCHNL_OP_EVENT";
+        case VIRTCHNL_OP_IWARP:
+                return "VIRTCHNL_OP_IWARP";
+        case VIRTCHNL_OP_CONFIG_IWARP_IRQ_MAP:
+                return "VIRTCHNL_OP_CONFIG_IWARP_IRQ_MAP:";
+        case VIRTCHNL_OP_RELEASE_IWARP_IRQ_MAP:
+                return "VIRTCHNL_OP_RELEASE_IWARP_IRQ_MAP";
+        case VIRTCHNL_OP_CONFIG_RSS_KEY:
+                return "VIRTCHNL_OP_CONFIG_RSS_KEY";
+        case VIRTCHNL_OP_CONFIG_RSS_LUT:
+                return "VIRTCHNL_OP_CONFIG_RSS_LUT";
+        case VIRTCHNL_OP_GET_RSS_HENA_CAPS:
+                return "VIRTCHNL_OP_GET_RSS_HENA_CAPS";
+        case VIRTCHNL_OP_SET_RSS_HENA:
+                return "VIRTCHNL_OP_SET_RSS_HENA";
+        case VIRTCHNL_OP_ENABLE_VLAN_STRIPPING:
+                return "VIRTCHNL_OP_ENABLE_VLAN_STRIPPING";
+        case VIRTCHNL_OP_DISABLE_VLAN_STRIPPING:
+                return "VIRTCHNL_OP_DISABLE_VLAN_STRIPPING";
+        case VIRTCHNL_OP_REQUEST_QUEUES:
+                return "VIRTCHNL_OP_REQUEST_QUEUES";
+        case VIRTCHNL_OP_ENABLE_CHANNELS:
+                return "VIRTCHNL_OP_ENABLE_CHANNELS";
+        case VIRTCHNL_OP_DISABLE_CHANNELS:
+                return "VIRTCHNL_OP_DISABLE_CHANNELS";
+        case VIRTCHNL_OP_ADD_CLOUD_FILTER:
+                return "VIRTCHNL_OP_ADD_CLOUD_FILTER";
+        case VIRTCHNL_OP_DEL_CLOUD_FILTER:
+                return "VIRTCHNL_OP_DEL_CLOUD_FILTER";
+        case VIRTCHNL_OP_GET_MAX_RSS_QREGION:
+                return "VIRTCHNL_OP_GET_MAX_RSS_QREGION";
+        case VIRTCHNL_OP_ENABLE_QUEUES_V2:
+                return "VIRTCHNL_OP_ENABLE_QUEUES_V2";
+        case VIRTCHNL_OP_DISABLE_QUEUES_V2:
+                return "VIRTCHNL_OP_DISABLE_QUEUES_V2";
+        case VIRTCHNL_OP_MAP_QUEUE_VECTOR:
+                return "VIRTCHNL_OP_MAP_QUEUE_VECTOR";
+        case VIRTCHNL_OP_GET_OFFLOAD_VLAN_V2_CAPS:
+                return "VIRTCHNL_OP_GET_OFFLOAD_VLAN_V2_CAPS";
+        case VIRTCHNL_OP_ADD_VLAN_V2:
+                return "VIRTCHNL_OP_ADD_VLAN_V2";
+        case VIRTCHNL_OP_DEL_VLAN_V2:
+                return "VIRTCHNL_OP_DEL_VLAN_V2";
+        case VIRTCHNL_OP_ENABLE_VLAN_STRIPPING_V2:
+                return "VIRTCHNL_OP_ENABLE_VLAN_STRIPPING_V2";
+        case VIRTCHNL_OP_DISABLE_VLAN_STRIPPING_V2:
+                return "VIRTCHNL_OP_DISABLE_VLAN_STRIPPING_V2";
+        case VIRTCHNL_OP_ENABLE_VLAN_INSERTION_V2:
+                return "VIRTCHNL_OP_ENABLE_VLAN_INSERTION_V2";
+        case VIRTCHNL_OP_DISABLE_VLAN_INSERTION_V2:
+                return "VIRTCHNL_OP_DISABLE_VLAN_INSERTION_V2";
+        case VIRTCHNL_OP_ENABLE_VLAN_FILTERING_V2:
+                return "VIRTCHNL_OP_ENABLE_VLAN_FILTERING_V2";
+        case VIRTCHNL_OP_DISABLE_VLAN_FILTERING_V2:
+                return "VIRTCHNL_OP_DISABLE_VLAN_FILTERING_V2";
+        case VIRTCHNL_OP_MAX:
+                return "VIRTCHNL_OP_MAX";
+        default:
+                return "Unsupported (update virtchnl.h)";
+        }
+}
+
+/* These macros are used to generate compilation errors if a structure/union
  * is not exactly the correct length. It gives a divide by zero error if the
- * structure is not of the correct size, otherwise it creates an enum that is
- * never used.
+ * structure/union is not of the correct size, otherwise it creates an enum
+ * that is never used.
  */
 #define VIRTCHNL_CHECK_STRUCT_LEN(n, X) enum virtchnl_static_assert_enum_##X \
-        {virtchnl_static_assert_##X = (n) / ((sizeof(struct X) == (n)) ? 1 : 0)}
+        { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }
+#define VIRTCHNL_CHECK_UNION_LEN(n, X) enum virtchnl_static_asset_enum_##X \
+        { virtchnl_static_assert_##X = (n)/((sizeof(union X) == (n)) ? 1 : 0) }
 
 /* Virtual channel message descriptor. This overlays the admin queue
  * descriptor. All other data is passed in external buffers.
  */
 
 struct virtchnl_msg {
         u8 pad[8];                       /* AQ flags/opcode/len/retval fields */
-        enum virtchnl_ops v_opcode; /* avoid confusion with desc->opcode */
-        enum virtchnl_status_code v_retval;  /* ditto for desc->retval */
+
+        /* avoid confusion with desc->opcode */
+        enum virtchnl_ops v_opcode;
+
+        /* ditto for desc->retval */
+        enum virtchnl_status_code v_retval;
         u32 vfid;                        /* used by PF when sending to VF */
 };
 
 VIRTCHNL_CHECK_STRUCT_LEN(20, virtchnl_msg);
 
-/* Message descriptions and data structures.*/
+/* Message descriptions and data structures. */
 
 /* VIRTCHNL_OP_VERSION
  * VF posts its version number to the PF. PF responds with its version number
  * in the same format, along with a return code.
  * Reply from PF has its major/minor versions also in param0 and param1.

@@ -187,10 +325,12 @@
  * changes in the API. The PF must always respond to this message without
  * error regardless of version mismatch.
  */
 #define VIRTCHNL_VERSION_MAJOR          1
 #define VIRTCHNL_VERSION_MINOR          1
+#define VIRTCHNL_VERSION_MAJOR_2        2
+#define VIRTCHNL_VERSION_MINOR_0        0
 #define VIRTCHNL_VERSION_MINOR_NO_VF_CAPS       0
 
 struct virtchnl_version_info {
         u32 major;
         u32 minor;

@@ -231,11 +371,13 @@
  */
 
 struct virtchnl_vsi_resource {
         u16 vsi_id;
         u16 num_queue_pairs;
-        enum virtchnl_vsi_type vsi_type;
+
+        /* see enum virtchnl_vsi_type */
+        s32 vsi_type;
         u16 qset_handle;
         u8 default_mac_addr[VIRTCHNL_ETH_LENGTH_OF_ADDRESS];
 };
 
 VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_vsi_resource);

@@ -249,18 +391,32 @@
 #define VIRTCHNL_VF_OFFLOAD_RSVD                0x00000004
 #define VIRTCHNL_VF_OFFLOAD_RSS_AQ              0x00000008
 #define VIRTCHNL_VF_OFFLOAD_RSS_REG             0x00000010
 #define VIRTCHNL_VF_OFFLOAD_WB_ON_ITR           0x00000020
 #define VIRTCHNL_VF_OFFLOAD_REQ_QUEUES          0x00000040
+#define VIRTCHNL_VF_OFFLOAD_CRC                 0x00000080
+        /* 0X00000100 is reserved */
+#define VIRTCHNL_VF_LARGE_NUM_QPAIRS            0x00000200
+#define VIRTCHNL_VF_OFFLOAD_VLAN_V2             0x00008000
 #define VIRTCHNL_VF_OFFLOAD_VLAN                0x00010000
 #define VIRTCHNL_VF_OFFLOAD_RX_POLLING          0x00020000
 #define VIRTCHNL_VF_OFFLOAD_RSS_PCTYPE_V2       0x00040000
 #define VIRTCHNL_VF_OFFLOAD_RSS_PF              0X00080000
 #define VIRTCHNL_VF_OFFLOAD_ENCAP               0X00100000
 #define VIRTCHNL_VF_OFFLOAD_ENCAP_CSUM          0X00200000
 #define VIRTCHNL_VF_OFFLOAD_RX_ENCAP_CSUM       0X00400000
+#define VIRTCHNL_VF_OFFLOAD_ADQ                 0X00800000
+#define VIRTCHNL_VF_OFFLOAD_ADQ_V2              0X01000000
+#define VIRTCHNL_VF_OFFLOAD_USO                 0X02000000
+        /* 0x04000000 is reserved */
+        /* 0X08000000 and 0X10000000 are reserved */
+        /* 0X20000000 is reserved */
+        /* 0X40000000 is reserved */
+        /* 0X80000000 is reserved */
 
+/* Define below the capability flags that are not offloads */
+#define VIRTCHNL_VF_CAP_ADV_LINK_SPEED          0x00000080
 #define VF_BASE_MODE_OFFLOADS (VIRTCHNL_VF_OFFLOAD_L2 | \
                                VIRTCHNL_VF_OFFLOAD_VLAN | \
                                VIRTCHNL_VF_OFFLOAD_RSS_PF)
 
 struct virtchnl_vf_resource {

@@ -297,11 +453,17 @@
 VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_txq_info);
 
 /* VIRTCHNL_OP_CONFIG_RX_QUEUE
  * VF sends this message to set up parameters for one RX queue.
  * External data buffer contains one instance of virtchnl_rxq_info.
- * PF configures requested queue and returns a status code.
+ * PF configures requested queue and returns a status code. The
+ * crc_disable flag disables CRC stripping on the VF. Setting
+ * the crc_disable flag to 1 will disable CRC stripping for each
+ * queue in the VF where the flag is set. The VIRTCHNL_VF_OFFLOAD_CRC
+ * offload must have been set prior to sending this info or the PF
+ * will ignore the request. This flag should be set the same for
+ * all of the queues for a VF.
  */
 
 /* Rx queue config info */
 struct virtchnl_rxq_info {
         u16 vsi_id;

@@ -309,24 +471,30 @@
         u32 ring_len;           /* number of descriptors, multiple of 32 */
         u16 hdr_size;
         u16 splithdr_enabled; /* deprecated with AVF 1.0 */
         u32 databuffer_size;
         u32 max_pkt_size;
-        u32 pad1;
+        u8 crc_disable;
+        u8 pad1[3];
         u64 dma_ring_addr;
-        enum virtchnl_rx_hsplit rx_split_pos; /* deprecated with AVF 1.0 */
+
+        /* see enum virtchnl_rx_hsplit; deprecated with AVF 1.0 */
+        s32 rx_split_pos;
         u32 pad2;
 };
 
 VIRTCHNL_CHECK_STRUCT_LEN(40, virtchnl_rxq_info);
 
 /* VIRTCHNL_OP_CONFIG_VSI_QUEUES
- * VF sends this message to set parameters for all active TX and RX queues
+ * VF sends this message to set parameters for active TX and RX queues
  * associated with the specified VSI.
  * PF configures queues and returns status.
  * If the number of queues specified is greater than the number of queues
  * associated with the VSI, an error is returned and no queues are configured.
+ * NOTE: The VF is not required to configure all queues in a single request.
+ * It may send multiple messages. PF drivers must correctly handle all VF
+ * requests.
  */
 struct virtchnl_queue_pair_info {
         /* NOTE: vsi_id and queue_id should be identical for both queues. */
         struct virtchnl_txq_info txq;
         struct virtchnl_rxq_info rxq;

@@ -347,12 +515,12 @@
  * VF sends this message to request the PF to allocate additional queues to
  * this VF.  Each VF gets a guaranteed number of queues on init but asking for
  * additional queues must be negotiated.  This is a best effort request as it
  * is possible the PF does not have enough queues left to support the request.
  * If the PF cannot support the number requested it will respond with the
- * maximum number it is able to support; otherwise it will respond with the
- * number requested.
+ * maximum number it is able to support.  If the request is successful, PF will
+ * then reset the VF to institute required changes.
  */
 
 /* VF resource request */
 struct virtchnl_vf_res_request {
         u16 num_queue_pairs;

@@ -360,12 +528,17 @@
 
 /* VIRTCHNL_OP_CONFIG_IRQ_MAP
  * VF uses this message to map vectors to queues.
  * The rxq_map and txq_map fields are bitmaps used to indicate which queues
  * are to be associated with the specified vector.
- * The "other" causes are always mapped to vector 0.
+ * The "other" causes are always mapped to vector 0. The VF may not request
+ * that vector 0 be used for traffic.
  * PF configures interrupt mapping and returns status.
+ * NOTE: due to hardware requirements, all active queues (both TX and RX)
+ * should be mapped to interrupts, even if the driver intends to operate
+ * only in polling mode. In this case the interrupt may be disabled, but
+ * the ITR timer will still run to trigger writebacks.
  */
 struct virtchnl_vector_map {
         u16 vsi_id;
         u16 vector_id;
         u16 rxq_map;

@@ -388,10 +561,13 @@
  * VF sends these message to enable or disable TX/RX queue pairs.
  * The queues fields are bitmaps indicating which queues to act upon.
  * (Currently, we only support 16 queues per VF, but we make the field
  * u32 to allow for expansion.)
  * PF performs requested action and returns status.
+ * NOTE: The VF is not required to enable/disable all queues in a single
+ * request. It may send multiple messages.
+ * PF drivers must correctly handle all VF requests.
  */
 struct virtchnl_queue_select {
         u16 vsi_id;
         u16 pad;
         u32 rx_queues;

@@ -398,10 +574,39 @@
         u32 tx_queues;
 };
 
 VIRTCHNL_CHECK_STRUCT_LEN(12, virtchnl_queue_select);
 
+/* VIRTCHNL_OP_GET_MAX_RSS_QREGION
+ *
+ * if VIRTCHNL_VF_LARGE_NUM_QPAIRS was negotiated in VIRTCHNL_OP_GET_VF_RESOURCES
+ * then this op must be supported.
+ *
+ * VF sends this message in order to query the max RSS queue region
+ * size supported by PF, when VIRTCHNL_VF_LARGE_NUM_QPAIRS is enabled.
+ * This information should be used when configuring the RSS LUT and/or
+ * configuring queue region based filters.
+ *
+ * The maximum RSS queue region is 2^qregion_width. So, a qregion_width
+ * of 6 would inform the VF that the PF supports a maximum RSS queue region
+ * of 64.
+ *
+ * A queue region represents a range of queues that can be used to configure
+ * a RSS LUT. For example, if a VF is given 64 queues, but only a max queue
+ * region size of 16 (i.e. 2^qregion_width = 16) then it will only be able
+ * to configure the RSS LUT with queue indices from 0 to 15. However, other
+ * filters can be used to direct packets to queues >15 via specifying a queue
+ * base/offset and queue region width.
+ */
+struct virtchnl_max_rss_qregion {
+        u16 vport_id;
+        u16 qregion_width;
+        u8 pad[4];
+};
+
+VIRTCHNL_CHECK_STRUCT_LEN(8, virtchnl_max_rss_qregion);
+
 /* VIRTCHNL_OP_ADD_ETH_ADDR
  * VF sends this message in order to add one or more unicast or multicast
  * address filters for the specified VSI.
  * PF adds the filters and returns status.
  */

@@ -410,13 +615,40 @@
  * VF sends this message in order to remove one or more unicast or multicast
  * filters for the specified VSI.
  * PF removes the filters and returns status.
  */
 
+/* VIRTCHNL_ETHER_ADDR_LEGACY
+ * Prior to adding the @type member to virtchnl_ether_addr, there were 2 pad
+ * bytes. Moving forward all VF drivers should not set type to
+ * VIRTCHNL_ETHER_ADDR_LEGACY. This is only here to not break previous/legacy
+ * behavior. The control plane function (i.e. PF) can use a best effort method
+ * of tracking the primary/device unicast in this case, but there is no
+ * guarantee and functionality depends on the implementation of the PF.
+ */
+
+/* VIRTCHNL_ETHER_ADDR_PRIMARY
+ * All VF drivers should set @type to VIRTCHNL_ETHER_ADDR_PRIMARY for the
+ * primary/device unicast MAC address filter for VIRTCHNL_OP_ADD_ETH_ADDR and
+ * VIRTCHNL_OP_DEL_ETH_ADDR. This allows for the underlying control plane
+ * function (i.e. PF) to accurately track and use this MAC address for
+ * displaying on the host and for VM/function reset.
+ */
+
+/* VIRTCHNL_ETHER_ADDR_EXTRA
+ * All VF drivers should set @type to VIRTCHNL_ETHER_ADDR_EXTRA for any extra
+ * unicast and/or multicast filters that are being added/deleted via
+ * VIRTCHNL_OP_DEL_ETH_ADDR/VIRTCHNL_OP_ADD_ETH_ADDR respectively.
+ */
 struct virtchnl_ether_addr {
         u8 addr[VIRTCHNL_ETH_LENGTH_OF_ADDRESS];
-        u8 pad[2];
+        u8 type;
+#define VIRTCHNL_ETHER_ADDR_LEGACY      0
+#define VIRTCHNL_ETHER_ADDR_PRIMARY     1
+#define VIRTCHNL_ETHER_ADDR_EXTRA       2
+#define VIRTCHNL_ETHER_ADDR_TYPE_MASK   3 /* first two bits of type are valid */
+        u8 pad;
 };
 
 VIRTCHNL_CHECK_STRUCT_LEN(8, virtchnl_ether_addr);
 
 struct virtchnl_ether_addr_list {

@@ -447,10 +679,392 @@
         u16 vlan_id[1];
 };
 
 VIRTCHNL_CHECK_STRUCT_LEN(6, virtchnl_vlan_filter_list);
 
+/* This enum is used for all of the VIRTCHNL_VF_OFFLOAD_VLAN_V2_CAPS related
+ * structures and opcodes.
+ *
+ * VIRTCHNL_VLAN_UNSUPPORTED - This field is not supported and if a VF driver
+ * populates it the PF should return VIRTCHNL_STATUS_ERR_NOT_SUPPORTED.
+ *
+ * VIRTCHNL_VLAN_ETHERTYPE_8100 - This field supports 0x8100 ethertype.
+ * VIRTCHNL_VLAN_ETHERTYPE_88A8 - This field supports 0x88A8 ethertype.
+ * VIRTCHNL_VLAN_ETHERTYPE_9100 - This field supports 0x9100 ethertype.
+ *
+ * VIRTCHNL_VLAN_ETHERTYPE_AND - Used when multiple ethertypes can be supported
+ * by the PF concurrently. For example, if the PF can support
+ * VIRTCHNL_VLAN_ETHERTYPE_8100 AND VIRTCHNL_VLAN_ETHERTYPE_88A8 filters it
+ * would OR the following bits:
+ *
+ *      VIRTHCNL_VLAN_ETHERTYPE_8100 |
+ *      VIRTCHNL_VLAN_ETHERTYPE_88A8 |
+ *      VIRTCHNL_VLAN_ETHERTYPE_AND;
+ *
+ * The VF would interpret this as VLAN filtering can be supported on both 0x8100
+ * and 0x88A8 VLAN ethertypes.
+ *
+ * VIRTCHNL_ETHERTYPE_XOR - Used when only a single ethertype can be supported
+ * by the PF concurrently. For example if the PF can support
+ * VIRTCHNL_VLAN_ETHERTYPE_8100 XOR VIRTCHNL_VLAN_ETHERTYPE_88A8 stripping
+ * offload it would OR the following bits:
+ *
+ *      VIRTCHNL_VLAN_ETHERTYPE_8100 |
+ *      VIRTCHNL_VLAN_ETHERTYPE_88A8 |
+ *      VIRTCHNL_VLAN_ETHERTYPE_XOR;
+ *
+ * The VF would interpret this as VLAN stripping can be supported on either
+ * 0x8100 or 0x88a8 VLAN ethertypes. So when requesting VLAN stripping via
+ * VIRTCHNL_OP_ENABLE_VLAN_STRIPPING_V2 the specified ethertype will override
+ * the previously set value.
+ *
+ * VIRTCHNL_VLAN_TAG_LOCATION_L2TAG1 - Used to tell the VF to insert and/or
+ * strip the VLAN tag using the L2TAG1 field of the Tx/Rx descriptors.
+ *
+ * VIRTCHNL_VLAN_TAG_LOCATION_L2TAG2 - Used to tell the VF to insert hardware
+ * offloaded VLAN tags using the L2TAG2 field of the Tx descriptor.
+ *
+ * VIRTCHNL_VLAN_TAG_LOCATION_L2TAG2 - Used to tell the VF to strip hardware
+ * offloaded VLAN tags using the L2TAG2_2 field of the Rx descriptor.
+ *
+ * VIRTCHNL_VLAN_PRIO - This field supports VLAN priority bits. This is used for
+ * VLAN filtering if the underlying PF supports it.
+ *
+ * VIRTCHNL_VLAN_TOGGLE_ALLOWED - This field is used to say whether a
+ * certain VLAN capability can be toggled. For example if the underlying PF/CP
+ * allows the VF to toggle VLAN filtering, stripping, and/or insertion it should
+ * set this bit along with the supported ethertypes.
+ */
+enum virtchnl_vlan_support {
+        VIRTCHNL_VLAN_UNSUPPORTED =             0,
+        VIRTCHNL_VLAN_ETHERTYPE_8100 =          0x00000001,
+        VIRTCHNL_VLAN_ETHERTYPE_88A8 =          0x00000002,
+        VIRTCHNL_VLAN_ETHERTYPE_9100 =          0x00000004,
+        VIRTCHNL_VLAN_TAG_LOCATION_L2TAG1 =     0x00000100,
+        VIRTCHNL_VLAN_TAG_LOCATION_L2TAG2 =     0x00000200,
+        VIRTCHNL_VLAN_TAG_LOCATION_L2TAG2_2 =   0x00000400,
+        VIRTCHNL_VLAN_PRIO =                    0x01000000,
+        VIRTCHNL_VLAN_FILTER_MASK =             0x10000000,
+        VIRTCHNL_VLAN_ETHERTYPE_AND =           0x20000000,
+        VIRTCHNL_VLAN_ETHERTYPE_XOR =           0x40000000,
+        VIRTCHNL_VLAN_TOGGLE =                  0x80000000
+};
+
+/* This structure is used as part of the VIRTCHNL_OP_GET_OFFLOAD_VLAN_V2_CAPS
+ * for filtering, insertion, and stripping capabilities.
+ *
+ * If only outer capabilities are supported (for filtering, insertion, and/or
+ * stripping) then this refers to the outer most or single VLAN from the VF's
+ * perspective.
+ *
+ * If only inner capabilities are supported (for filtering, insertion, and/or
+ * stripping) then this refers to the outer most or single VLAN from the VF's
+ * perspective. Functionally this is the same as if only outer capabilities are
+ * supported. The VF driver is just forced to use the inner fields when
+ * adding/deleting filters and enabling/disabling offloads (if supported).
+ *
+ * If both outer and inner capabilities are supported (for filtering, insertion,
+ * and/or stripping) then outer refers to the outer most or single VLAN and
+ * inner refers to the second VLAN, if it exists, in the packet.
+ *
+ * There is no support for tunneled VLAN offloads, so outer or inner are never
+ * referring to a tunneled packet from the VF's perspective.
+ */
+struct virtchnl_vlan_supported_caps {
+        u32 outer;
+        u32 inner;
+};
+
+/* The PF populates these fields based on the supported VLAN filtering. If a
+ * field is VIRTCHNL_VLAN_UNSUPPORTED then it's not supported and the PF will
+ * reject any VIRTCHNL_OP_ADD_VLAN_V2 or VIRTCHNL_OP_DEL_VLAN_V2 messages using
+ * the unsupported fields.
+ *
+ * Also, a VF is only allowed to toggle its VLAN filtering setting if the
+ * VIRTCHNL_VLAN_TOGGLE bit is set.
+ *
+ * The ethertype(s) specified in the ethertype_init field are the ethertypes
+ * enabled for VLAN filtering. VLAN filtering in this case refers to the outer
+ * most VLAN from the VF's perspective. If both inner and outer filtering are
+ * allowed then ethertype_init only refers to the outer most VLAN as only
+ * VLAN ethertype supported for inner VLAN filtering is
+ * VIRTCHNL_VLAN_ETHERTYPE_8100. By default, inner VLAN filtering is disabled
+ * when both inner and outer filtering are allowed.
+ *
+ * The max_filters field tells the VF how many VLAN filters it's allowed to have
+ * at any one time. If it exceeds this amount and tries to add another filter,
+ * then the request will be rejected by the PF. To prevent failures, the VF
+ * should keep track of how many VLAN filters it has added and not attempt to
+ * add more than max_filters.
+ */
+struct virtchnl_vlan_filtering_caps {
+        struct virtchnl_vlan_supported_caps filtering_support;
+        u32 ethertype_init;
+        u16 max_filters;
+        u8 pad[2];
+};
+
+VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_vlan_filtering_caps);
+
+/* This enum is used for the virtchnl_vlan_offload_caps structure to specify
+ * if the PF supports a different ethertype for stripping and insertion.
+ *
+ * VIRTCHNL_ETHERTYPE_STRIPPING_MATCHES_INSERTION - The ethertype(s) specified
+ * for stripping affect the ethertype(s) specified for insertion and visa versa
+ * as well. If the VF tries to configure VLAN stripping via
+ * VIRTCHNL_OP_ENABLE_VLAN_STRIPPING_V2 with VIRTCHNL_VLAN_ETHERTYPE_8100 then
+ * that will be the ethertype for both stripping and insertion.
+ *
+ * VIRTCHNL_ETHERTYPE_MATCH_NOT_REQUIRED - The ethertype(s) specified for
+ * stripping do not affect the ethertype(s) specified for insertion and visa
+ * versa.
+ */
+enum virtchnl_vlan_ethertype_match {
+        VIRTCHNL_ETHERTYPE_STRIPPING_MATCHES_INSERTION = 0,
+        VIRTCHNL_ETHERTYPE_MATCH_NOT_REQUIRED = 1,
+};
+
+/* The PF populates these fields based on the supported VLAN offloads. If a
+ * field is VIRTCHNL_VLAN_UNSUPPORTED then it's not supported and the PF will
+ * reject any VIRTCHNL_OP_ENABLE_VLAN_STRIPPING_V2 or
+ * VIRTCHNL_OP_DISABLE_VLAN_STRIPPING_V2 messages using the unsupported fields.
+ *
+ * Also, a VF is only allowed to toggle its VLAN offload setting if the
+ * VIRTCHNL_VLAN_TOGGLE_ALLOWED bit is set.
+ *
+ * The VF driver needs to be aware of how the tags are stripped by hardware and
+ * inserted by the VF driver based on the level of offload support. The PF will
+ * populate these fields based on where the VLAN tags are expected to be
+ * offloaded via the VIRTHCNL_VLAN_TAG_LOCATION_* bits. The VF will need to
+ * interpret these fields. See the definition of the
+ * VIRTCHNL_VLAN_TAG_LOCATION_* bits above the virtchnl_vlan_support
+ * enumeration.
+ */
+struct virtchnl_vlan_offload_caps {
+        struct virtchnl_vlan_supported_caps stripping_support;
+        struct virtchnl_vlan_supported_caps insertion_support;
+        u32 ethertype_init;
+        u8 ethertype_match;
+        u8 pad[3];
+};
+
+VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_vlan_offload_caps);
+
+/* VIRTCHNL_OP_GET_OFFLOAD_VLAN_V2_CAPS
+ * VF sends this message to determine its VLAN capabilities.
+ *
+ * PF will mark which capabilities it supports based on hardware support and
+ * current configuration. For example, if a port VLAN is configured the PF will
+ * not allow outer VLAN filtering, stripping, or insertion to be configured so
+ * it will block these features from the VF.
+ *
+ * The VF will need to cross reference its capabilities with the PFs
+ * capabilities in the response message from the PF to determine the VLAN
+ * support.
+ */
+struct virtchnl_vlan_caps {
+        struct virtchnl_vlan_filtering_caps filtering;
+        struct virtchnl_vlan_offload_caps offloads;
+};
+
+VIRTCHNL_CHECK_STRUCT_LEN(40, virtchnl_vlan_caps);
+
+struct virtchnl_vlan {
+        u16 tci;        /* tci[15:13] = PCP and tci[11:0] = VID */
+        u16 tci_mask;   /* only valid if VIRTCHNL_VLAN_FILTER_MASK set in
+                         * filtering caps
+                         */
+        u16 tpid;       /* 0x8100, 0x88a8, etc. and only type(s) set in
+                         * filtering caps. Note that tpid here does not refer to
+                         * VIRTCHNL_VLAN_ETHERTYPE_*, but it refers to the
+                         * actual 2-byte VLAN TPID
+                         */
+        u8 pad[2];
+};
+
+VIRTCHNL_CHECK_STRUCT_LEN(8, virtchnl_vlan);
+
+struct virtchnl_vlan_filter {
+        struct virtchnl_vlan inner;
+        struct virtchnl_vlan outer;
+        u8 pad[16];
+};
+
+VIRTCHNL_CHECK_STRUCT_LEN(32, virtchnl_vlan_filter);
+
+/* VIRTCHNL_OP_ADD_VLAN_V2
+ * VIRTCHNL_OP_DEL_VLAN_V2
+ *
+ * VF sends these messages to add/del one or more VLAN tag filters for Rx
+ * traffic.
+ *
+ * The PF attempts to add the filters and returns status.
+ *
+ * The VF should only ever attempt to add/del virtchnl_vlan_filter(s) using the
+ * supported fields negotiated via VIRTCHNL_OP_GET_OFFLOAD_VLAN_V2_CAPS.
+ */
+struct virtchnl_vlan_filter_list_v2 {
+        u16 vport_id;
+        u16 num_elements;
+        u8 pad[4];
+        struct virtchnl_vlan_filter filters[1];
+};
+
+VIRTCHNL_CHECK_STRUCT_LEN(40, virtchnl_vlan_filter_list_v2);
+
+/* VIRTCHNL_OP_ENABLE_VLAN_STRIPPING_V2
+ * VIRTCHNL_OP_DISABLE_VLAN_STRIPPING_V2
+ * VIRTCHNL_OP_ENABLE_VLAN_INSERTION_V2
+ * VIRTCHNL_OP_DISABLE_VLAN_INSERTION_V2
+ *
+ * VF sends this message to enable or disable VLAN stripping or insertion. It
+ * also needs to specify an ethertype. The VF knows which VLAN ethertypes are
+ * allowed and whether or not it's allowed to enable/disable the specific
+ * offload via the VIRTCHNL_OP_GET_OFFLOAD_VLAN_V2_CAPS message. The VF needs to
+ * parse the virtchnl_vlan_caps.offloads fields to determine which offload
+ * messages are allowed.
+ *
+ * For example, if the PF populates the virtchnl_vlan_caps.offloads in the
+ * following manner the VF will be allowed to enable and/or disable 0x8100 inner
+ * VLAN insertion and/or stripping via the opcodes listed above. Inner in this
+ * case means the outer most or single VLAN from the VF's perspective. This is
+ * because no outer offloads are supported. See the comments above the
+ * virtchnl_vlan_supported_caps structure for more details.
+ *
+ * virtchnl_vlan_caps.offloads.stripping_support.inner =
+ *                      VIRTCHNL_VLAN_TOGGLE |
+ *                      VIRTCHNL_VLAN_ETHERTYPE_8100;
+ *
+ * virtchnl_vlan_caps.offloads.insertion_support.inner =
+ *                      VIRTCHNL_VLAN_TOGGLE |
+ *                      VIRTCHNL_VLAN_ETHERTYPE_8100;
+ *
+ * In order to enable inner (again note that in this case inner is the outer
+ * most or single VLAN from the VF's perspective) VLAN stripping for 0x8100
+ * VLANs, the VF would populate the virtchnl_vlan_setting structure in the
+ * following manner and send the VIRTCHNL_OP_ENABLE_VLAN_STRIPPING_V2 message.
+ *
+ * virtchnl_vlan_setting.inner_ethertype_setting =
+ *                      VIRTCHNL_VLAN_ETHERTYPE_8100;
+ *
+ * virtchnl_vlan_setting.vport_id = vport_id or vsi_id assigned to the VF on
+ * initialization.
+ *
+ * The reason that VLAN TPID(s) are not being used for the
+ * outer_ethertype_setting and inner_ethertype_setting fields is because it's
+ * possible a device could support VLAN insertion and/or stripping offload on
+ * multiple ethertypes concurrently, so this method allows a VF to request
+ * multiple ethertypes in one message using the virtchnl_vlan_support
+ * enumeration.
+ *
+ * For example, if the PF populates the virtchnl_vlan_caps.offloads in the
+ * following manner the VF will be allowed to enable 0x8100 and 0x88a8 outer
+ * VLAN insertion and stripping simultaneously. The
+ * virtchnl_vlan_caps.offloads.ethertype_match field will also have to be
+ * populated based on what the PF can support.
+ *
+ * virtchnl_vlan_caps.offloads.stripping_support.outer =
+ *                      VIRTCHNL_VLAN_TOGGLE |
+ *                      VIRTCHNL_VLAN_ETHERTYPE_8100 |
+ *                      VIRTCHNL_VLAN_ETHERTYPE_88A8 |
+ *                      VIRTCHNL_VLAN_ETHERTYPE_AND;
+ *
+ * virtchnl_vlan_caps.offloads.insertion_support.outer =
+ *                      VIRTCHNL_VLAN_TOGGLE |
+ *                      VIRTCHNL_VLAN_ETHERTYPE_8100 |
+ *                      VIRTCHNL_VLAN_ETHERTYPE_88A8 |
+ *                      VIRTCHNL_VLAN_ETHERTYPE_AND;
+ *
+ * In order to enable outer VLAN stripping for 0x8100 and 0x88a8 VLANs, the VF
+ * would populate the virthcnl_vlan_offload_structure in the following manner
+ * and send the VIRTCHNL_OP_ENABLE_VLAN_STRIPPING_V2 message.
+ *
+ * virtchnl_vlan_setting.outer_ethertype_setting =
+ *                      VIRTHCNL_VLAN_ETHERTYPE_8100 |
+ *                      VIRTHCNL_VLAN_ETHERTYPE_88A8;
+ *
+ * virtchnl_vlan_setting.vport_id = vport_id or vsi_id assigned to the VF on
+ * initialization.
+ *
+ * There is also the case where a PF and the underlying hardware can support
+ * VLAN offloads on multiple ethertypes, but not concurrently. For example, if
+ * the PF populates the virtchnl_vlan_caps.offloads in the following manner the
+ * VF will be allowed to enable and/or disable 0x8100 XOR 0x88a8 outer VLAN
+ * offloads. The ethertypes must match for stripping and insertion.
+ *
+ * virtchnl_vlan_caps.offloads.stripping_support.outer =
+ *                      VIRTCHNL_VLAN_TOGGLE |
+ *                      VIRTCHNL_VLAN_ETHERTYPE_8100 |
+ *                      VIRTCHNL_VLAN_ETHERTYPE_88A8 |
+ *                      VIRTCHNL_VLAN_ETHERTYPE_XOR;
+ *
+ * virtchnl_vlan_caps.offloads.insertion_support.outer =
+ *                      VIRTCHNL_VLAN_TOGGLE |
+ *                      VIRTCHNL_VLAN_ETHERTYPE_8100 |
+ *                      VIRTCHNL_VLAN_ETHERTYPE_88A8 |
+ *                      VIRTCHNL_VLAN_ETHERTYPE_XOR;
+ *
+ * virtchnl_vlan_caps.offloads.ethertype_match =
+ *                      VIRTCHNL_ETHERTYPE_STRIPPING_MATCHES_INSERTION;
+ *
+ * In order to enable outer VLAN stripping for 0x88a8 VLANs, the VF would
+ * populate the virtchnl_vlan_setting structure in the following manner and send
+ * the VIRTCHNL_OP_ENABLE_VLAN_STRIPPING_V2. Also, this will change the
+ * ethertype for VLAN insertion if it's enabled. So, for completeness, a
+ * VIRTCHNL_OP_ENABLE_VLAN_INSERTION_V2 with the same ethertype should be sent.
+ *
+ * virtchnl_vlan_setting.outer_ethertype_setting = VIRTHCNL_VLAN_ETHERTYPE_88A8;
+ *
+ * virtchnl_vlan_setting.vport_id = vport_id or vsi_id assigned to the VF on
+ * initialization.
+ *
+ * VIRTCHNL_OP_ENABLE_VLAN_FILTERING_V2
+ * VIRTCHNL_OP_DISABLE_VLAN_FILTERING_V2
+ *
+ * VF sends this message to enable or disable VLAN filtering. It also needs to
+ * specify an ethertype. The VF knows which VLAN ethertypes are allowed and
+ * whether or not it's allowed to enable/disable filtering via the
+ * VIRTCHNL_OP_GET_OFFLOAD_VLAN_V2_CAPS message. The VF needs to
+ * parse the virtchnl_vlan_caps.filtering fields to determine which, if any,
+ * filtering messages are allowed.
+ *
+ * For example, if the PF populates the virtchnl_vlan_caps.filtering in the
+ * following manner the VF will be allowed to enable/disable 0x8100 and 0x88a8
+ * outer VLAN filtering together. Note, that the VIRTCHNL_VLAN_ETHERTYPE_AND
+ * means that all filtering ethertypes will to be enabled and disabled together
+ * regardless of the request from the VF. This means that the underlying
+ * hardware only supports VLAN filtering for all VLAN the specified ethertypes
+ * or none of them.
+ *
+ * virtchnl_vlan_caps.filtering.filtering_support.outer =
+ *                      VIRTCHNL_VLAN_TOGGLE |
+ *                      VIRTCHNL_VLAN_ETHERTYPE_8100 |
+ *                      VIRTHCNL_VLAN_ETHERTYPE_88A8 |
+ *                      VIRTCHNL_VLAN_ETHERTYPE_9100 |
+ *                      VIRTCHNL_VLAN_ETHERTYPE_AND;
+ *
+ * In order to enable outer VLAN filtering for 0x88a8 and 0x8100 VLANs (0x9100
+ * VLANs aren't supported by the VF driver), the VF would populate the
+ * virtchnl_vlan_setting structure in the following manner and send the
+ * VIRTCHNL_OP_ENABLE_VLAN_FILTERING_V2. The same message format would be used
+ * to disable outer VLAN filtering for 0x88a8 and 0x8100 VLANs, but the
+ * VIRTCHNL_OP_DISABLE_VLAN_FILTERING_V2 opcode is used.
+ *
+ * virtchnl_vlan_setting.outer_ethertype_setting =
+ *                      VIRTCHNL_VLAN_ETHERTYPE_8100 |
+ *                      VIRTCHNL_VLAN_ETHERTYPE_88A8;
+ *
+ */
+struct virtchnl_vlan_setting {
+        u32 outer_ethertype_setting;
+        u32 inner_ethertype_setting;
+        u16 vport_id;
+        u8 pad[6];
+};
+
+VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_vlan_setting);
+
 /* VIRTCHNL_OP_CONFIG_PROMISCUOUS_MODE
  * VF sends VSI id and flags.
  * PF returns status code in retval.
  * Note: we assume that broadcast accept mode is always enabled.
  */

@@ -467,13 +1081,28 @@
 /* VIRTCHNL_OP_GET_STATS
  * VF sends this message to request stats for the selected VSI. VF uses
  * the virtchnl_queue_select struct to specify the VSI. The queue_id
  * field is ignored by the PF.
  *
- * PF replies with struct eth_stats in an external buffer.
+ * PF replies with struct virtchnl_eth_stats in an external buffer.
  */
 
+struct virtchnl_eth_stats {
+        u64 rx_bytes;                   /* received bytes */
+        u64 rx_unicast;                 /* received unicast pkts */
+        u64 rx_multicast;               /* received multicast pkts */
+        u64 rx_broadcast;               /* received broadcast pkts */
+        u64 rx_discards;
+        u64 rx_unknown_protocol;
+        u64 tx_bytes;                   /* transmitted bytes */
+        u64 tx_unicast;                 /* transmitted unicast pkts */
+        u64 tx_multicast;               /* transmitted multicast pkts */
+        u64 tx_broadcast;               /* transmitted broadcast pkts */
+        u64 tx_discards;
+        u64 tx_errors;
+};
+
 /* VIRTCHNL_OP_CONFIG_RSS_KEY
  * VIRTCHNL_OP_CONFIG_RSS_LUT
  * VF sends these messages to configure RSS. Only supported if both PF
  * and VF drivers set the VIRTCHNL_VF_OFFLOAD_RSS_PF bit during
  * configuration negotiation. If this is the case, then the RSS fields in

@@ -508,10 +1137,120 @@
         u64 hena;
 };
 
 VIRTCHNL_CHECK_STRUCT_LEN(8, virtchnl_rss_hena);
 
+#if defined(ADV_AVF_SUPPORT) || defined(VIRTCHNL_VER_2_0)
+/* Type of RSS algorithm */
+enum virtchnl_rss_algorithm {
+        VIRTCHNL_RSS_ALG_TOEPLITZ_ASYMMETRIC    = 0,
+        VIRTCHNL_RSS_ALG_R_ASYMMETRIC           = 1,
+        VIRTCHNL_RSS_ALG_TOEPLITZ_SYMMETRIC     = 2,
+        VIRTCHNL_RSS_ALG_XOR_SYMMETRIC          = 3,
+};
+#endif /* ADV_AVF_SUPPORT || VIRTCHNL_VER_2_0 */
+
+/* This is used by PF driver to enforce how many channels can be supported.
+ * When ADQ_V2 capability is negotiated, it will allow 16 channels otherwise
+ * PF driver will allow only max 4 channels
+ */
+#define VIRTCHNL_MAX_ADQ_CHANNELS 4
+#define VIRTCHNL_MAX_ADQ_V2_CHANNELS 16
+
+/* VIRTCHNL_OP_ENABLE_CHANNELS
+ * VIRTCHNL_OP_DISABLE_CHANNELS
+ * VF sends these messages to enable or disable channels based on
+ * the user specified queue count and queue offset for each traffic class.
+ * This struct encompasses all the information that the PF needs from
+ * VF to create a channel.
+ */
+struct virtchnl_channel_info {
+        u16 count; /* number of queues in a channel */
+        u16 offset; /* queues in a channel start from 'offset' */
+        u32 pad;
+        u64 max_tx_rate;
+};
+
+VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_channel_info);
+
+struct virtchnl_tc_info {
+        u32     num_tc;
+        u32     pad;
+        struct  virtchnl_channel_info list[1];
+};
+
+VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_tc_info);
+
+/* VIRTCHNL_ADD_CLOUD_FILTER
+ * VIRTCHNL_DEL_CLOUD_FILTER
+ * VF sends these messages to add or delete a cloud filter based on the
+ * user specified match and action filters. These structures encompass
+ * all the information that the PF needs from the VF to add/delete a
+ * cloud filter.
+ */
+
+struct virtchnl_l4_spec {
+        u8      src_mac[VIRTCHNL_ETH_LENGTH_OF_ADDRESS];
+        u8      dst_mac[VIRTCHNL_ETH_LENGTH_OF_ADDRESS];
+        /* vlan_prio is part of this 16 bit field even from OS perspective
+         * vlan_id:12 is actual vlan_id, then vlanid:bit14..12 is vlan_prio
+         * in future, when decided to offload vlan_prio, pass that information
+         * as part of the "vlan_id" field, Bit14..12
+         */
+        __be16  vlan_id;
+        __be16  pad; /* reserved for future use */
+        __be32  src_ip[4];
+        __be32  dst_ip[4];
+        __be16  src_port;
+        __be16  dst_port;
+};
+
+VIRTCHNL_CHECK_STRUCT_LEN(52, virtchnl_l4_spec);
+
+union virtchnl_flow_spec {
+        struct  virtchnl_l4_spec tcp_spec;
+        u8      buffer[128]; /* reserved for future use */
+};
+
+VIRTCHNL_CHECK_UNION_LEN(128, virtchnl_flow_spec);
+
+enum virtchnl_action {
+        /* action types */
+        VIRTCHNL_ACTION_DROP = 0,
+        VIRTCHNL_ACTION_TC_REDIRECT,
+        VIRTCHNL_ACTION_PASSTHRU,
+        VIRTCHNL_ACTION_QUEUE,
+        VIRTCHNL_ACTION_Q_REGION,
+        VIRTCHNL_ACTION_MARK,
+        VIRTCHNL_ACTION_COUNT,
+};
+
+enum virtchnl_flow_type {
+        /* flow types */
+        VIRTCHNL_TCP_V4_FLOW = 0,
+        VIRTCHNL_TCP_V6_FLOW,
+        VIRTCHNL_UDP_V4_FLOW,
+        VIRTCHNL_UDP_V6_FLOW,
+};
+
+struct virtchnl_filter {
+        union   virtchnl_flow_spec data;
+        union   virtchnl_flow_spec mask;
+
+        /* see enum virtchnl_flow_type */
+        s32     flow_type;
+
+        /* see enum virtchnl_action */
+        s32     action;
+        u32     action_meta;
+        u8      field_flags;
+};
+
+VIRTCHNL_CHECK_STRUCT_LEN(272, virtchnl_filter);
+
+
+
 /* VIRTCHNL_OP_EVENT
  * PF sends this message to inform the VF driver of events that may affect it.
  * No direct response is expected from the VF, though it may generate other
  * messages in response to this one.
  */

@@ -526,19 +1265,45 @@
 #define PF_EVENT_SEVERITY_ATTENTION     1
 #define PF_EVENT_SEVERITY_ACTION_REQUIRED       2
 #define PF_EVENT_SEVERITY_CERTAIN_DOOM  255
 
 struct virtchnl_pf_event {
-        enum virtchnl_event_codes event;
+        /* see enum virtchnl_event_codes */
+        s32 event;
         union {
+                /* If the PF driver does not support the new speed reporting
+                 * capabilities then use link_event else use link_event_adv to
+                 * get the speed and link information. The ability to understand
+                 * new speeds is indicated by setting the capability flag
+                 * VIRTCHNL_VF_CAP_ADV_LINK_SPEED in vf_cap_flags parameter
+                 * in virtchnl_vf_resource struct and can be used to determine
+                 * which link event struct to use below.
+                 */
                 struct {
                         enum virtchnl_link_speed link_speed;
                         bool link_status;
+#ifndef __sun
+                        /* In illumos, sizeof (bool) is 4 bytes, not one. */
+                        u8 pad[3];
+#endif
                 } link_event;
+                struct {
+                        /* link_speed provided in Mbps */
+                        u32 link_speed;
+                        u8 link_status;
+                        u8 pad[3];
+                } link_event_adv;
+                struct {
+                        /* link_speed provided in Mbps */
+                        u32 link_speed;
+                        u16 vport_id;
+                        u8 link_status;
+                        u8 pad;
+                } link_event_adv_vport;
         } event_data;
 
-        int severity;
+        s32 severity;
 };
 
 VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_pf_event);
 
 

@@ -551,18 +1316,10 @@
  * most vectors will have an INVALID_IDX for aeq and valid idx for ceq.
  * There will never be a case where there will be multiple CEQs attached
  * to a single vector.
  * PF configures interrupt mapping and returns status.
  */
-
-/* HW does not define a type value for AEQ; only for RX/TX and CEQ.
- * In order for us to keep the interface simple, SW will define a
- * unique type value for AEQ.
- */
-#define QUEUE_TYPE_PE_AEQ  0x80
-#define QUEUE_INVALID_IDX  0xFFFF
-
 struct virtchnl_iwarp_qv_info {
         u32 v_idx; /* msix_vector */
         u16 ceq_idx;
         u16 aeq_idx;
         u8 itr_idx;

@@ -593,10 +1350,156 @@
         VIRTCHNL_VFR_INPROGRESS = 0,
         VIRTCHNL_VFR_COMPLETED,
         VIRTCHNL_VFR_VFACTIVE,
 };
 
+
+/* TX and RX queue types are valid in legacy as well as split queue models.
+ * With Split Queue model, 2 additional types are introduced - TX_COMPLETION
+ * and RX_BUFFER. In split queue model, RX corresponds to the queue where HW
+ * posts completions.
+ */
+enum virtchnl_queue_type {
+        VIRTCHNL_QUEUE_TYPE_TX                  = 0,
+        VIRTCHNL_QUEUE_TYPE_RX                  = 1,
+        VIRTCHNL_QUEUE_TYPE_TX_COMPLETION       = 2,
+        VIRTCHNL_QUEUE_TYPE_RX_BUFFER           = 3,
+        VIRTCHNL_QUEUE_TYPE_CONFIG_TX           = 4,
+        VIRTCHNL_QUEUE_TYPE_CONFIG_RX           = 5
+};
+
+
+/* structure to specify a chunk of contiguous queues */
+struct virtchnl_queue_chunk {
+        /* see enum virtchnl_queue_type */
+        s32 type;
+        u16 start_queue_id;
+        u16 num_queues;
+};
+
+VIRTCHNL_CHECK_STRUCT_LEN(8, virtchnl_queue_chunk);
+
+/* structure to specify several chunks of contiguous queues */
+struct virtchnl_queue_chunks {
+        u16 num_chunks;
+        u16 rsvd;
+        struct virtchnl_queue_chunk chunks[1];
+};
+
+VIRTCHNL_CHECK_STRUCT_LEN(12, virtchnl_queue_chunks);
+
+
+/* VIRTCHNL_OP_ENABLE_QUEUES_V2
+ * VIRTCHNL_OP_DISABLE_QUEUES_V2
+ * VIRTCHNL_OP_DEL_QUEUES
+ *
+ * If VIRTCHNL version was negotiated in VIRTCHNL_OP_VERSION as 2.0
+ * then all of these ops are available.
+ *
+ * If VIRTCHNL_VF_LARGE_NUM_QPAIRS was negotiated in VIRTCHNL_OP_GET_VF_RESOURCES
+ * then VIRTCHNL_OP_ENABLE_QUEUES_V2 and VIRTCHNL_OP_DISABLE_QUEUES_V2 are
+ * available.
+ *
+ * PF sends these messages to enable, disable or delete queues specified in
+ * chunks. PF sends virtchnl_del_ena_dis_queues struct to specify the queues
+ * to be enabled/disabled/deleted. Also applicable to single queue RX or
+ * TX. CP performs requested action and returns status.
+ */
+struct virtchnl_del_ena_dis_queues {
+        u16 vport_id;
+        u16 pad;
+        struct virtchnl_queue_chunks chunks;
+};
+
+VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_del_ena_dis_queues);
+
+/* Virtchannel interrupt throttling rate index */
+enum virtchnl_itr_idx {
+        VIRTCHNL_ITR_IDX_0      = 0,
+        VIRTCHNL_ITR_IDX_1      = 1,
+        VIRTCHNL_ITR_IDX_NO_ITR = 3,
+};
+
+/* Queue to vector mapping */
+struct virtchnl_queue_vector {
+        u16 queue_id;
+        u16 vector_id;
+        u8 pad[4];
+
+        /* see enum virtchnl_itr_idx */
+        s32 itr_idx;
+
+        /* see enum virtchnl_queue_type */
+        s32 queue_type;
+};
+
+VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_queue_vector);
+
+/* VIRTCHNL_OP_MAP_QUEUE_VECTOR
+ *
+ * If VIRTCHNL_VF_LARGE_NUM_QPAIRS was negotiated in VIRTCHNL_OP_GET_VF_RESOURCES
+ * then only VIRTCHNL_OP_MAP_QUEUE_VECTOR is available.
+ *
+ * PF sends this message to map or unmap queues to vectors and ITR index
+ * registers. External data buffer contains virtchnl_queue_vector_maps structure
+ * that contains num_qv_maps of virtchnl_queue_vector structures.
+ * CP maps the requested queue vector maps after validating the queue and vector
+ * ids and returns a status code.
+ */
+struct virtchnl_queue_vector_maps {
+        u16 vport_id;
+        u16 num_qv_maps;
+        u8 pad[4];
+        struct virtchnl_queue_vector qv_maps[1];
+};
+
+VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_queue_vector_maps);
+
+
+
+/* Since VF messages are limited by u16 size, precalculate the maximum possible
+ * values of nested elements in virtchnl structures that virtual channel can
+ * possibly handle in a single message.
+ */
+enum virtchnl_vector_limits {
+        VIRTCHNL_OP_CONFIG_VSI_QUEUES_MAX       =
+                ((u16)(~0) - sizeof(struct virtchnl_vsi_queue_config_info)) /
+                sizeof(struct virtchnl_queue_pair_info),
+
+        VIRTCHNL_OP_CONFIG_IRQ_MAP_MAX          =
+                ((u16)(~0) - sizeof(struct virtchnl_irq_map_info)) /
+                sizeof(struct virtchnl_vector_map),
+
+        VIRTCHNL_OP_ADD_DEL_ETH_ADDR_MAX        =
+                ((u16)(~0) - sizeof(struct virtchnl_ether_addr_list)) /
+                sizeof(struct virtchnl_ether_addr),
+
+        VIRTCHNL_OP_ADD_DEL_VLAN_MAX            =
+                ((u16)(~0) - sizeof(struct virtchnl_vlan_filter_list)) /
+                sizeof(u16),
+
+        VIRTCHNL_OP_CONFIG_IWARP_IRQ_MAP_MAX    =
+                ((u16)(~0) - sizeof(struct virtchnl_iwarp_qvlist_info)) /
+                sizeof(struct virtchnl_iwarp_qv_info),
+
+        VIRTCHNL_OP_ENABLE_CHANNELS_MAX         =
+                ((u16)(~0) - sizeof(struct virtchnl_tc_info)) /
+                sizeof(struct virtchnl_channel_info),
+
+        VIRTCHNL_OP_ENABLE_DISABLE_DEL_QUEUES_V2_MAX    =
+                ((u16)(~0) - sizeof(struct virtchnl_del_ena_dis_queues)) /
+                sizeof(struct virtchnl_queue_chunk),
+
+        VIRTCHNL_OP_MAP_UNMAP_QUEUE_VECTOR_MAX  =
+                ((u16)(~0) - sizeof(struct virtchnl_queue_vector_maps)) /
+                sizeof(struct virtchnl_queue_vector),
+
+        VIRTCHNL_OP_ADD_DEL_VLAN_V2_MAX         =
+                ((u16)(~0) - sizeof(struct virtchnl_vlan_filter_list_v2)) /
+                sizeof(struct virtchnl_vlan_filter),
+};
+
 /**
  * virtchnl_vc_validate_vf_msg
  * @ver: Virtchnl version info
  * @v_opcode: Opcode for the message
  * @msg: pointer to the msg buffer

@@ -607,11 +1510,11 @@
 static inline int
 virtchnl_vc_validate_vf_msg(struct virtchnl_version_info *ver, u32 v_opcode,
                             u8 *msg, u16 msglen)
 {
         bool err_msg_format = FALSE;
-        int valid_len = 0;
+        u32 valid_len = 0;
 
         /* Validate message length. */
         switch (v_opcode) {
         case VIRTCHNL_OP_VERSION:
                 valid_len = sizeof(struct virtchnl_version_info);

@@ -631,54 +1534,76 @@
         case VIRTCHNL_OP_CONFIG_VSI_QUEUES:
                 valid_len = sizeof(struct virtchnl_vsi_queue_config_info);
                 if (msglen >= valid_len) {
                         struct virtchnl_vsi_queue_config_info *vqc =
                             (struct virtchnl_vsi_queue_config_info *)msg;
+
+                        if (vqc->num_queue_pairs == 0 || vqc->num_queue_pairs >
+                            VIRTCHNL_OP_CONFIG_VSI_QUEUES_MAX) {
+                                err_msg_format = TRUE;
+                                break;
+                        }
+
                         valid_len += (vqc->num_queue_pairs *
                                       sizeof(struct
                                              virtchnl_queue_pair_info));
-                        if (vqc->num_queue_pairs == 0)
-                                err_msg_format = TRUE;
                 }
                 break;
         case VIRTCHNL_OP_CONFIG_IRQ_MAP:
                 valid_len = sizeof(struct virtchnl_irq_map_info);
                 if (msglen >= valid_len) {
                         struct virtchnl_irq_map_info *vimi =
                             (struct virtchnl_irq_map_info *)msg;
+
+                        if (vimi->num_vectors == 0 || vimi->num_vectors >
+                            VIRTCHNL_OP_CONFIG_IRQ_MAP_MAX) {
+                                err_msg_format = TRUE;
+                                break;
+                        }
+
                         valid_len += (vimi->num_vectors *
                                       sizeof(struct virtchnl_vector_map));
-                        if (vimi->num_vectors == 0)
-                                err_msg_format = TRUE;
                 }
                 break;
         case VIRTCHNL_OP_ENABLE_QUEUES:
         case VIRTCHNL_OP_DISABLE_QUEUES:
                 valid_len = sizeof(struct virtchnl_queue_select);
                 break;
+        case VIRTCHNL_OP_GET_MAX_RSS_QREGION:
+                break;
         case VIRTCHNL_OP_ADD_ETH_ADDR:
         case VIRTCHNL_OP_DEL_ETH_ADDR:
                 valid_len = sizeof(struct virtchnl_ether_addr_list);
                 if (msglen >= valid_len) {
                         struct virtchnl_ether_addr_list *veal =
                             (struct virtchnl_ether_addr_list *)msg;
+
+                        if (veal->num_elements == 0 || veal->num_elements >
+                            VIRTCHNL_OP_ADD_DEL_ETH_ADDR_MAX) {
+                                err_msg_format = TRUE;
+                                break;
+                        }
+
                         valid_len += veal->num_elements *
                             sizeof(struct virtchnl_ether_addr);
-                        if (veal->num_elements == 0)
-                                err_msg_format = TRUE;
                 }
                 break;
         case VIRTCHNL_OP_ADD_VLAN:
         case VIRTCHNL_OP_DEL_VLAN:
                 valid_len = sizeof(struct virtchnl_vlan_filter_list);
                 if (msglen >= valid_len) {
                         struct virtchnl_vlan_filter_list *vfl =
                             (struct virtchnl_vlan_filter_list *)msg;
-                        valid_len += vfl->num_elements * sizeof(u16);
-                        if (vfl->num_elements == 0)
+
+                        if (vfl->num_elements == 0 || vfl->num_elements >
+                            VIRTCHNL_OP_ADD_DEL_VLAN_MAX) {
                                 err_msg_format = TRUE;
+                                break;
                 }
+
+                        valid_len += vfl->num_elements * sizeof(u16);
+                }
                 break;
         case VIRTCHNL_OP_CONFIG_PROMISCUOUS_MODE:
                 valid_len = sizeof(struct virtchnl_promisc_info);
                 break;
         case VIRTCHNL_OP_GET_STATS:

@@ -699,31 +1624,46 @@
         case VIRTCHNL_OP_CONFIG_IWARP_IRQ_MAP:
                 valid_len = sizeof(struct virtchnl_iwarp_qvlist_info);
                 if (msglen >= valid_len) {
                         struct virtchnl_iwarp_qvlist_info *qv =
                                 (struct virtchnl_iwarp_qvlist_info *)msg;
-                        if (qv->num_vectors == 0) {
+
+                        if (qv->num_vectors == 0 || qv->num_vectors >
+                            VIRTCHNL_OP_CONFIG_IWARP_IRQ_MAP_MAX) {
                                 err_msg_format = TRUE;
                                 break;
                         }
+
                         valid_len += ((qv->num_vectors - 1) *
                                 sizeof(struct virtchnl_iwarp_qv_info));
                 }
                 break;
         case VIRTCHNL_OP_CONFIG_RSS_KEY:
                 valid_len = sizeof(struct virtchnl_rss_key);
                 if (msglen >= valid_len) {
                         struct virtchnl_rss_key *vrk =
                                 (struct virtchnl_rss_key *)msg;
+
+                        if (vrk->key_len == 0) {
+                                /* zero length is allowed as input */
+                                break;
+                        }
+
                         valid_len += vrk->key_len - 1;
                 }
                 break;
         case VIRTCHNL_OP_CONFIG_RSS_LUT:
                 valid_len = sizeof(struct virtchnl_rss_lut);
                 if (msglen >= valid_len) {
                         struct virtchnl_rss_lut *vrl =
                                 (struct virtchnl_rss_lut *)msg;
+
+                        if (vrl->lut_entries == 0) {
+                                /* zero entries is allowed as input */
+                                break;
+                        }
+
                         valid_len += vrl->lut_entries - 1;
                 }
                 break;
         case VIRTCHNL_OP_GET_RSS_HENA_CAPS:
                 break;

@@ -734,15 +1674,93 @@
         case VIRTCHNL_OP_DISABLE_VLAN_STRIPPING:
                 break;
         case VIRTCHNL_OP_REQUEST_QUEUES:
                 valid_len = sizeof(struct virtchnl_vf_res_request);
                 break;
+        case VIRTCHNL_OP_ENABLE_CHANNELS:
+                valid_len = sizeof(struct virtchnl_tc_info);
+                if (msglen >= valid_len) {
+                        struct virtchnl_tc_info *vti =
+                                (struct virtchnl_tc_info *)msg;
+
+                        if (vti->num_tc == 0 || vti->num_tc >
+                            VIRTCHNL_OP_ENABLE_CHANNELS_MAX) {
+                                err_msg_format = TRUE;
+                                break;
+                        }
+
+                        valid_len += (vti->num_tc - 1) *
+                                     sizeof(struct virtchnl_channel_info);
+                }
+                break;
+        case VIRTCHNL_OP_DISABLE_CHANNELS:
+                break;
+        case VIRTCHNL_OP_ADD_CLOUD_FILTER:
+        case VIRTCHNL_OP_DEL_CLOUD_FILTER:
+                valid_len = sizeof(struct virtchnl_filter);
+                break;
+        case VIRTCHNL_OP_GET_OFFLOAD_VLAN_V2_CAPS:
+                break;
+        case VIRTCHNL_OP_ADD_VLAN_V2:
+        case VIRTCHNL_OP_DEL_VLAN_V2:
+                valid_len = sizeof(struct virtchnl_vlan_filter_list_v2);
+                if (msglen >= valid_len) {
+                        struct virtchnl_vlan_filter_list_v2 *vfl =
+                            (struct virtchnl_vlan_filter_list_v2 *)msg;
+
+                        if (vfl->num_elements == 0 || vfl->num_elements >
+                            VIRTCHNL_OP_ADD_DEL_VLAN_V2_MAX) {
+                                err_msg_format = TRUE;
+                                break;
+                        }
+
+                        valid_len += (vfl->num_elements - 1) *
+                                sizeof(struct virtchnl_vlan_filter);
+                }
+                break;
+        case VIRTCHNL_OP_ENABLE_VLAN_STRIPPING_V2:
+        case VIRTCHNL_OP_DISABLE_VLAN_STRIPPING_V2:
+        case VIRTCHNL_OP_ENABLE_VLAN_INSERTION_V2:
+        case VIRTCHNL_OP_DISABLE_VLAN_INSERTION_V2:
+        case VIRTCHNL_OP_ENABLE_VLAN_FILTERING_V2:
+        case VIRTCHNL_OP_DISABLE_VLAN_FILTERING_V2:
+                valid_len = sizeof(struct virtchnl_vlan_setting);
+                break;
+        case VIRTCHNL_OP_ENABLE_QUEUES_V2:
+        case VIRTCHNL_OP_DISABLE_QUEUES_V2:
+                valid_len = sizeof(struct virtchnl_del_ena_dis_queues);
+                if (msglen >= valid_len) {
+                        struct virtchnl_del_ena_dis_queues *qs =
+                                (struct virtchnl_del_ena_dis_queues *)msg;
+                        if (qs->chunks.num_chunks == 0 ||
+                            qs->chunks.num_chunks > VIRTCHNL_OP_ENABLE_DISABLE_DEL_QUEUES_V2_MAX) {
+                                err_msg_format = TRUE;
+                                break;
+                        }
+                        valid_len += (qs->chunks.num_chunks - 1) *
+                                      sizeof(struct virtchnl_queue_chunk);
+                }
+                break;
+        case VIRTCHNL_OP_MAP_QUEUE_VECTOR:
+                valid_len = sizeof(struct virtchnl_queue_vector_maps);
+                if (msglen >= valid_len) {
+                        struct virtchnl_queue_vector_maps *v_qp =
+                                (struct virtchnl_queue_vector_maps *)msg;
+                        if (v_qp->num_qv_maps == 0 ||
+                            v_qp->num_qv_maps > VIRTCHNL_OP_MAP_UNMAP_QUEUE_VECTOR_MAX) {
+                                err_msg_format = TRUE;
+                                break;
+                        }
+                        valid_len += (v_qp->num_qv_maps - 1) *
+                                      sizeof(struct virtchnl_queue_vector);
+                }
+                break;
         /* These are always errors coming from the VF. */
         case VIRTCHNL_OP_EVENT:
         case VIRTCHNL_OP_UNKNOWN:
         default:
-                return VIRTCHNL_ERR_PARAM;
+                return VIRTCHNL_STATUS_ERR_PARAM;
         }
         /* few more checks */
         if (err_msg_format || valid_len != msglen)
                 return VIRTCHNL_STATUS_ERR_OPCODE_MISMATCH;