Print this page
NEX-6096 Enable compile warnings re. parentheses in smbsrv
Reviewed by: Matt Barden <matt.barden@nexenta.com>
Reviewed by: Rick McNeal <rick.mcneal@nexenta.com>
Reviewed by: Josef 'Jeff' Sipek <josef.sipek@nexenta.com>
Reviewed by: Evan Layton <evan.layton@nexenta.com>
Reviewed by: Jean McCormack <jean.mccormack@nexenta.com>
OS-139 POSIX write should imply DELETE_CHILD on directories - and some additional considerations
SMB-50 User-mode SMB server
 Includes work by these authors:
 Thomas Keiser <thomas.keiser@nexenta.com>
 Albert Lee <trisk@nexenta.com>

Split Close
Expand all
Collapse all
          --- old/usr/src/common/acl/acl_common.c
          +++ new/usr/src/common/acl/acl_common.c
↓ open down ↓ 1687 lines elided ↑ open up ↑
1688 1688  int
1689 1689  ace_trivial_common(void *acep, int aclcnt,
1690 1690      uint64_t (*walk)(void *, uint64_t, int aclcnt,
1691 1691      uint16_t *, uint16_t *, uint32_t *))
1692 1692  {
1693 1693          uint16_t flags;
1694 1694          uint32_t mask;
1695 1695          uint16_t type;
1696 1696          uint64_t cookie = 0;
1697 1697  
1698      -        while (cookie = walk(acep, cookie, aclcnt, &flags, &type, &mask)) {
     1698 +        while ((cookie = walk(acep, cookie, aclcnt, &flags, &type, &mask))
     1699 +            != NULL) {
1699 1700                  switch (flags & ACE_TYPE_FLAGS) {
1700 1701                  case ACE_OWNER:
1701 1702                  case ACE_GROUP|ACE_IDENTIFIER_GROUP:
1702 1703                  case ACE_EVERYONE:
1703 1704                          break;
1704 1705                  default:
1705 1706                          return (1);
1706 1707  
1707 1708                  }
1708 1709  
↓ open down ↓ 62 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX