Print this page
NEX-6096 Enable compile warnings re. parentheses in smbsrv
Reviewed by: Matt Barden <matt.barden@nexenta.com>
Reviewed by: Rick McNeal <rick.mcneal@nexenta.com>
Reviewed by: Josef 'Jeff' Sipek <josef.sipek@nexenta.com>
Reviewed by: Evan Layton <evan.layton@nexenta.com>
Reviewed by: Jean McCormack <jean.mccormack@nexenta.com>
OS-139 POSIX write should imply DELETE_CHILD on directories - and some additional considerations
SMB-50 User-mode SMB server
 Includes work by these authors:
 Thomas Keiser <thomas.keiser@nexenta.com>
 Albert Lee <trisk@nexenta.com>

@@ -1693,11 +1693,12 @@
         uint16_t flags;
         uint32_t mask;
         uint16_t type;
         uint64_t cookie = 0;
 
-        while (cookie = walk(acep, cookie, aclcnt, &flags, &type, &mask)) {
+        while ((cookie = walk(acep, cookie, aclcnt, &flags, &type, &mask))
+            != NULL) {
                 switch (flags & ACE_TYPE_FLAGS) {
                 case ACE_OWNER:
                 case ACE_GROUP|ACE_IDENTIFIER_GROUP:
                 case ACE_EVERYONE:
                         break;