Print this page
NEX-2911 NDMP logging should use syslog and is too chatty
        
*** 34,43 ****
--- 34,44 ----
   * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
   * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
   * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
   * POSSIBILITY OF SUCH DAMAGE.
   */
+ #include <syslog.h>
  #include <stdlib.h>
  #include "tlm.h"
  #include "tlm_proto.h"
  #include <sys/errno.h>
  
*** 201,211 ****
                          (void) mutex_unlock(&jstat_mtx);
                          return (job_stats);
                  }
                  link = link->tc_next;
          } while (link != tlm_info.ti_job_stats);
!         NDMP_LOG(LOG_DEBUG,
              "TAPE BACKUP> Ref for job [%s] was not found", name);
          (void) mutex_unlock(&jstat_mtx);
  
          return (&fake_job_stats);
  }
--- 202,212 ----
                          (void) mutex_unlock(&jstat_mtx);
                          return (job_stats);
                  }
                  link = link->tc_next;
          } while (link != tlm_info.ti_job_stats);
!         syslog(LOG_DEBUG,
              "TAPE BACKUP> Ref for job [%s] was not found", name);
          (void) mutex_unlock(&jstat_mtx);
  
          return (&fake_job_stats);
  }
*** 219,229 ****
          tlm_chain_link_t *link;
  
          (void) mutex_lock(&jstat_mtx);
          link = tlm_info.ti_job_stats;
          if (link == 0) {
!                 NDMP_LOG(LOG_DEBUG, "TAPE BACKUP>"
                      " Internal error for job [%s], could not delete", name);
                  return;
          }
          do {
                  tlm_job_stats_t *job_stats;
--- 220,230 ----
          tlm_chain_link_t *link;
  
          (void) mutex_lock(&jstat_mtx);
          link = tlm_info.ti_job_stats;
          if (link == 0) {
!                 syslog(LOG_DEBUG, "TAPE BACKUP>"
                      " Internal error for job [%s], could not delete", name);
                  return;
          }
          do {
                  tlm_job_stats_t *job_stats;
*** 236,246 ****
                          return;
                  }
                  link = link->tc_next;
          } while (link != tlm_info.ti_job_stats);
          (void) mutex_unlock(&jstat_mtx);
!         NDMP_LOG(LOG_DEBUG,
              "TAPE BACKUP> Delete for job [%s] was not found", name);
  }
  
  /*
   * one party does not care about this blob, can we let it go?
--- 237,247 ----
                          return;
                  }
                  link = link->tc_next;
          } while (link != tlm_info.ti_job_stats);
          (void) mutex_unlock(&jstat_mtx);
!         syslog(LOG_DEBUG,
              "TAPE BACKUP> Delete for job [%s] was not found", name);
  }
  
  /*
   * one party does not care about this blob, can we let it go?
*** 303,313 ****
                          free(link);
                          return (new_top);
                  }
                  chain_link = chain_link->tc_next;
          } while (chain_link != old_top);
!         NDMP_LOG(LOG_DEBUG, "TAPE BACKUP> un_ref target not found.");
          return (old_top);
  }
  
  /*
   * the following section is global, but not really part of the
--- 304,314 ----
                          free(link);
                          return (new_top);
                  }
                  chain_link = chain_link->tc_next;
          } while (chain_link != old_top);
!         syslog(LOG_DEBUG, "TAPE BACKUP> un_ref target not found.");
          return (old_top);
  }
  
  /*
   * the following section is global, but not really part of the