Code Review for OS-7667

Prepared by:Dan McDonald on 2019-May-21 15:45 -0400 EDT
Workspace:/home/danmcd/smartos-live/projects/illumos (at 19ae9b7be870)
Compare against: origin/master (https://github.com/joyent/illumos-joyent.git at 3a1da6de2a21)
Summary of changes: 1001 lines changed: 973 ins; 3 del; 25 mod; 49716 unchg
Patch of changes: OS-7667.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw manifest

OS-7667 IPFilter needs to keep and report state for cloud firewall logging
Portions contributed by: Mike Gerdts <mike.gerdts@joyent.com>
1 line changed: 1 ins; 0 del; 0 mod; 21051 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/devfsadm/misc_link.c

OS-7667 IPFilter needs to keep and report state for cloud firewall logging
Portions contributed by: Mike Gerdts <mike.gerdts@joyent.com>
2 lines changed: 0 ins; 0 del; 2 mod; 758 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ipf/lib/common/printfr.c

OS-7667 IPFilter needs to keep and report state for cloud firewall logging
Portions contributed by: Mike Gerdts <mike.gerdts@joyent.com>
16 lines changed: 14 ins; 0 del; 2 mod; 404 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ipf/tools/Makefile.tools

OS-7667 IPFilter needs to keep and report state for cloud firewall logging
Portions contributed by: Mike Gerdts <mike.gerdts@joyent.com>
3 lines changed: 0 ins; 0 del; 3 mod; 268 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ipf/tools/ipf_y.y

OS-7667 IPFilter needs to keep and report state for cloud firewall logging
Portions contributed by: Mike Gerdts <mike.gerdts@joyent.com>
17 lines changed: 17 ins; 0 del; 0 mod; 2326 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ipf/tools/ipmon_y.y

OS-7667 IPFilter needs to keep and report state for cloud firewall logging
Portions contributed by: Mike Gerdts <mike.gerdts@joyent.com>
5 lines changed: 5 ins; 0 del; 0 mod; 700 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ipf/tools/ipnat_y.y

OS-7667 IPFilter needs to keep and report state for cloud firewall logging
Portions contributed by: Mike Gerdts <mike.gerdts@joyent.com>
4 lines changed: 4 ins; 0 del; 0 mod; 1040 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ipf/tools/ippool_y.y

OS-7667 IPFilter needs to keep and report state for cloud firewall logging
Portions contributed by: Mike Gerdts <mike.gerdts@joyent.com>
4 lines changed: 4 ins; 0 del; 0 mod; 485 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ipf/tools/lexer.c

OS-7667 IPFilter needs to keep and report state for cloud firewall logging
Portions contributed by: Mike Gerdts <mike.gerdts@joyent.com>
36 lines changed: 36 ins; 0 del; 0 mod; 677 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ipf/tools/lexer.h

OS-7667 IPFilter needs to keep and report state for cloud firewall logging
Portions contributed by: Mike Gerdts <mike.gerdts@joyent.com>
4 lines changed: 3 ins; 0 del; 1 mod; 34 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/Makefile.files

OS-7667 IPFilter needs to keep and report state for cloud firewall logging
Portions contributed by: Mike Gerdts <mike.gerdts@joyent.com>
2 lines changed: 0 ins; 0 del; 2 mod; 2286 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/ipf/cfw.c

OS-7667 IPFilter needs to keep and report state for cloud firewall logging
Portions contributed by: Mike Gerdts <mike.gerdts@joyent.com>
689 lines changed: 689 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ipf/fil.c

OS-7667 IPFilter needs to keep and report state for cloud firewall logging
Portions contributed by: Mike Gerdts <mike.gerdts@joyent.com>
4 lines changed: 3 ins; 0 del; 1 mod; 7737 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ipf/ip_fil_solaris.c

OS-7667 IPFilter needs to keep and report state for cloud firewall logging
Portions contributed by: Mike Gerdts <mike.gerdts@joyent.com>
36 lines changed: 35 ins; 0 del; 1 mod; 3477 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ipf/ip_log.c

OS-7667 IPFilter needs to keep and report state for cloud firewall logging
Portions contributed by: Mike Gerdts <mike.gerdts@joyent.com>
2 lines changed: 1 ins; 0 del; 1 mod; 700 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ipf/ip_state.c

OS-7667 IPFilter needs to keep and report state for cloud firewall logging
Portions contributed by: Mike Gerdts <mike.gerdts@joyent.com>
18 lines changed: 15 ins; 1 del; 2 mod; 4443 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ipf/netinet/Makefile

OS-7667 IPFilter needs to keep and report state for cloud firewall logging
Portions contributed by: Mike Gerdts <mike.gerdts@joyent.com>
5 lines changed: 1 ins; 2 del; 2 mod; 29 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ipf/netinet/ip_fil.h

OS-7667 IPFilter needs to keep and report state for cloud firewall logging
Portions contributed by: Mike Gerdts <mike.gerdts@joyent.com>
45 lines changed: 42 ins; 0 del; 3 mod; 1618 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ipf/netinet/ip_state.h

OS-7667 IPFilter needs to keep and report state for cloud firewall logging
Portions contributed by: Mike Gerdts <mike.gerdts@joyent.com>
4 lines changed: 4 ins; 0 del; 0 mod; 253 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/ipf/netinet/ipf_cfw.h

OS-7667 IPFilter needs to keep and report state for cloud firewall logging
Portions contributed by: Mike Gerdts <mike.gerdts@joyent.com>
66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ipf/netinet/ipf_stack.h

OS-7667 IPFilter needs to keep and report state for cloud firewall logging
Portions contributed by: Mike Gerdts <mike.gerdts@joyent.com>
3 lines changed: 2 ins; 0 del; 1 mod; 324 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ipf/solaris.c

OS-7667 IPFilter needs to keep and report state for cloud firewall logging
Portions contributed by: Mike Gerdts <mike.gerdts@joyent.com>
7 lines changed: 5 ins; 0 del; 2 mod; 913 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/ipf/ipf.global-objs.debug64

OS-7667 IPFilter needs to keep and report state for cloud firewall logging
Portions contributed by: Mike Gerdts <mike.gerdts@joyent.com>
14 lines changed: 13 ins; 0 del; 1 mod; 102 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/ipf/ipf.global-objs.debug64

OS-7667 IPFilter needs to keep and report state for cloud firewall logging
Portions contributed by: Mike Gerdts <mike.gerdts@joyent.com>
14 lines changed: 13 ins; 0 del; 1 mod; 91 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.