Print this page
8903 IPPF paths have bad logic
Reviewed by: Dan McDonald <danmcd@joyent.com>
Reviewed by: John Levon <levon@movementarian.org>
Reviewed by: Gergő Doma <domag02@gmail.com>
| Split |
Close |
| Expand all |
| Collapse all |
--- old/usr/src/uts/intel/ip/Makefile
+++ new/usr/src/uts/intel/ip/Makefile
1 1 #
2 2 # CDDL HEADER START
3 3 #
4 4 # The contents of this file are subject to the terms of the
5 5 # Common Development and Distribution License (the "License").
6 6 # You may not use this file except in compliance with the License.
7 7 #
8 8 # You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
9 9 # or http://www.opensolaris.org/os/licensing.
10 10 # See the License for the specific language governing permissions
11 11 # and limitations under the License.
12 12 #
13 13 # When distributing Covered Code, include this CDDL HEADER in each
14 14 # file and include the License file at usr/src/OPENSOLARIS.LICENSE.
15 15 # If applicable, add the following below this CDDL HEADER, with the
16 16 # fields enclosed by brackets "[]" replaced with your own identifying
17 17 # information: Portions Copyright [yyyy] [name of copyright owner]
18 18 #
19 19 # CDDL HEADER END
20 20 #
21 21 #
22 22 # Copyright 2009 Sun Microsystems, Inc. All rights reserved.
23 23 # Use is subject to license terms.
24 24 #
25 25 # Copyright (c) 2018, Joyent, Inc.
26 26 #
27 27 # This makefile drives the production of the ip driver
28 28 # kernel module.
29 29 #
30 30 # intel implementation architecture dependent
31 31 #
32 32
33 33 #
34 34 # Path to the base of the uts directory tree (usually /usr/src/uts).
35 35 #
36 36 UTSBASE = ../..
37 37
38 38 #
39 39 # Define the module and object file sets.
40 40 #
41 41 MODULE = ip
42 42 OBJECTS = $(IP_OBJS:%=$(OBJS_DIR)/%)
43 43 LINTS = $(IP_OBJS:%.o=$(LINTS_DIR)/%.ln)
44 44 ROOTMODULE = $(ROOT_DRV_DIR)/$(MODULE)
45 45 ROOTLINK = $(ROOT_STRMOD_DIR)/$(MODULE)
46 46 CONF_SRCDIR = $(UTSBASE)/common/inet/ip
47 47
48 48 #
49 49 # Include common rules.
50 50 #
51 51 include $(UTSBASE)/intel/Makefile.intel
52 52
53 53 #
54 54 # Define targets
55 55 #
56 56 ALL_TARGET = $(BINARY) $(SRC_CONFILE)
57 57 LINT_TARGET = $(MODULE).lint
58 58 INSTALL_TARGET = $(BINARY) $(ROOTMODULE) $(ROOTLINK) $(ROOT_CONFFILE)
59 59
60 60 CINLINEFLAGS = -xinline=tcp_set_ws_value
61 61
62 62 CFLAGS += $(CINLINEFLAGS)
63 63
64 64 CERRWARN += -_gcc=-Wno-parentheses
65 65 CERRWARN += -_gcc=-Wno-unused-label
66 66 CERRWARN += -_gcc=-Wno-unused-function
67 67 CERRWARN += -_gcc=-Wno-unused-variable
68 68 CERRWARN += -_gcc=-Wno-switch
69 69 CERRWARN += -_gcc=-Wno-uninitialized
70 70 CERRWARN += -_gcc=-Wno-type-limits
|
↓ open down ↓ |
70 lines elided |
↑ open up ↑ |
71 71
72 72 # false positives
73 73 SMOFF += index_overflow
74 74
75 75 # need work still
76 76 $(OBJS_DIR)/igmp.o := SMOFF += shift_to_zero
77 77 $(OBJS_DIR)/tnet.o := SMOFF += shift_to_zero
78 78 SMOFF += signed,all_func_returns
79 79 SMOFF += signed_integer_overflow_check
80 80
81 -# definitely wrong
82 -$(OBJS_DIR)/ip_input.o := SMOFF += or_vs_and
83 -$(OBJS_DIR)/ip6_input.o := SMOFF += or_vs_and
84 -
85 81 #
86 82 # To get the BPF header files included by ipnet.h
87 83 #
88 84 INC_PATH += -I$(UTSBASE)/common/io/bpf
89 85
90 86 #
91 87 # Depends on md5 and swrand (for SCTP). SCTP needs to depend on
92 88 # swrand as it needs random numbers early on during boot before
93 89 # kCF subsystem can load swrand.
94 90 #
95 91 LDFLAGS += -dy -Nmisc/md5 -Ncrypto/swrand -Nmisc/hook -Nmisc/neti
96 92
97 93 #
98 94 # For now, disable these lint checks; maintainers should endeavor
99 95 # to investigate and remove these for maximum lint coverage.
100 96 # Please do not carry these forward to new Makefiles.
101 97 #
102 98 LINTTAGS += -erroff=E_SUSPICIOUS_COMPARISON
103 99 LINTTAGS += -erroff=E_BAD_PTR_CAST_ALIGN
104 100 LINTTAGS += -erroff=E_SUPPRESSION_DIRECTIVE_UNUSED
105 101 LINTTAGS += -erroff=E_STATIC_UNUSED
106 102 LINTTAGS += -erroff=E_PTRDIFF_OVERFLOW
107 103 LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV
108 104
109 105 #
110 106 # Default build targets.
111 107 #
112 108 .KEEP_STATE:
113 109
114 110 def: $(DEF_DEPS)
115 111
116 112 all: $(ALL_DEPS) $(SISCHECK_DEPS)
117 113
118 114 clean: $(CLEAN_DEPS) $(SISCLEAN_DEPS)
119 115
120 116 # Need to clobber all build types due to ipctf.a
121 117 clobber: $(CLOBBER_DEPS) $(SISCLEAN_DEPS) \
122 118 clobber.obj64 clobber.debug64
123 119
124 120 lint: $(LINT_DEPS)
125 121
126 122 modlintlib: $(MODLINTLIB_DEPS)
127 123
128 124 clean.lint: $(CLEAN_LINT_DEPS)
129 125
130 126 install: $(INSTALL_DEPS) $(SISCHECK_DEPS)
131 127
132 128 $(ROOTLINK): $(ROOT_STRMOD_DIR) $(ROOTMODULE)
133 129 -$(RM) $@; ln $(ROOTMODULE) $@
134 130
135 131 #
136 132 # Include common targets.
137 133 #
138 134 include $(UTSBASE)/intel/Makefile.targ
139 135
140 136 #
141 137 # The ip CTF data is merged into the genunix module because these types are
142 138 # complex and heavily shared. The genunix build will execute one of the
143 139 # rules below to create an archive, ipctf.a, containing the ip objects. The
144 140 # real ip will be uniquified against genunix later in the build, and will
145 141 # emerge containing very few types.
146 142 #
147 143 $(OBJS_DIR)/ipctf.a: $(OBJECTS)
148 144 -$(RM) $@
149 145 $(AR) -r $@ $(OBJECTS)
150 146
151 147 $(OBJECTS): $(OBJS_DIR)
152 148
153 149 CLOBBERFILES += $(OBJS_DIR)/ipctf.a
154 150
155 151 ipctf.obj64: FRC
156 152 @BUILD_TYPE=OBJ64 VERSION='$(VERSION)' $(MAKE) obj64/ipctf.a
157 153
158 154 ipctf.debug64: FRC
159 155 @BUILD_TYPE=DBG64 VERSION='$(VERSION)' $(MAKE) debug64/ipctf.a
|
↓ open down ↓ |
65 lines elided |
↑ open up ↑ |
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX