Print this page
8903 IPPF paths have bad logic
Reviewed by: Dan McDonald <danmcd@joyent.com>
Reviewed by: John Levon <levon@movementarian.org>
Reviewed by: Gergő Doma <domag02@gmail.com>


  61 
  62 CFLAGS          += $(CINLINEFLAGS)
  63 
  64 CERRWARN        += -_gcc=-Wno-parentheses
  65 CERRWARN        += -_gcc=-Wno-unused-label
  66 CERRWARN        += -_gcc=-Wno-unused-function
  67 CERRWARN        += -_gcc=-Wno-unused-variable
  68 CERRWARN        += -_gcc=-Wno-switch
  69 CERRWARN        += -_gcc=-Wno-uninitialized
  70 CERRWARN        += -_gcc=-Wno-type-limits
  71 
  72 # false positives
  73 SMOFF += index_overflow
  74 
  75 # need work still
  76 $(OBJS_DIR)/igmp.o := SMOFF += shift_to_zero
  77 $(OBJS_DIR)/tnet.o := SMOFF += shift_to_zero
  78 SMOFF += signed,all_func_returns
  79 SMOFF += signed_integer_overflow_check
  80 
  81 # definitely wrong
  82 $(OBJS_DIR)/ip_input.o := SMOFF += or_vs_and
  83 $(OBJS_DIR)/ip6_input.o := SMOFF += or_vs_and
  84 
  85 #
  86 # To get the BPF header files included by ipnet.h
  87 #
  88 INC_PATH        += -I$(UTSBASE)/common/io/bpf
  89 
  90 #
  91 # Depends on md5 and swrand (for SCTP). SCTP needs to depend on
  92 # swrand as it needs random numbers early on during boot before
  93 # kCF subsystem can load swrand.
  94 #
  95 LDFLAGS         += -dy -Nmisc/md5 -Ncrypto/swrand -Nmisc/hook -Nmisc/neti
  96 
  97 #
  98 # For now, disable these lint checks; maintainers should endeavor
  99 # to investigate and remove these for maximum lint coverage.
 100 # Please do not carry these forward to new Makefiles.
 101 #
 102 LINTTAGS        += -erroff=E_SUSPICIOUS_COMPARISON
 103 LINTTAGS        += -erroff=E_BAD_PTR_CAST_ALIGN
 104 LINTTAGS        += -erroff=E_SUPPRESSION_DIRECTIVE_UNUSED




  61 
  62 CFLAGS          += $(CINLINEFLAGS)
  63 
  64 CERRWARN        += -_gcc=-Wno-parentheses
  65 CERRWARN        += -_gcc=-Wno-unused-label
  66 CERRWARN        += -_gcc=-Wno-unused-function
  67 CERRWARN        += -_gcc=-Wno-unused-variable
  68 CERRWARN        += -_gcc=-Wno-switch
  69 CERRWARN        += -_gcc=-Wno-uninitialized
  70 CERRWARN        += -_gcc=-Wno-type-limits
  71 
  72 # false positives
  73 SMOFF += index_overflow
  74 
  75 # need work still
  76 $(OBJS_DIR)/igmp.o := SMOFF += shift_to_zero
  77 $(OBJS_DIR)/tnet.o := SMOFF += shift_to_zero
  78 SMOFF += signed,all_func_returns
  79 SMOFF += signed_integer_overflow_check
  80 




  81 #
  82 # To get the BPF header files included by ipnet.h
  83 #
  84 INC_PATH        += -I$(UTSBASE)/common/io/bpf
  85 
  86 #
  87 # Depends on md5 and swrand (for SCTP). SCTP needs to depend on
  88 # swrand as it needs random numbers early on during boot before
  89 # kCF subsystem can load swrand.
  90 #
  91 LDFLAGS         += -dy -Nmisc/md5 -Ncrypto/swrand -Nmisc/hook -Nmisc/neti
  92 
  93 #
  94 # For now, disable these lint checks; maintainers should endeavor
  95 # to investigate and remove these for maximum lint coverage.
  96 # Please do not carry these forward to new Makefiles.
  97 #
  98 LINTTAGS        += -erroff=E_SUSPICIOUS_COMPARISON
  99 LINTTAGS        += -erroff=E_BAD_PTR_CAST_ALIGN
 100 LINTTAGS        += -erroff=E_SUPPRESSION_DIRECTIVE_UNUSED