Code Review for 16446

Prepared by:Dan McDonald on 2024-Apr-11 14:30 -0400 EDT
Workspace:/export/home/danmcd/ws/illumos-gate (at 31e0325225cc)
Compare against: origin/master (danmcd@code.illumos.org:/illumos-gate at 4dfe74773f66)
Summary of changes: 1493 lines changed: 85 ins; 1344 del; 64 mod; 5997 unchg
Patch of changes: 16446.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dtrace/Makefile

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
12 lines changed: 0 ins; 10 del; 2 mod; 45 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dtrace/amd64/Makefile

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
8 lines changed: 5 ins; 2 del; 1 mod; 29 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/dtrace/i386/Makefile (deleted)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
30 lines changed: 0 ins; 30 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/dtrace/sparc/Makefile (deleted)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
30 lines changed: 0 ins; 30 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/dtrace/sparcv9/Makefile (deleted)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
31 lines changed: 0 ins; 31 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/intrstat/Makefile

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
41 lines changed: 19 ins; 8 del; 14 mod; 35 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/intrstat/Makefile.com (deleted)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
68 lines changed: 0 ins; 68 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/intrstat/amd64/Makefile (deleted)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
32 lines changed: 0 ins; 32 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/intrstat/i386/Makefile (deleted)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
30 lines changed: 0 ins; 30 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/intrstat/sparcv9/Makefile (deleted)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
31 lines changed: 0 ins; 31 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/latencytop/Makefile

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
47 lines changed: 36 ins; 6 del; 5 mod; 36 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/latencytop/Makefile.com (deleted)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
83 lines changed: 0 ins; 83 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/latencytop/amd64/Makefile (deleted)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
30 lines changed: 0 ins; 30 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/latencytop/display.c (renamed and modified from usr/src/cmd/latencytop/common/display.c)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
1 line changed: 0 ins; 0 del; 1 mod; 1067 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/cmd/latencytop/dwrapper.c (renamed from usr/src/cmd/latencytop/common/dwrapper.c)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
0 lines changed: 0 ins; 0 del; 0 mod; 604 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/latencytop/i386/Makefile (deleted)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
29 lines changed: 0 ins; 29 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/latencytop/klog.c (renamed and modified from usr/src/cmd/latencytop/common/klog.c)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
1 line changed: 0 ins; 0 del; 1 mod; 225 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/latencytop/latencytop.c (renamed and modified from usr/src/cmd/latencytop/common/latencytop.c)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
2 lines changed: 1 ins; 0 del; 1 mod; 568 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/cmd/latencytop/latencytop.d (renamed from usr/src/cmd/latencytop/common/latencytop.d)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
0 lines changed: 0 ins; 0 del; 0 mod; 421 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/cmd/latencytop/latencytop.h (renamed from usr/src/cmd/latencytop/common/latencytop.h)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
0 lines changed: 0 ins; 0 del; 0 mod; 273 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/cmd/latencytop/latencytop.trans (renamed from usr/src/cmd/latencytop/common/latencytop.trans)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
0 lines changed: 0 ins; 0 del; 0 mod; 44 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/latencytop/sparcv9/Makefile (deleted)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
30 lines changed: 0 ins; 30 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/latencytop/stat.c (renamed and modified from usr/src/cmd/latencytop/common/stat.c)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
2 lines changed: 0 ins; 0 del; 2 mod; 1048 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/latencytop/table.c (renamed and modified from usr/src/cmd/latencytop/common/table.c)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
1 line changed: 0 ins; 0 del; 1 mod; 839 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/cmd/latencytop/util.c (renamed from usr/src/cmd/latencytop/common/util.c)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
0 lines changed: 0 ins; 0 del; 0 mod; 312 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/lockstat/Makefile

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
37 lines changed: 16 ins; 7 del; 14 mod; 36 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/lockstat/Makefile.com (deleted)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
63 lines changed: 0 ins; 63 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/lockstat/amd64/Makefile (deleted)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
34 lines changed: 0 ins; 34 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/lockstat/i386/Makefile (deleted)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
31 lines changed: 0 ins; 31 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/lockstat/sparcv9/Makefile (deleted)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
34 lines changed: 0 ins; 34 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/plockstat/Makefile

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
24 lines changed: 8 ins; 7 del; 9 mod; 38 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/plockstat/Makefile.com (deleted)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
52 lines changed: 0 ins; 52 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/plockstat/amd64/Makefile (deleted)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
31 lines changed: 0 ins; 31 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/plockstat/i386/Makefile (deleted)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
30 lines changed: 0 ins; 30 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/plockstat/sparcv9/Makefile (deleted)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
31 lines changed: 0 ins; 31 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/powertop/Makefile

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
6 lines changed: 0 ins; 4 del; 2 mod; 47 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/powertop/amd64/Makefile

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
1 line changed: 0 ins; 0 del; 1 mod; 43 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/powertop/i386/Makefile (deleted)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
43 lines changed: 0 ins; 43 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/powertop/i386/pt_i386.c (deleted)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
220 lines changed: 0 ins; 220 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/powertop/sparcv9/Makefile (deleted)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
44 lines changed: 0 ins; 44 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/powertop/sparcv9/pt_sparcv9.c (deleted)

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
250 lines changed: 0 ins; 250 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/developer-dtrace.p5m

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
13 lines changed: 0 ins; 5 del; 8 mod; 211 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/diagnostic-latencytop.p5m

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
5 lines changed: 0 ins; 4 del; 1 mod; 38 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/diagnostic-powertop.p5m

16446 dtrace consumers should not be isaexec'd
Change-Id: Ibf80c7283c421cba98e80dce272c6dd51d24bb87
5 lines changed: 0 ins; 4 del; 1 mod; 38 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.