Print this page 
12276 smatch-clean sockfs
Split Close
Expand all
Collapse all
          --- old/usr/src/uts/common/fs/sockfs/socktpi.c
          +++ new/usr/src/uts/common/fs/sockfs/socktpi.c
↓ open down ↓ 4803 lines elided ↑ open up ↑ 
4804 4804              (mpdata = mcopyinuio(stp, uiop, -1, -1, &error)) != NULL) {
4805 4805                  ASSERT(DB_TYPE(mpdata) == M_DATA);
4806 4806                  ASSERT(uiop->uio_resid == 0);
4807 4807                  if (!connected)
4808 4808                          linkb(mp, mpdata);
4809 4809                  else
4810 4810                          mp = mpdata;
4811 4811                  if (auditing)
4812 4812                          audit_sock(T_UNITDATA_REQ, strvp2wq(SOTOV(so)), mp, 0);
4813 4813  
4814      -                udp_wput(udp_wq, mp);
4815      -                return (0);
     4814 +                /* Always returns 0... */
     4815 +                return (udp_wput(udp_wq, mp));
4816 4816          }
4817 4817  
4818 4818          ASSERT(mpdata == NULL);
4819 4819          if (error != 0 && error != ENOMEM) {
4820 4820                  freemsg(mp);
4821 4821                  return (error);
4822 4822          }
4823 4823  
4824 4824          /*
4825 4825           * For connected, let strwrite() handle the blocking case.
↓ open down ↓ 41 lines elided ↑ open up ↑ 
4867 4867                  ASSERT(mp != NULL);
4868 4868                  if (stp->sd_wputdatafunc != NULL) {
4869 4869                          newmp = (stp->sd_wputdatafunc)(SOTOV(so), mp, NULL,
4870 4870                              NULL, NULL, NULL);
4871 4871                          if (newmp == NULL) {
4872 4872                                  /* The caller will free mp */
4873 4873                                  return (ECOMM);
4874 4874                          }
4875 4875                          mp = newmp;
4876 4876                  }
4877      -                tcp_wput(tcp_wq, mp);
4878      -                return (0);
     4877 +                /* Always returns 0... */
     4878 +                return (tcp_wput(tcp_wq, mp));
4879 4879          }
4880 4880  
4881 4881          /* Fallback to strwrite() to do proper error handling */
4882 4882          if (stp->sd_flag & (STWRERR|STRHUP|STPLEX|STRDELIM|OLDNDELAY))
4883 4883                  return (strwrite(SOTOV(so), uiop, cr));
4884 4884  
4885 4885          rmax = stp->sd_qn_maxpsz;
4886 4886          ASSERT(rmax >= 0 || rmax == INFPSZ);
4887 4887          if (rmax == 0 || uiop->uio_resid <= 0)
4888 4888                  return (0);
↓ open down ↓ 29 lines elided ↑ open up ↑ 
4918 4918                  ASSERT(error == 0 || error == ENOMEM);
4919 4919                  if (stp->sd_wputdatafunc != NULL) {
4920 4920                          newmp = (stp->sd_wputdatafunc)(SOTOV(so), mp, NULL,
4921 4921                              NULL, NULL, NULL);
4922 4922                          if (newmp == NULL) {
4923 4923                                  /* The caller will free mp */
4924 4924                                  return (ECOMM);
4925 4925                          }
4926 4926                          mp = newmp;
4927 4927                  }
4928      -                tcp_wput(tcp_wq, mp);
     4928 +                (void) tcp_wput(tcp_wq, mp);    /* Always returns 0 anyway. */
4929 4929  
4930 4930                  wflag |= NOINTR;
4931 4931  
4932 4932                  if (uiop->uio_resid == 0) {     /* No more data; we're done */
4933 4933                          ASSERT(error == 0);
4934 4934                          break;
4935 4935                  } else if (error == ENOMEM || !canput(tcp_wq) || (stp->sd_flag &
4936 4936                      (STWRERR|STRHUP|STPLEX|STRDELIM|OLDNDELAY))) {
4937 4937  slow_send:
4938 4938                          /*
↓ open down ↓ 2014 lines elided ↑ open up ↑ 
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX